Date:   Mon, 27 Feb 2023 13:36:28 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Wolfram Sang <wsa@kernel.org>, kernel@pengutronix.de,
        Evgeniy Polyakov <zbr@ioremap.net>, Crt Mori <cmo@melexis.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Javier Martinez Canillas <javierm@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] w1: ds2482: Convert to i2c's .probe_new()
Message-ID: <20230227133628.403bc581@endymion.delvare>
In-Reply-To: <20230224120600.1681685-5-u.kleine-koenig@pengutronix.de>
References: <20230224120600.1681685-1-u.kleine-koenig@pengutronix.de>
        <20230224120600.1681685-5-u.kleine-koenig@pengutronix.de>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 24 Feb 2023 13:05:55 +0100, Uwe Kleine-K=C3=B6nig wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>=20
> Link: https://lore.kernel.org/lkml/20221118224540.619276-596-uwe@kleine-k=
oenig.org
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/w1/masters/ds2482.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
> index 62c44616d8a9..3d8b51316bef 100644
> --- a/drivers/w1/masters/ds2482.c
> +++ b/drivers/w1/masters/ds2482.c
> @@ -442,8 +442,7 @@ static u8 ds2482_w1_set_pullup(void *data, int delay)
>  }
> =20
> =20
> -static int ds2482_probe(struct i2c_client *client,
> -			const struct i2c_device_id *id)
> +static int ds2482_probe(struct i2c_client *client)
>  {
>  	struct ds2482_data *data;
>  	int err =3D -ENODEV;
> @@ -553,7 +552,7 @@ static struct i2c_driver ds2482_driver =3D {
>  	.driver =3D {
>  		.name	=3D "ds2482",
>  	},
> -	.probe		=3D ds2482_probe,
> +	.probe_new	=3D ds2482_probe,
>  	.remove		=3D ds2482_remove,
>  	.id_table	=3D ds2482_id,
>  };

Reviewed-by: Jean Delvare <jdelvare@suse.de>

--=20
Jean Delvare
SUSE L3 Support