Date:   Mon, 27 Feb 2023 13:44:21 +0100
From:   Thierry Reding <treding@nvidia.com>
To:     Sumit Gupta <sumitg@nvidia.com>
Cc:     Viresh Kumar <viresh.kumar@linaro.org>,
        krzysztof.kozlowski@linaro.org, dmitry.osipenko@collabora.com,
        rafael@kernel.org, jonathanh@nvidia.com, robh+dt@kernel.org,
        lpieralisi@kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
        mmaddireddy@nvidia.com, kw@linux.com, bhelgaas@google.com,
        vidyas@nvidia.com, sanjayc@nvidia.com, ksitaraman@nvidia.com,
        ishah@nvidia.com, bbasu@nvidia.com
Subject: Re: [Patch v2 7/9] cpufreq: tegra194: add OPP support and set
 bandwidth
Message-ID: <Y/ylpaJLMOE6zY8C@orome>
References: <20230220140559.28289-1-sumitg@nvidia.com>
 <20230220140559.28289-8-sumitg@nvidia.com>
 <20230222040317.r2p6zlbumazymluc@vireshk-i7>
 <df054fae-5195-1ef8-c72e-e5afe8d901d3@nvidia.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="JhXF47xoD85VuFp4"
Content-Disposition: inline
In-Reply-To: <df054fae-5195-1ef8-c72e-e5afe8d901d3@nvidia.com>
User-Agent: Mutt/2.2.9 (2022-11-12)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ReUa7MkLBvDbjKxNpF3sdo2/WYvVmqecq5x4Ras2Vu1R9YYu/RsYYvKk8587?=
 =?us-ascii?Q?CQN3zCXLp9B+JHDiSUtOsSaHky4DXIwvklXqE3/T3Z6NIzgDJoFLdi/9WlTI?=
 =?us-ascii?Q?7D2tKAlUQkpI9Y1bJuFazt9ssufs3xYVmISMbOmlayl3nJBnrOlg6ixZpem4?=
 =?us-ascii?Q?BoiryxHkzn9oqZz7GhYRUK68QXoccZL1gRA+TyrvbXv3nweNsfZUwjxe/Dye?=
 =?us-ascii?Q?OO2i8sB72FOGqQQ65p1RBiHnyX7BLyaprcfAUxGWemsypxjQqdGIVzAj95z3?=
 =?us-ascii?Q?LnjAO1RGM2gQJ6sRds2L0YXmbz+yuzFsapfQqVjKcuuBqsZrwQk8zGmGjpoT?=
 =?us-ascii?Q?q0pVYhqvGmnTIL61sHL6vzzEo7NMWYYqFGL/jiBeJRSNwOHuYIDhEFMAeJda?=
 =?us-ascii?Q?r0WIkEIDJhEcAHj07CHpNKOFG4hyG+zrDElfWsXDb70uTTKATBT00EuzUXg3?=
 =?us-ascii?Q?tjARYne/mleVh/O7xp9iciaNk8PgQluwrT3qPmt/kuU35rlAUZ48wV11CDad?=
 =?us-ascii?Q?TTwJaxbQD5AbVwD2nB1aMUEuOXtwr1I7mmvi9JEUQq0eUOlDnyceGOdEidIb?=
 =?us-ascii?Q?AobcY2g44apIM9ylhM/gfEgjgozaBoj4ZQgMNVU25Jk6eS+AxwIVNtdogGcv?=
 =?us-ascii?Q?35WRRjqQ9fTDIYeimbABEcCn23cvXeo8P9KfXLWg3o3dQD9Ow5zOOLOocFN2?=
 =?us-ascii?Q?lj4EhSLyiDeuxIdv3NmWolmshPdJbI7u/OEk8RtFSISSp/ASAvQEK4LCK4NG?=
 =?us-ascii?Q?9CvaE+hxGKAmTA06xBf21Mq4cswKU7gG3gVQwp9pxgi3UO001gCj8abofPxX?=
 =?us-ascii?Q?ixuCpSUFLzjzJgKIfW5kxwxbfV71SJtHZ9CkhQGCDjPWVfBy4Cls+uxGHwPf?=
 =?us-ascii?Q?fa/+9McbYgRCmjpnh+SI4wEGsHNsKQw35mI08zcPQ3ZHkqZslrxxwXUg7e4q?=
 =?us-ascii?Q?e+Jxehze439voJgW1k1WRtvw2J6FfLyvebVo663AoHRLNxcrcXDTxaY1i4Bu?=
 =?us-ascii?Q?LRelvx5xTBgA0hbuziZ6VmQ9PV26zVrO0d4utiy1SL7IzSq+fbE8LbojQ1SB?=
 =?us-ascii?Q?9KcZUqB5dPPKlBFH1Ee64MBv5bUl3616CyKIcUTTnkRHpV3njt1X8Rv1MqM5?=
 =?us-ascii?Q?5Twr9i3TTlQuUuhLqkNHXmCMOA9FS7pCLscDUuMQaFX3edn2HP3nyILiGaUl?=
 =?us-ascii?Q?kwuWYpHJq9EQioRluVTjjFCmDoqyF83rPe3emPHoN1JLclZYSaQkWXhz+pCc?=
 =?us-ascii?Q?Um6F5JYwPunFh2ClCRZJNTBkQasF3nAk6O2/FfiUeoyARYzAfvxijwLyZLje?=
 =?us-ascii?Q?HnWRLt0ZHzE12JG696p0X3/6WF38F7mc66bLwWvPNyvO9eAOtdMQGOZXaVOU?=
 =?us-ascii?Q?7ol6ZNXv6qm6DgjhJrKwFDFW8f2esvzVhuXvgUmQsQeIEY86uXk91wO5S2RD?=
 =?us-ascii?Q?Vis/ptG3d8RvyGmYg1+gJ6cds/IqAxILIS4i5QI8tJ3J1cz2dE6yTKS+HGz4?=
 =?us-ascii?Q?3HF5mxQHy3GO65T0mbdbdsPvYbsXUGTE2YaiwLszg8LGKiVPAPSsWXnZPb0s?=
 =?us-ascii?Q?Z8CtVEFMtAaZXIEoKdDPLo+whKj0ViGzv2UBt/crNceUmifqb4ooZJiCQ/o9?=
 =?us-ascii?Q?1OY1GeRFHuhy2fKGsxb15r/NVehuWMTUONxTjEeiBe8T?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 764317cd-9ce3-496c-6c9d-08db18c05e40
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5413.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 12:44:30.1030
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: megVDuOT3616NrhnbTc96zJF4fV/W8F6SMYWmYqHLXZsiLhb2Mge3u7oxALpH9Y0RTwIi6OVSQfhynclOQfg0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7473
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--JhXF47xoD85VuFp4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 23, 2023 at 03:06:26PM +0530, Sumit Gupta wrote:
>=20
>=20
> On 22/02/23 09:33, Viresh Kumar wrote:
> > External email: Use caution opening links or attachments
> >=20
> >=20
> > On 20-02-23, 19:35, Sumit Gupta wrote:
> > > +static int tegra_cpufreq_set_bw(struct cpufreq_policy *policy, unsig=
ned long freq_khz)
> > > +{
> > > +     struct dev_pm_opp *opp;
> > > +     struct device *dev;
> > > +     int ret;
> > > +
> > > +     dev =3D get_cpu_device(policy->cpu);
> > > +     if (!dev)
> > > +             return -ENODEV;
> > > +
> > > +     opp =3D dev_pm_opp_find_freq_exact(dev, freq_khz * KHZ, true);
> > > +     if (IS_ERR(opp))
> > > +             return PTR_ERR(opp);
> > > +
> > > +     ret =3D dev_pm_opp_set_opp(dev, opp);
> > > +     dev_pm_opp_put(opp);
> >=20
> > What about dev_pm_opp_set_rate() instead ?
> >=20
> > > +     return ret;
> > > +}
> >=20
> > --
> > viresh
>=20
> Tried using it and got below crash. It seems to be coming because we don't
> have clocks property within CPU node for SoC's having BPMP-FW.
>=20
>  Unable to handle kernel NULL pointer dereference at virtual address
> 000000000000002e
>  ....
>  Call trace:
>   clk_round_rate+0x38/0xd8
>   dev_pm_opp_set_rate+0xe4/0x1a8
>   tegra194_cpufreq_set_target+0x74/0x88
>   __cpufreq_driver_target+0x154/0x250
>   cpufreq_online+0x7b4/0x9ac

Can you try to find out what exactly is happening here? The clock
framework should be able to deal with NULL clock pointers just fine.
Although, looking at the OPP table code, it seems like we don't use
clk_get_optional(), so opp_table->clk may end up being a pointer-
encoded error. Perhaps we need something like this:

--- >8 ---
diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index e87567dbe99f..d7baeb6ac697 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -1397,6 +1397,7 @@ static struct opp_table *_update_opp_table_clk(struct=
 device *dev,
 		 * frequency in opp->rates and also parse the entries in DT.
 		 */
 		opp_table->clk_count =3D 1;
+		opp_table->clk =3D NULL;
=20
 		dev_dbg(dev, "%s: Couldn't find clock: %d\n", __func__, ret);
 		return opp_table;
--- >8 ---

Thierry

--JhXF47xoD85VuFp4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmP8paIACgkQ3SOs138+
s6FQkA/9GQwfLDQT8afea52M7v0dEObVP95WqPe9eP8SGwPv8uE7zP9HKE0OSQT1
cR7m2FTf5b8ax4hkEU6Hs3QaIWEt0sGvMcdeUgav7EiKC8C0ZIG/JEPrfCh4uecC
fXZzUFw1TQIguTuF/nAPcME5RNHt6FoY5Et1mlmeGEG7PKYTTHgvGj07VHzcQM1V
P/+v/awn1VbpPJ+FCMvU9iidcYmz9Pf5YXYa8M7cWbLc/apepfx75rgnRI/TPjfK
yijURhsz88m9wrf8iPYgG9GElim5aCbYRU3DlRuyR0Az30PbyxNygHSGblpBNzNT
9Rqw8ziIzn/tkg8F3/wpvNdauuNoHDbDgCCXYunuv+9rLBW/A2RV1s2TKos4E1C1
61cuB3rMzYEZHEPXDn4ct8oazyu7HPZe9pZcLLkumOjE0t+1XyftqhIX30RLLTxL
67nkK9euJDfwiatToAHq6TU12429INYfAwOkIcpozzF2IqZ+MOlGkqnfCahIa7sz
Oe0YF8Abm9c25e2LzPYdRaNlhVDq0wJmKVkJAr/X2r4p9/n9eSK3ZWLEqkAmASZv
8V+SO2Nv1VOeKU6vNNI9ytpln0Jm4svBoeoEO9wltWqb1rgwX0VrmrJqmfEtEeIX
Z5drNetU+OEuz5SqJrLnEzv1rKHfdWksTFFbvTEdcXwjvfCrT8M=
=KaEv
-----END PGP SIGNATURE-----

--JhXF47xoD85VuFp4--