Date:   Mon, 27 Feb 2023 13:18:18 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Sascha Hauer <sha@pengutronix.de>
Cc:     linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
        kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: About regulator error events
Message-ID: <Y/ytmh9QrXN9Tw17@sirena.org.uk>
References: <20230227130542.GM32097@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qb9y2E/9/0TA1vTZ"
Content-Disposition: inline
In-Reply-To: <20230227130542.GM32097@pengutronix.de>
Precedence: bulk


--qb9y2E/9/0TA1vTZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 27, 2023 at 02:05:42PM +0100, Sascha Hauer wrote:

> The strategy I had in mind was to disable the regulator, enable it again
> to see if the errors persists and if it does, permanently disable the
> device.  Disabling the regulator only works though when there's only one
> consumer.  With multiple consumers only the enable count decreases, but

Might also be a good idea to turn off any other supplies to the device
as well but yes.

> A first good step might be to notify the user somehow. While we can get
> the overcurrent status of a regulator from
> /sys/class/regulator/*/over_current there doesn't seem to be any way to
> get a regulator event in userspace, right?  Would patches changing that
> be welcomed?

Sure.

> There doesn't seem to be much prior art for handling regulator error
> events in the kernel. It would be great to get some input what others do
> in this situation, or to get some ideas what they would do if they had
> the time to do so ;)

The general issue is that if the regulators get upset enough to start
complaining something has generally gone really badly wrong and there
isn't anything constructive that can be done other than logging.  You
might potentially want to power off the system as a whole or something
too.  I do think any big actions are going to be userspace policy
things.

--qb9y2E/9/0TA1vTZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP8rZkACgkQJNaLcl1U
h9DeFQgAhPYK3DRv220gpQLpEwPGJieeofQ5tB1x3GYHBxmXMD1RjkTj5ZEDvPSt
/kKbAQFaTW4A9VXeklarIjF0BLHnf7q62/MkVl2B9nG7dV+w9iCj/Qudu8LcZPQt
DTEHPcTszELqYhNBWHZv3P15kl73J+lg/vLht0JmoT8eHbkRINBzDdsMINAWmY6T
jMQreKbWuZRon2yYZhQczWOrqrOnyYJ0NR17QeIn5Wckc0z2GjWxFWHVlioYxjGV
dmCs8SOTXNlUKk5n32LgTVS9jhnIQxPCv2xGlUa+ccgl+9dQdcPs3JJQnIpmMo9f
454kxniD7Iym92bkfdArBiM2kWzFhA==
=GTmk
-----END PGP SIGNATURE-----

--qb9y2E/9/0TA1vTZ--