Date:   Mon, 27 Feb 2023 13:19:46 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Sascha Hauer <sha@pengutronix.de>
Cc:     linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
        kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
        Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: About regulator error events
Message-ID: <Y/yt8nzVuO4sUg3v@sirena.org.uk>
References: <20230227130542.GM32097@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pINIVsOxWDmKzuCu"
Content-Disposition: inline
In-Reply-To: <20230227130542.GM32097@pengutronix.de>
Precedence: bulk


--pINIVsOxWDmKzuCu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 27, 2023 at 02:05:42PM +0100, Sascha Hauer wrote:
> I have a board here which has some current limited power switches on it
> and I wonder if I can do something reasonable with the error interrupt
> pins these switches have.

Just noticed that Matti (who's been doing a bunch of work here) wasn't
CCed so adding him.

> The devices do not have a communication channel, instead they only have
> an enable pin and an error interrupt pin. See
> https://www.diodes.com/assets/Datasheets/AP22652_53_52A_53A.pdf for a
> datasheet.  The devices come in two variants, one goes into current
> limiting mode in case of overcurrent and the other variant switches off
> until it gets re-enabled again.
>=20
> At first sight it seemed logical to me to wire up the error interrupt
> pins to REGULATOR_EVENT_OVER_CURRENT events. That was easy to do, but
> now the question is: What can a regulator consumer do with these events?
>=20
> The strategy I had in mind was to disable the regulator, enable it again
> to see if the errors persists and if it does, permanently disable the
> device.  Disabling the regulator only works though when there's only one
> consumer.  With multiple consumers only the enable count decreases, but
> the regulator itself stays enabled. This means implementing such a
> policy at the consumer side is not generally possible. Implementing a
> policy in the regulator core seems awkward as well, as a good strategy
> likely differs between different consumers.
>=20
> A first good step might be to notify the user somehow. While we can get
> the overcurrent status of a regulator from
> /sys/class/regulator/*/over_current there doesn't seem to be any way to
> get a regulator event in userspace, right?  Would patches changing that
> be welcomed?
>=20
> There doesn't seem to be much prior art for handling regulator error
> events in the kernel. It would be great to get some input what others do
> in this situation, or to get some ideas what they would do if they had
> the time to do so ;)
>=20
> Sascha
>=20
> --=20
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--pINIVsOxWDmKzuCu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP8rfIACgkQJNaLcl1U
h9BIAAf9EdwlthF5Bi25GDzhA1opCmMP1AUBGw/rh/jl0creSfO7ArhMNz2thZU2
2bpeG9C2Q+LRTIb9KEFDud6bAKMKR4NM4kOs9aCYyLzYGfwPkIMazevinW7ptBl+
NsXeGUN23GMSPbSjA40TyOeUd+W8sumYzZSC4/VxreiJH/qFN5X77F5juoZfwj0+
Q2RdQRFp9oKzE2sVksiaEPfeAoss5KrlDA6i4IGMa2zdmMMccwgz1jiuD43/3FY2
BPVzrZ13J0oViuxsByjVleh7F8uQmJPf8pA+ftUPTSi2JEld5nkeCvTSAG+FZjCq
E6IBpfM/yojLv/MibgAP7LClVyCjHQ==
=h+H3
-----END PGP SIGNATURE-----

--pINIVsOxWDmKzuCu--