Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73826C7EE31 for ; Mon, 27 Feb 2023 14:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbjB0OJz (ORCPT ); Mon, 27 Feb 2023 09:09:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbjB0OJx (ORCPT ); Mon, 27 Feb 2023 09:09:53 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8CCD525E; Mon, 27 Feb 2023 06:09:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b9phfdI9TMx72ilBp0eEoM6G1VduC5sCkR9fo7UPGL8=; b=vf/+dGjTdV4w1ejSFMgL+CRWNn ncZSHWtbNFAxGnRFo3OcpkpBXswgmlXKwvAhu9kkpcBv9nEXAvql0WL5JIoAVS3nOdG+0sDcijR2c hzCynyWfzljSy91esLtfEhX5BqIKfiZ0Q0itzem08XBOEHiYNa1h6IqR4Cf4Zb/Esrw2LRsCFZ8PT /2IFs/WxyboR/j0j52o8fnbRfDZMrxAKxgi9orL4aoNVaSKgRTXgAlvlj629j9TAz3TjNWIndvR7V 4UqAuhMOVkuAQp5lkajlUXe3jD+xqZIlSHgYGJQz9H/ozINGvxrzxUEBTYhl3rGK3QAU1jFTNmi7d tSz4JyUA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWeCK-0009om-D9; Mon, 27 Feb 2023 14:09:48 +0000 Date: Mon, 27 Feb 2023 14:09:48 +0000 From: Matthew Wilcox To: David Howells Cc: linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Hugh Dickins , linux-kernel@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH 4/5] afs: Zero bytes after 'oldsize' if we're expanding the file Message-ID: References: <20230202204428.3267832-5-willy@infradead.org> <20230202204428.3267832-1-willy@infradead.org> <2730679.1677505767@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2730679.1677505767@warthog.procyon.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 27, 2023 at 01:49:27PM +0000, David Howells wrote: > Matthew Wilcox (Oracle) wrote: > > > POSIX requires that "If the file size is increased, the extended area > > shall appear as if it were zero-filled". It is possible to use mmap to > > write past EOF and that data will become visible instead of zeroes. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > That seems to work. Do you want me to pass it on to Linus? If not: > > Acked-by: David Howells I'll send a patch series with all of this; it doesn't seem terribly urgent. Do you think there's a similar problem for AFS that Brian noted with the generic patch?