Date:   Mon, 27 Feb 2023 15:21:04 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v3 15/20] thermal/hwmon: Use the thermal_core.h header
Message-ID: <20230227152104.4f901340@endymion.delvare>
In-Reply-To: <20230226225406.979703-16-daniel.lezcano@linaro.org>
References: <20230226225406.979703-1-daniel.lezcano@linaro.org>
        <20230226225406.979703-16-daniel.lezcano@linaro.org>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 26 Feb 2023 23:54:01 +0100, Daniel Lezcano wrote:
> The thermal_hwmon is playing with the thermal core code
> internals. Changing the code would be too invasive for now.
> 
> We can consider the thermal_hwmon.c is part of the thermal core code
> as it provides a glue to tie the hwmon and the thermal zones.
> 
> Let's include the thermal_core.h header.
> 
> No functional change intended.
> 
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/thermal/thermal_hwmon.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> index bc02095b314c..c59db17dddd6 100644
> --- a/drivers/thermal/thermal_hwmon.c
> +++ b/drivers/thermal/thermal_hwmon.c
> @@ -17,6 +17,7 @@
>  #include <linux/thermal.h>
>  
>  #include "thermal_hwmon.h"
> +#include "thermal_core.h"
>  
>  /* hwmon sys I/F */
>  /* thermal zone devices with the same type share one hwmon device */

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support