Message-ID: <ca1f4970-206d-64f2-d210-e4e54b59d301@intel.com>
Date:   Mon, 27 Feb 2023 15:31:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac grouping
 for ethtool statistics
Content-Language: en-US
To:     Vladimir Oltean <olteanv@gmail.com>
CC:     Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <woojung.huh@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <andrew@lunn.ch>, <f.fainelli@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
References: <20230217110211.433505-1-rakesh.sankaranarayanan@microchip.com>
 <20230217110211.433505-4-rakesh.sankaranarayanan@microchip.com>
 <84835bee-a074-eb46-f1e4-03e53cd7f9ec@intel.com>
 <20230217164227.mw2cyp22bsnvuh6t@skbuf>
 <47a67799-27d9-094e-11c3-a18efcf281e2@intel.com>
 <20230224215349.umzw46xvzccjdndd@skbuf>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230224215349.umzw46xvzccjdndd@skbuf>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEhKblRlcFdwa1pQdVlCNWRjL0FMaGtzYVROWTZCZ21JbTRRcUdYT0hqVUJU?=
 =?utf-8?B?K3czV01DUzVzYlhYOHlDcUV2cWppdXJWT3FmSE1YY0tXMW5sUjZlNjBhTnVS?=
 =?utf-8?B?OEppcDY2N3A3bGFxaTV1eTArQ0xZcGtldU1TUnBLcU9lWXZVTmtWRWNuVCs4?=
 =?utf-8?B?L1R0UHFZZ29HRU9RYWtheDE2b3haaGVDR0I2eTBVZ1FwR3N6ZFBBakJGaUQ5?=
 =?utf-8?B?OXhUbllGbWkrRTNhdkdsN0pLbXUzK1YvTS9GM0x5OGcxK05vRjZnMXFwcUMv?=
 =?utf-8?B?STNoUzdDNi9TWEdJbnlCcFp1TEJiZnR0Rm9qYXVBYUJUS1I5VHJzUDE4dldT?=
 =?utf-8?B?UUcrODI5bkFUbGpWZ0ZKUGY1V0ptLzNGVVRjVjZQUlFiUnJTQk5UL0prSnAv?=
 =?utf-8?B?a1l5QVZ6cHB6bDRZUWY1NEFwVVJYQXRBU0ljNTNCb3FxRkM3VjVNRzBTVTVZ?=
 =?utf-8?B?dTNRa0p2RWJLTjVmMEdWY0xyV0c4MDZiVFJZMFdjVlNBaHVpc3FxdGh0Ui9B?=
 =?utf-8?B?OGpiSjBjMWpGUXdEeUwvTk1EZVJkRzYwTXRYbG5XQVkyR21OUm9sZEZ3aVRS?=
 =?utf-8?B?a0IxWkVYOVBNRDErYUJNZUVLYmNiRWt3b2NRWFBER2V6Qmh0bHhwemdiNkRt?=
 =?utf-8?B?OTAwbWF4RkdKRzNKMDM3TURhOGpFbkMwMExZZUwxM01mamRsT25kS3pNRyt3?=
 =?utf-8?B?UXYyYndRTzVLL1BDbkdqcUxXNCtDUWRQWlVuTGVKbjFXRTRNSDlvYlVONzN0?=
 =?utf-8?B?bWZRTHBhUW5MN3R3K0dRbGs5VDN2RDlJUGlXdmNNYUxOSEpUN012dEI1Szkw?=
 =?utf-8?B?MUpnemdRdGxURHZ3RkRGZXhOdXA3YTJDWGFKSG9sRWJiUUVsODJPQ28rcDd4?=
 =?utf-8?B?Lyt1WVlqQlNJZzFRSCtEY282SGEvMmRCSkgzekJjWUVacEd3Y1U1a1NrbzRk?=
 =?utf-8?B?Z0FiaW8xdGsvNENUL3EvNTZrQnNnNzdCVkpONW1XTmxzRWw5MkVNNVRsaTFC?=
 =?utf-8?B?WVNiMG1ObGh0c2tGajhFayswSGc4TTJzRjRCQnpVc2t5WGlya3JNUDJKV0Vr?=
 =?utf-8?B?SjNEcmpmNDRVd3VRdGx6UXU3RVovS0pGM2ZVSXlUN1VoR3pnVDZ3TWZFQTVY?=
 =?utf-8?B?b1IwS0V0MGNzMnFIZ1EvRVNEbjkweXUyb1BkOFYvaEF5WVNmZnhaNm9iNzUy?=
 =?utf-8?B?Q3MrbWpKSXBkcVVNNzNPdlF0c3cwOVpiT1lhclJ5R0IyZFgxUUVwOEk5VWZq?=
 =?utf-8?B?VlovRXk5Z0JmR1AwMHN2Y1hJSFpaK3ZjMk96U250cFNRZitvVWN5djNPNWJW?=
 =?utf-8?B?UVFmZGpNbHhxaVlxR2h0Tk5OYzVaYXFSRTJWWkYrajBtNlArR1poOUliL1pp?=
 =?utf-8?B?V2tNcDRuaXptTWMyWGNRUytFOXZXdkx6SnkwZnNLZEQ5a3RaVldRN0xIR3d1?=
 =?utf-8?B?bmxENE1hWUp6d2s3ajNTZHV1TGRKNWR4OGt0T2xtc1hOeHE2TjgxeTlQOFcx?=
 =?utf-8?B?WkpTSU5yb2lTb0taL1dISkllRWE0Rk5IRVZWUVljOVZOOEJLNTJONUN6cEJk?=
 =?utf-8?B?OU5NNXVsZDBubkNob1hiaURBaENETkt1Umk2UExBQkxRQk9nYXRJbUphRjc2?=
 =?utf-8?B?UjEyMlVPd2VENEx6VFBmSHVQQmFDTDJmQWFHbEtZMkozdmpNbDZqK0hGc1ZR?=
 =?utf-8?B?N2F2STVQQzVzdkFqdzRzN1FNMndiM2lobU1iOUZabFFGQ0krczNoTk1kZzNY?=
 =?utf-8?B?WmhWZWlwZlBDaFI4L01jSGtidDQ0QzdxQlEwOHo0SFRsZkwvL01zbXlBbjJU?=
 =?utf-8?B?bWg2VktOVWNMd3FQU2E4V0tQOXRBaUJicXhlTlJQZFIzWG1mMFBzNVl2SlYr?=
 =?utf-8?B?cGlxaDFXZWtWWEVOQ1B5UDJaZ0lPRlhUeGpwQ3pJdWs5MXZVTVFDY0dsbDFR?=
 =?utf-8?B?ZTR5eEVSVkdnckRzU1VIZFNDT2hucmt0NWgvQXJ6eVBVVk5veHY2eGdqOWNB?=
 =?utf-8?B?bXQ3bEo1cmx2SUU1T01DZVhuQUtQNGU1bVJyR1VTeUJUYURScmNlcndCUXpo?=
 =?utf-8?B?MWk4Tnl5aDA0Wm9aMFVpU3RoUi91K3BCQ1dhRFk0ZFIwUytxd1lwbG13N3JM?=
 =?utf-8?B?U2N1TzdTS1czY3pFTm1GbTVDVjBMWHZIMDVWd2tDeDJpaFUxdlY2TUI2akJS?=
 =?utf-8?Q?0Qn5gPEtXD5VZI8qevxnGJc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7782880f-fdef-4c02-3046-08db18cf75f9
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:32:32.2431
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A3VnxM86bUip0BPa3VWCTxbgVxZqIIF5WiAhKpnfVAd7jl4iZ6n4gnJEfxh+9U5yaHxALc4Gp62742aVltzA9ZQ2hR93XqfSKZKlbUB9ZXQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8216
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Vladimir Oltean <olteanv@gmail.com>
Date: Fri, 24 Feb 2023 23:53:49 +0200

> On Fri, Feb 24, 2023 at 05:07:01PM +0100, Alexander Lobakin wrote:
>> It's not so common for people to show up back in the thread after you
>> ask them to show godbolt / asm code comparison.
> 
> idk what godbolt is, but if it's some sort of online compiler, then I
> suppose it's of limited usefulness for the Linux kernel.

Yeah it's an online compiler, which can spit out assembly code. For
testing non-complex stuff or macros it's often enough.

> 
> Easiest way to see a disassembly (also has C code interleaved) would be
> this:
> 
> make drivers/net/dsa/microchip/ksz_ethtool.lst

Oh, nice! I didn't know Kbuild has capability of listing the assembly
code built-in. I was adding it manually to Makefiles when needed >_<
Thanks! :D

> 
> This is also useful to see precisely which instruction went boom in case
> there's a NULL pointer dereference or something like that.

Thanks,
Olek