Message-ID: <2e8c8937-b027-8b20-a16b-3dfed8217ad2@debian.org>
Date:   Mon, 27 Feb 2023 14:52:15 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.7.2
Cc:     leit@meta.com, axboe@kernel.dk, tj@kernel.org,
        josef@toxicpanda.com, cgroups@vger.kernel.org,
        linux-block@vger.kernel.org, aherrmann@suse.de, mkoutny@suse.com,
        linux-kernel@vger.kernel.org, leit@fb.com
Subject: Re: [PATCH v2] blk-iocost: Pass disk queue to ioc_refresh_params
To:     Christoph Hellwig <hch@lst.de>
References: <20230227135610.501884-1-leitao@debian.org>
 <20230227140847.GA18644@lst.de>
From:   Breno Leitao <leitao@debian.org>
In-Reply-To: <20230227140847.GA18644@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Christoph,

On 27/02/2023 14:08, Christoph Hellwig wrote:
> Hi Breno,
> 
> and sorry for the late reply.  This looks correct to me, but I'd
> be much happier if the disk was passed in instead of the request_queue
> as that's where we're generally heading.  If you don't have time to
> respin I could live with this version for a fix, though.

No worries, I can definitely do a respin passing the disk instead of
request_queue.

I hope to send a v3 in the next few hours.