MIME-Version: 1.0
References: <20230227-kobj_type-x86-efi-v1-1-a335952d2536@weissschuh.net>
In-Reply-To: <20230227-kobj_type-x86-efi-v1-1-a335952d2536@weissschuh.net>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Mon, 27 Feb 2023 17:34:38 +0100
Message-ID: <CAMj1kXGwZxjjB3ojmH5cHDOLnveGY2vSz7t=xgj2dN7dg1K09Q@mail.gmail.com>
Subject: Re: [PATCH] efi: x86: make kobj_type structure constant
To:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, linux-efi@vger.kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 27 Feb 2023 at 04:09, Thomas Wei=C3=9Fschuh <linux@weissschuh.net> =
wrote:
>
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>

Thanks, I'll queue these up after the merge window.

> ---
>  arch/x86/platform/efi/runtime-map.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/efi/runtime-map.c b/arch/x86/platform/efi/=
runtime-map.c
> index bbee682ef8cd..a6f02cef3ca2 100644
> --- a/arch/x86/platform/efi/runtime-map.c
> +++ b/arch/x86/platform/efi/runtime-map.c
> @@ -93,7 +93,7 @@ static void map_release(struct kobject *kobj)
>         kfree(entry);
>  }
>
> -static struct kobj_type __refdata map_ktype =3D {
> +static const struct kobj_type __refconst map_ktype =3D {
>         .sysfs_ops      =3D &map_attr_ops,
>         .default_groups =3D def_groups,
>         .release        =3D map_release,
>
> ---
> base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
> change-id: 20230227-kobj_type-x86-efi-7591b1343b08
>
> Best regards,
> --
> Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
>