Date:   Mon, 27 Feb 2023 17:23:09 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Ye Xiang <xiang.ye@intel.com>
Cc:     Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        linux-gpio@vger.kernel.org, srinivas.pandruvada@intel.com,
        heikki.krogerus@linux.intel.com, andriy.shevchenko@linux.intel.com,
        sakari.ailus@linux.intel.com, zhifeng.wang@intel.com,
        wentong.wu@intel.com, lixu.zhang@intel.com
Subject: Re: [PATCH v2 4/5] spi: Add support for Intel LJCA USB SPI driver
Message-ID: <Y/zm/Uk/d6VRxLBx@sirena.org.uk>
References: <20230225140118.2037220-1-xiang.ye@intel.com>
 <20230225140118.2037220-5-xiang.ye@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="N252Zu7nZpqEMZYb"
Content-Disposition: inline
In-Reply-To: <20230225140118.2037220-5-xiang.ye@intel.com>
Precedence: bulk


--N252Zu7nZpqEMZYb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Feb 25, 2023 at 10:01:17PM +0800, Ye Xiang wrote:

> +struct spi_xfer_packet {
> +	u8 indicator;
> +	s8 len;
> +	u8 data[];
> +} __packed;

> +static int ljca_spi_read_write(struct ljca_spi_dev *ljca_spi, const u8 *w_data, u8 *r_data, int len,
> +			       int id, int complete, int cmd)
> +{
> +	struct spi_xfer_packet *w_packet = (struct spi_xfer_packet *)ljca_spi->obuf;
> +	struct spi_xfer_packet *r_packet = (struct spi_xfer_packet *)ljca_spi->ibuf;
> +	unsigned int ibuf_len = LJCA_SPI_BUF_SIZE;
> +	int ret;
> +
> +	w_packet->indicator = FIELD_PREP(LJCA_SPI_XFER_INDICATOR_ID, id) |
> +			      FIELD_PREP(LJCA_SPI_XFER_INDICATOR_CMPL, complete) |
> +			      FIELD_PREP(LJCA_SPI_XFER_INDICATOR_INDEX,
> +					 ljca_spi->spi_info->id);
> +
> +	if (cmd == LJCA_SPI_READ) {
> +		w_packet->len = sizeof(u16);
> +		*(u16 *)&w_packet->data[0] = len;

Are there no endianness considerations here?

> +static int ljca_spi_transfer(struct ljca_spi_dev *ljca_spi, const u8 *tx_data,
> +			     u8 *rx_data, u16 len)
> +{

This function has one caller with barely anything in it - perhaps just
inline it?

--N252Zu7nZpqEMZYb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP85v0ACgkQJNaLcl1U
h9BIlwf+Nbje3veuBnpfv+ZeclyBPPaTReO9MEpZHFwpOILoA2mQxVdtQ5DBqObm
mnXmP3TdRdJvYf4n0MxtflxvgukIGaQoDm7LHx3JxeRESqtTpORJS8S3CkCWQATF
2Ui/NP1tvJILrljgtOWTI1UmvWXprj8wz4UsUY1mxcDLwKKbEvAe7UOXnB1dZEW8
m7Bo2PXG9URgmLsk1/nnGyZEkLquy2z2pqXUIWfHz7N1lgbbXbYyB7SWsFUeYGg4
sUvHu0PcSMbm83+RGm+xzA/LcTJ2BOgKZFXF6scLdijA0nu2nPf0d7UCMonsPDqr
wxUmVY06/ThUdahIiJArdgBJSkG13g==
=mOKa
-----END PGP SIGNATURE-----

--N252Zu7nZpqEMZYb--