Date:   Mon, 27 Feb 2023 18:23:14 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc:     "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Message-ID: <Y/z1Eu3DUaU/Dbfh@sirena.org.uk>
References: <20230224163513.27290-1-kyarlagadda@nvidia.com>
 <Y/jqCRAenwbqc1Uu@sirena.org.uk>
 <DM4PR12MB5769BDB91342A9768207BD84C3A89@DM4PR12MB5769.namprd12.prod.outlook.com>
 <Y/j6MxmOkZj/TKej@sirena.org.uk>
 <DM4PR12MB576994B630B7D8F43BD21F73C3AF9@DM4PR12MB5769.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2HZkfV0rKk8TfY0+"
Content-Disposition: inline
In-Reply-To: <DM4PR12MB576994B630B7D8F43BD21F73C3AF9@DM4PR12MB5769.namprd12.prod.outlook.com>
Precedence: bulk


--2HZkfV0rKk8TfY0+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 27, 2023 at 10:36:18AM +0000, Krishna Yarlagadda wrote:

> > > > > -	if (!xfer->cs_change) {
> > > > > -		tegra_qspi_transfer_end(spi);
> > > > > -		spi_transfer_delay_exec(xfer);
> > > > > -	}
> > updating the length of the message.
> > > > This looks like it'll do the wrong thing and do a change on every
> > > > transfer if cs_change isn't set?

> > > This condition is hit only in data phase which is end of message.

> > Shouldn't this just be moved into the DATA_TRANSFER case statement?
> Calling transfer_end after updating message length.

Something seems to be mangled with your quoting/new text here so it's a
bit unclear what you're saying here but if you're saying that this is
due to needing to call tegra_qspi_transfer_end() after updating the
length I'm not sure why - AFAICT that function doesn't reference the
transfer length at all, it just writes out a command to configure the
chip select?  There's no issue with the message being finalised since
that happens in the caller.

--2HZkfV0rKk8TfY0+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP89REACgkQJNaLcl1U
h9BSoQf/exwMXkkgkpWrC/U9YS7grsX08GeZwu7g4nFvvAFnAMqcVB3rTRbLGKAM
DkkyfNvw9vFtYJmBq3WdfLkRuQ9iHAzREsq38jnYeso9vP6b3xleFb2yfXB1IXEM
A+CNWasqvA5IFo0jx1fQBxpAaMBGr6IEKvTS2xjewMItIr4JXkfNCBVuSUvREat2
xKxZMH+pQvRSF3oSa2w6sOGnwYAyglqcppDsO5AzdZJ+cXoQkwBPHwxWcXE/ZsxR
MAFGb8V7/08Nh0r7v8LUhXpa5qtgnH3S/QzPXFeJCf+GGjP+KRp035YLj6z2EkcS
Dj8zVpN0Yo5PnjAe8bMNonu5hO4q2w==
=eiGn
-----END PGP SIGNATURE-----

--2HZkfV0rKk8TfY0+--