From:   Krishna Yarlagadda <kyarlagadda@nvidia.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>
Subject: RE: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Thread-Topic: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Thread-Index: AQHZSG4K8+wSVKmZRkimkrAiwHDmq67eTmSAgAAAM/CAABMSgIAENYWggACJEQCAABVWIA==
Date:   Mon, 27 Feb 2023 19:44:05 +0000
Message-ID: <DM4PR12MB57694C0EEA61D168D3267197C3AF9@DM4PR12MB5769.namprd12.prod.outlook.com>
References: <20230224163513.27290-1-kyarlagadda@nvidia.com>
 <Y/jqCRAenwbqc1Uu@sirena.org.uk>
 <DM4PR12MB5769BDB91342A9768207BD84C3A89@DM4PR12MB5769.namprd12.prod.outlook.com>
 <Y/j6MxmOkZj/TKej@sirena.org.uk>
 <DM4PR12MB576994B630B7D8F43BD21F73C3AF9@DM4PR12MB5769.namprd12.prod.outlook.com>
 <Y/z1Eu3DUaU/Dbfh@sirena.org.uk>
In-Reply-To: <Y/z1Eu3DUaU/Dbfh@sirena.org.uk>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mZ8Q71suiYeDsM/vSd7frHcy1QjVp+bu1l6L8YgdgcemAiXlv9+iGDvNeXdK?=
 =?us-ascii?Q?ppcx90J1fhMNHpIYC46TR5fyc9mzDbaJm9DOmRMX5aazYsJwmdpaQ9yYTGer?=
 =?us-ascii?Q?hxjZGN/EkAcppoPopNts+5nE/wwYvTQS34hU7fLnhROoPbkpKHAemIb7ggVz?=
 =?us-ascii?Q?iflg6k8JyC1MgWjGPFE+iOPMMnjj8Tg+nzhrYzLcMtYYOho/Iq+RaiAaBvKq?=
 =?us-ascii?Q?qUAPtaaBdkqiOvUE9CruBBYN+/Ka1gWmTR09D4SpWAUXqBQEzS5IqpTTwUu8?=
 =?us-ascii?Q?K91PixQHFD1kcKfnUDZaIc579X+utSh/A7tQ2SlZkoXTTA2cokahvehTOHuE?=
 =?us-ascii?Q?m3tNiqcA58KrRlaY4bFrFaNbSvbVh7J67BooMB/GdQwZ6JnQjADVokXdchsH?=
 =?us-ascii?Q?jjaaFYlOrwY8Z+oyEe1Cz7hV5JxcypVjh+HhgJXSeRoN5zggDh8fscz1wFQx?=
 =?us-ascii?Q?Q6w/ELBHDgw9+o94YCSGR06poPj569BMcLEOVbYOJabzLm+IKcGtQsrA+797?=
 =?us-ascii?Q?zyXGoTIbuZufuRVHJp+B8W8Cr6RHijButdG5dzKfGIETNffuVvq7iD7vZFaF?=
 =?us-ascii?Q?lqQvWv2FoTQMjbTWdx3iGSqh8xlMUwp1R3jmXC+0aRx+ww+0hEWLJyoywZ11?=
 =?us-ascii?Q?tbv5sLYihRb3ZPR1X1VdQjJs/ZJLxmrQmibWhwMCP5qzR+Zcml/VYlLdLCMd?=
 =?us-ascii?Q?J6umWqrA3lfAFYtAnqdYE+AcElsrxIOs+6+mNLES3emgFLgy+jGMou0QWDNY?=
 =?us-ascii?Q?b5XxSfYwRceU09IB0z1WEzL7hdWyKBlkjTRHbmH2t3HcrpTCakmb4HFvFJj1?=
 =?us-ascii?Q?1PpSR4r4E3vvAN0dhOQmpGj07NSzs1zzXRtIJJIokVWD3XjYB312kKpvejvw?=
 =?us-ascii?Q?gKYNzKwbmO7KZqU/MDA00bLYUZUryV0YlVI2n85ojWOWmWAMwVHQJjwng8I1?=
 =?us-ascii?Q?yYcYfvaa4zWFWLlhx2cjuNrNy4HA3PPM/aoC9l2YduYMwQMnsyn1gWTjtCvI?=
 =?us-ascii?Q?kRugPtD6DjHRktVacfciumbN5XGBXIkheMGWrl1v+qBA0zerXbU/m/eYIP+j?=
 =?us-ascii?Q?OorLgK6FJ1Twtx6ioshaqMlZHvMWxb7YBS9t1zI/lswokp2rckBnInZKLEb3?=
 =?us-ascii?Q?mp5QFHtYYNEcQs24QZoTXF3mqCOdacy4aj9KPw1isn29ssIyymntdARRnrp2?=
 =?us-ascii?Q?0zSxJDwG9NyOjMzDpDdjwQ0zFO/2AUyCAlfYCD9kL7SnfY7zqkz7Dr5Re0bx?=
 =?us-ascii?Q?knJ+iHWKwrB99fG73I6AMmgDvft6GJ/Vzgdr//NGC7pOEBJ6dMUdHZybSYNA?=
 =?us-ascii?Q?pNsF+nHjSCRjuE7G7Vgavd292R1JYo64ZaVrsyCPr1MTOUNEAtxxREzCewog?=
 =?us-ascii?Q?nefVai7PGF1lMyJi4jOzp5DN14FEDrr4LUNnEKp8NRFh2gukIo8L5Fu2uc0A?=
 =?us-ascii?Q?FYsItXgiCcNPByxSUU7G9zWRkxtUojxp2scBRF3MAK8CnUg2X5WPMZn7Zr51?=
 =?us-ascii?Q?PZatymzYKzXBYlCGi9z5FvcGalQ+Gff0rlOHVUAE2pxLPfl7SVsgYrm+npB1?=
 =?us-ascii?Q?Ec4TUyZo07+bQJQXTwHIaAe4Ec0bMSFcSv46C4tP?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5769.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfae91ad-1f5c-4bcc-b79c-08db18fafc53
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2023 19:44:05.6824
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rFwPt5AzNa0lcpWDKmoCTbqMqRGCubikSV0KREfU+Dfi8qvdjKy0nMSZxb12K8ZBegUy/9rGLTVmyc6VBEEzXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5753
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: 27 February 2023 23:53
> To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> Cc: linux-spi@vger.kernel.org; linux-tegra@vger.kernel.org; linux-
> kernel@vger.kernel.org; thierry.reding@gmail.com; Jonathan Hunter
> <jonathanh@nvidia.com>; Sowjanya Komatineni
> <skomatineni@nvidia.com>; Laxman Dewangan <ldewangan@nvidia.com>
> Subject: Re: [PATCH] spi: tegra210-quad: Fix iterator outside loop
>=20
> On Mon, Feb 27, 2023 at 10:36:18AM +0000, Krishna Yarlagadda wrote:
>=20
> > > > > > -	if (!xfer->cs_change) {
> > > > > > -		tegra_qspi_transfer_end(spi);
> > > > > > -		spi_transfer_delay_exec(xfer);
> > > > > > -	}
> > > updating the length of the message.
> > > > > This looks like it'll do the wrong thing and do a change on every
> > > > > transfer if cs_change isn't set?
>=20
> > > > This condition is hit only in data phase which is end of message.
>=20
> > > Shouldn't this just be moved into the DATA_TRANSFER case statement?
> > Calling transfer_end after updating message length.
>=20
> Something seems to be mangled with your quoting/new text here so it's a
> bit unclear what you're saying here but if you're saying that this is
> due to needing to call tegra_qspi_transfer_end() after updating the
> length I'm not sure why - AFAICT that function doesn't reference the
> transfer length at all, it just writes out a command to configure the
> chip select?  There's no issue with the message being finalised since
> that happens in the caller.
Yes. Length should not matter. Will move into DATA_TRANSFER case.
Also need to handle error case.