MIME-Version: 1.0
References: <20230225014529.2259752-1-davidgow@google.com>
In-Reply-To: <20230225014529.2259752-1-davidgow@google.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Mon, 27 Feb 2023 16:25:09 -0500
Message-ID: <CAFd5g46DFJayFnjJ4JGEUwvVDc-n=msHkMOR7SNd7Uverd6g+Q@mail.gmail.com>
Subject: Re: [PATCH] kunit: Fix 'hooks.o' build by recursing into kunit
To:     David Gow <davidgow@google.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        Rae Moar <rmoar@google.com>,
        Daniel Latypov <dlatypov@google.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 24, 2023 at 8:45 PM 'David Gow' via KUnit Development
<kunit-dev@googlegroups.com> wrote:
>
> KUnit's 'hooks.o' file need to be built-in whenever KUnit is enabled
> (even if CONFIG_KUNIT=m). We'd previously attemtped to do this by adding
> 'kunit/hooks.o' to obj-y in lib/Makefile, but this caused hooks.c to be
> rebuilt even when it was unchanged.
>
> Instead, always recurse into lib/kunit using obj-y when KUnit is
> enabled, and add the hooks there.
>
> Fixes: 7170b7ed6acb ("kunit: Add "hooks" to call into KUnit when it's built as a module").
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Link: https://lore.kernel.org/linux-kselftest/CAHk-=wiEf7irTKwPJ0jTMOF3CS-13UXmF6Fns3wuWpOZ_wGyZQ@mail.gmail.com/
> Signed-off-by: David Gow <davidgow@google.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>