Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50B24C64ED9 for ; Mon, 27 Feb 2023 22:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229864AbjB0WQv (ORCPT ); Mon, 27 Feb 2023 17:16:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjB0WQt (ORCPT ); Mon, 27 Feb 2023 17:16:49 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8677928207 for ; Mon, 27 Feb 2023 14:16:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2176160B71 for ; Mon, 27 Feb 2023 22:16:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED0EEC433EF; Mon, 27 Feb 2023 22:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1677536207; bh=lhIQQrDfUiCYIFpNMIqlj8bCtQYAOQ3RHcT3/exgPA4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=npNn47k9PO7Icc23/f3zW0pP7TnEVN/FznCtQCzLIjTlgBvPtNhLL7E/AdVX3QrzO /I1ardBp944AU4xMRN1ERTPIV+SdcFo+R9St9KgQXnoHyBCJaTRT6KV96m1JCBehPa STRI+C66fMpwKJAKGQTHvB59wTP+rmh6UGml5Nww= Date: Mon, 27 Feb 2023 14:16:46 -0800 From: Andrew Morton To: Marco Elver Cc: Alexander Potapenko , Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Liam Howlett , kasan-dev@googlegroups.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daniel Axtens , kernel test robot Subject: Re: [PATCH mm] kasan, powerpc: Don't rename memintrinsics if compiler adds prefixes Message-Id: <20230227141646.084c9a49fcae018852ca60f5@linux-foundation.org> In-Reply-To: <20230227094726.3833247-1-elver@google.com> References: <20230227094726.3833247-1-elver@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Feb 2023 10:47:27 +0100 Marco Elver wrote: > With appropriate compiler support [1], KASAN builds use __asan prefixed > meminstrinsics, and KASAN no longer overrides memcpy/memset/memmove. > > If compiler support is detected (CC_HAS_KASAN_MEMINTRINSIC_PREFIX), > define memintrinsics normally (do not prefix '__'). > > On powerpc, KASAN is the only user of __mem functions, which are used to > define instrumented memintrinsics. Alias the normal versions for KASAN > to use in its implementation. > > Link: https://lore.kernel.org/all/20230224085942.1791837-1-elver@google.com/ [1] > Link: https://lore.kernel.org/oe-kbuild-all/202302271348.U5lvmo0S-lkp@intel.com/ > Reported-by: kernel test robot > Signed-off-by: Marco Elver Seems this is a fix against "kasan: treat meminstrinsic as builtins in uninstrumented files", so I'll plan to fold this patch into that patch.