Date:   Mon, 27 Feb 2023 23:50:52 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     John David Anglin <dave.anglin@bell.net>
Cc:     linux-mm@kvack.org, linux-arch@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
        Helge Deller <deller@gmx.de>, linux-parisc@vger.kernel.org
Subject: Re: [PATCH v2 17/30] parisc: Implement the new page table range API
Message-ID: <Y/1B3BhgZp5aHry6@casper.infradead.org>
References: <20230227175741.71216-1-willy@infradead.org>
 <20230227175741.71216-18-willy@infradead.org>
 <d97b8a56-89cc-1eb4-1298-7b16079b3b46@bell.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d97b8a56-89cc-1eb4-1298-7b16079b3b46@bell.net>
Precedence: bulk

On Mon, Feb 27, 2023 at 05:49:18PM -0500, John David Anglin wrote:
> > @@ -104,13 +104,17 @@ __update_cache(pte_t pte)
> >   	if (!pfn_valid(pfn))
> >   		return;
> > -	page = pfn_to_page(pfn);
> > -	if (page_mapping_file(page) &&
> > -	    test_bit(PG_dcache_dirty, &page->flags)) {
> > -		flush_kernel_dcache_page_addr(pfn_va(pfn));
> > -		clear_bit(PG_dcache_dirty, &page->flags);
> > +	folio = page_folio(pfn_to_page(pfn));
> > +	pfn = folio_pfn(folio);
> > +	nr = folio_nr_pages(folio);
> > +	if (folio_flush_mapping(folio) &&
> Shouldn't this call be to folio_mapping()?

For pages in the swap cache, folio_mapping() will return the swap cache
mapping, which isn't what we want.  folio_file_mapping() will return the
swap file mapping, which is also not what we want.  folio_flush_mapping()
returns NULL, which is what we want.