Date:   Mon, 27 Feb 2023 18:25:41 -0700
From:   Keith Busch <kbusch@kernel.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Keith Busch <kbusch@meta.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH] dmapool: push new blocks in ascending order
Message-ID: <Y/1YFV49T/wJ6ndd@kbusch-mbp.dhcp.thefacebook.com>
References: <20230221165400.1595247-1-kbusch@meta.com>
 <20230225204239.21f1e1ab9c9523f803d9624c@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230225204239.21f1e1ab9c9523f803d9624c@linux-foundation.org>
Precedence: bulk

On Sat, Feb 25, 2023 at 08:42:39PM -0800, Andrew Morton wrote:
> On Tue, 21 Feb 2023 08:54:00 -0800 Keith Busch <kbusch@meta.com> wrote:
> 
> > Some users of the dmapool need their allocations to happen in ascending
> > order. The recent optimizations pushed the blocks in reverse order, so
> > restore the previous behavior by linking the next available block from
> > low-to-high.
> 
> As I understand it, this fixes the only known issues with patch series
> "dmapool enhancements", v4.  So we're good for a merge before 6.3-rc1,
> yes?

Okay, I think this is good to go to merge now. My local testing also show this
fixes the megaraid issue that Guenter reported on the other thread, so I
believe this does indeed fix the only reported issues with the dmapool
enhancements.
.