Feedback-ID: ic7094478:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-183-gbf7d00f500-fm-20230220.001-gbf7d00f5
Mime-Version: 1.0
Message-Id: <55fa16a3-068f-4b53-b1b3-831b7f013830@app.fastmail.com>
In-Reply-To: <Y/bV5D8gmG0B7DpN@1wt.eu>
References: <20230223010025.11092-1-v@vda.io>
 <b9df4ad5-0a4a-4061-a645-bda9fc42a874@t-8ch.de> <Y/bV5D8gmG0B7DpN@1wt.eu>
Date:   Mon, 27 Feb 2023 21:07:57 -0500
From:   "Vincent Dagonneau" <v@vda.io>
To:     "Willy Tarreau" <w@1wt.eu>,
        =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <thomas@t-8ch.de>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Feb 22, 2023, at 21:56, Willy Tarreau wrote:
> On Thu, Feb 23, 2023 at 01:53:06AM +0000, Thomas Wei=C3=9Fschuh wrote:
>> On Wed, Feb 22, 2023 at 08:00:21PM -0500, Vincent Dagonneau wrote:
>> > Hi,
>> >=20
>> > This is version 6 of the patch to add stdint.h to nolibc. Previous
>> > versions of this patch are available here:
>> >=20
>> > * v5: https://lore.kernel.org/all/20230220202010.37475-1-v@vda.io/
>> > * v4: https://lore.kernel.org/all/20230209024044.13127-1-v@vda.io/
>> > * v3: https://lore.kernel.org/all/20230206013248.471664-1-v@vda.io/
>> > * v2: https://lore.kernel.org/all/20230202201101.43160-1-v@vda.io/
>> > * v1: https://lore.kernel.org/all/20230202160236.25342-1-v@vda.io/
>> >=20
>> > This version integrates the feedback from Thomas, removing the limi=
ts
>> > for ssize_t (not required by the standard) as well as multiple cosm=
etic
>> >   issues.
>>=20
>> Thanks, for the whole series:
>>=20
>> Reviewed-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
>
> Thanks to you both! I'll take care of all this this week-end.
>
>> Note:
>>=20
>> When sending new revisions it makes sense to add reviewers and
>> commenters of the previous versions on Cc.
>>=20
>> It makes it easier for them and gives you a faster review or
>> Reviewed-by.
>
> Agreed. Overall I find that for his first patchset Vincent has
> done a great job ;-)
>

Thank you for your guidance on this patchset!

> Cheers,
> Willy