Feedback-ID: ic7094478:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-183-gbf7d00f500-fm-20230220.001-gbf7d00f5
Mime-Version: 1.0
Message-Id: <842ba2bf-ee1b-4d84-b78d-2fc251a1c8be@app.fastmail.com>
In-Reply-To: <b9df4ad5-0a4a-4061-a645-bda9fc42a874@t-8ch.de>
References: <20230223010025.11092-1-v@vda.io>
 <b9df4ad5-0a4a-4061-a645-bda9fc42a874@t-8ch.de>
Date:   Mon, 27 Feb 2023 21:08:25 -0500
From:   "Vincent Dagonneau" <v@vda.io>
To:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <thomas@t-8ch.de>
Cc:     linux-kernel@vger.kernel.org, "Willy Tarreau" <w@1wt.eu>
Subject: Re: [PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Wed, Feb 22, 2023, at 20:53, Thomas Wei=C3=9Fschuh wrote:
> On Wed, Feb 22, 2023 at 08:00:21PM -0500, Vincent Dagonneau wrote:
>> Hi,
>>=20
>> This is version 6 of the patch to add stdint.h to nolibc. Previous
>> versions of this patch are available here:
>>=20
>> * v5: https://lore.kernel.org/all/20230220202010.37475-1-v@vda.io/
>> * v4: https://lore.kernel.org/all/20230209024044.13127-1-v@vda.io/
>> * v3: https://lore.kernel.org/all/20230206013248.471664-1-v@vda.io/
>> * v2: https://lore.kernel.org/all/20230202201101.43160-1-v@vda.io/
>> * v1: https://lore.kernel.org/all/20230202160236.25342-1-v@vda.io/
>>=20
>> This version integrates the feedback from Thomas, removing the limits
>> for ssize_t (not required by the standard) as well as multiple cosmet=
ic
>>   issues.
>
> Thanks, for the whole series:
>
> Reviewed-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
>
> Note:
>
> When sending new revisions it makes sense to add reviewers and
> commenters of the previous versions on Cc.
>
> It makes it easier for them and gives you a faster review or
> Reviewed-by.
>

Noted. Thank you for the reviews!

>> Vincent.
>>=20
>> Vincent Dagonneau (4):
>>   tools/nolibc: Adding stdint.h
>>   tools/nolibc: Adding integer types and integer limit macros
>>   tools/nolibc: Enlarging column width of tests
>>   tools/nolibc: Adds tests for the integer limits in stdint.h
>>=20
>>  tools/include/nolibc/Makefile                |   4 +-
>>  tools/include/nolibc/std.h                   |  15 +-
>>  tools/include/nolibc/stdint.h                |  84 +++++++++++
>>  tools/testing/selftests/nolibc/nolibc-test.c | 139 ++++++++++++-----=
--
>>  4 files changed, 177 insertions(+), 65 deletions(-)
>>  create mode 100644 tools/include/nolibc/stdint.h
>>=20
>> --=20
>> 2.39.1
>>