Date:   Mon, 27 Feb 2023 18:33:49 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     davem@davemloft.net, ralf@linux-mips.org, edumazet@google.com,
        pabeni@redhat.com, linux-hams@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH net-next] net: rose: Remove NULL check before dev_{put,
 hold}
Message-ID: <20230227183349.68409721@kernel.org>
In-Reply-To: <20230228005217.105058-1-yang.lee@linux.alibaba.com>
References: <20230228005217.105058-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 28 Feb 2023 08:52:17 +0800 Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning=EF=BC=9A
>=20
> ./net/rose/rose_route.c:619:2-10: WARNING: NULL check before dev_{put, ho=
ld} functions is not needed.

# Form letter - net-next is closed

The merge window for v6.3 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after Mar 6th.

RFC patches sent for review only are obviously welcome at any time.