Date:   Tue, 28 Feb 2023 03:47:13 +0100
From:   Willy Tarreau <w@1wt.eu>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     Vincent Dagonneau <v@vda.io>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/4] tools/nolibc: add stdint.h
Message-ID: <Y/1rMdRIK1LyDrxl@1wt.eu>
References: <20230228021136.13472-1-v@vda.io>
 <20230228021136.13472-2-v@vda.io>
 <85e5fe90-4ff9-45f5-99d4-08ee737dfb51@t-8ch.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <85e5fe90-4ff9-45f5-99d4-08ee737dfb51@t-8ch.de>
Precedence: bulk

On Tue, Feb 28, 2023 at 02:24:15AM +0000, Thomas Wei?schuh wrote:
> On Mon, Feb 27, 2023 at 09:11:33PM -0500, Vincent Dagonneau wrote:
> > Nolibc works fine for small and limited program however most program
> > expect integer types to be defined in stdint.h rather than std.h.
> > 
> > This is a quick fix that moves the existing integer definitions in std.h
> > to stdint.h.
> > 
> > Signed-off-by: Vincent Dagonneau <v@vda.io>
> > Signed-off-by: Willy Tarreau <w@1wt.eu>
> > Reviewed-by: Thomas Wei?schuh <linux@weissschuh.net>
> 
> One more nitpick (applies to all patches):
> 
> The correct order of trailers would be:
> 
> Signed-off-by: Willy Tarreau <w@1wt.eu>
> Reviewed-by: Thomas Wei?schuh <linux@weissschuh.net>
> Signed-off-by: Vincent Dagonneau <v@vda.io>
> 
> In chronological order.
> 
> First Willy submitted something, then I reviewed it and then you
> submitted it.
> Your previous submissions/Signed-off-by are superseeded by the last one.
> 
> See Documentation/process/submitting-patches.rst.
> (Especially search for "chronological")
> 
> Willy can probably fix this up when applying the series, so a new
> revision may not be necessary.

Yeah absolutely. In fact I'll just drop my initial sob since I only
slightly re-adjusted some of Vincent's patches to illustrate what I
meant and not at all as something sensitive.

Thanks to you both!
Willy