Message-ID: <7ecb1d90-91c3-2f78-162a-1c1c4fa7e386@amd.com>
Date:   Tue, 28 Feb 2023 10:29:38 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH V2 2/3] sched/numa: Enhance vma scanning logic
Content-Language: en-US
From:   Raghavendra K T <raghavendra.kt@amd.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>, rppt@kernel.org,
        Bharata B Rao <bharata@amd.com>,
        Disha Talreja <dishaa.talreja@amd.com>
References: <cover.1675159422.git.raghavendra.kt@amd.com>
 <5f0872657ddb164aa047a2231f8dc1086fe6adf6.1675159422.git.raghavendra.kt@amd.com>
 <Y9zs5A/T1WQpJTuM@hirez.programming.kicks-ass.net>
 <048964e8-179f-de7b-1190-831779d9911f@amd.com>
In-Reply-To: <048964e8-179f-de7b-1190-831779d9911f@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1JXU2FCTjh6R0p2ZEUwNWlHMit4dG43TU1jV3liUVdDRDE5VjN4bmVaeUVU?=
 =?utf-8?B?N2FtS3JObm9ZZ1hZdE9kRkEyeEI2ZVpld3UvcmkvdDNjUUVXcldkNWpIR3ZO?=
 =?utf-8?B?eFZMRWFhOEFXaFU4S3gra1BndXFWdmEyR2x0bFVGc1dNaGxXL2lqTWZ0VjQz?=
 =?utf-8?B?TlNEUlNuaHE3ak90ZmJxL3VCNDBZcHg2ZDRaMVorQlIrcHV5MTRrY0RvZGVy?=
 =?utf-8?B?U25wYm8rNHI2bStrdFNYNzYzVkhYSkJzMmpKMmJZTnRlZHNIRm15bjhtY05h?=
 =?utf-8?B?alcxU1IrS1Q4V2U0dkphcGRTM011Zjk5aTh0WFI1aTZaaGdSMnJaOEw0MDNy?=
 =?utf-8?B?VEtWcUI2b2NIK3ZpQkUwZmN6UWlRajlTNi9yK25KN0pUQlhaZ2tzSjIyZlVK?=
 =?utf-8?B?SHUzbnU1Q1NSWlJyY29IazN3ZWN4RTB3ZXF2N2F5R0cvY0pCeXNtNUYvWFc5?=
 =?utf-8?B?TXAyTGpNZHk4NDVCQXhuUGcyRHlzMnNNQW1oYjZEOUhweTZEcFpyclFId3ZB?=
 =?utf-8?B?SFpTUXh0SU14allmKzNzR3I1MUFZZm1VS01YdERmVWhzd0xnS1YxMVYvZEMr?=
 =?utf-8?B?ZGxhd1BJdVJjbDhjNDIwVzZQMDBJQVpTdGU4c0FaZVB5NUlxRlZDT1BveXlp?=
 =?utf-8?B?eThzMXROdzJtcXhzdmhRdjZNaCtTS3NHVVhOMVI0NmpVMjdnNnhYeDU4aUJw?=
 =?utf-8?B?SmxPRFE3eDVpcFE4UWxIY2pXdnhNdVJVcnQ0M0RyaitrcHE3aXppeXNzOE1Y?=
 =?utf-8?B?cnF4TWxhQzVqazNlcXVXNUpVN3JHalVCUFlzMkU5T0c4aDcva25aZHcybkZ4?=
 =?utf-8?B?bnhnd3NEWE9DeS9ERXJxOEpmQ1ZSTTBoUDBFdFMxOUF2RnIxTW92emF3ajJn?=
 =?utf-8?B?MWpiQzlycjhMMEgyYWR4U0FleVQzMUhYcTdGWVZQeFlXZWN4d09zcWtVL1h4?=
 =?utf-8?B?dnp1bjlGWkE5VzM4SjJZWFlqMFRpZHFVanZXcEVQVHF0Qi9PSXZONkpUcmd0?=
 =?utf-8?B?d0tMUHdxMUF0Q0t6NVVhNVlYVFZMZlpYWDBsYm1OVlFvZkdOdDMwTDYrMDdx?=
 =?utf-8?B?SnBWejloN2RTbUdHZTRMS3d5Z3JBd21QTU5DVUVHL2V2VkZCaFhKaS8vRngx?=
 =?utf-8?B?NkNmWjlSdDk2MEpRM2JzaGtpWHBMbE4xNDJXNkMvaXRwanZlMVlKMTVpSEVH?=
 =?utf-8?B?RVlRQWgxbnNPMEh0dUxyalAzNEZqYzgrTmNlNFFTcHNsY0dmdVlVYTRNcWVh?=
 =?utf-8?B?Wk9ZSG1WMWlsRTY4R3dpU3pnRWw4a0hIOGxjcWt0UWEzWUZKRnYrbVZZNGsw?=
 =?utf-8?B?WjZKVHBjVCtZQ0t3WVFyVTFDVzN4L0ZlaFNKUUJHdjRPQ0wxUkw3OFdDMUNC?=
 =?utf-8?B?RWlhRXQ4dUxJUkltYll0eFE1TUZZY3c1OEhsSS9VMFJITkx1MEs4ZDI0Vlg1?=
 =?utf-8?B?a2gyeThYK0tpK1pTNDVsSzRjQnRwZFFMVkY1TVJoVUxWNGdEbHB2VnNpcEty?=
 =?utf-8?B?L2dDMDl1VndDUGw0TjluRFVkdUNORzQ5WFB6UytqRHNLN1g0OERqQ21mQlZV?=
 =?utf-8?B?SXBjd21rUDd0RkRSYjZIbnhLL1oybWFVSDNSWHhoSkZ0RytWaWtSZjcvMGVN?=
 =?utf-8?B?bGZJYm9CekkrQ3FFanpOK3NCOWZPeXBKSkpRR3BKYnovdHlpbVVoUy9iR2ZI?=
 =?utf-8?B?eTF4SnZqWFR5b2hjRGQwN2dBeDVQcDh5ck1oUm5wRzRUbEJCb2VST2VrWi9L?=
 =?utf-8?B?VDRCZ09BVVh4NUh0S2paNWlpWmo2VjBPUVZmQ0QwdmNHQUZURVErb0NUdXF1?=
 =?utf-8?B?SThlNDl0V1o2bUVNQytXZlg0bEk3czBLSU9vcDdzWlJnWUlhVzVOVCtXSlBY?=
 =?utf-8?B?M1F3OGIrbHFCU21GZ3ZzRmllQmN0NEExdExEQlJZYVlNc2hCenJrVzVnL0NQ?=
 =?utf-8?B?WUl2MGQrUjUzRCtVdG1qbUJRdHVqcjNNVjhENWpiUXhCeXp5VzJFQk9CTWRH?=
 =?utf-8?B?bUo2Q2dzQ3ZOaG5zODRqOVNYaGJqZE1WeDhVMFRrMjRHUURnNnRXWlcrTCtB?=
 =?utf-8?B?VnhqaGljQzEvNTZnSGdUMkRaMlhPZWt5WFgwSkRQK0lqZHE5U3V4TTlyemhp?=
 =?utf-8?Q?IEvWJv+/pWllafTqVdd4xwPrR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bd6dac3-82c7-4e0a-ab95-08db19489e9e
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3008.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 04:59:49.5720
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ifdZgtl0woT91W9CuRFm3C9MYgbfkR76zlXSbp17/LwHxbojI6G0GMTtR01kwri9qJIOEAuk+YqiL6nW0NhxNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5608
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/4/2023 11:44 PM, Raghavendra K T wrote:
> On 2/3/2023 4:45 PM, Peter Zijlstra wrote:
>> On Wed, Feb 01, 2023 at 01:32:21PM +0530, Raghavendra K T wrote:
[...]>>> diff --git a/mm/memory.c b/mm/memory.c
>>> index 8c8420934d60..2ec3045cb8b3 100644
>>> --- a/mm/memory.c
>>> +++ b/mm/memory.c
>>> @@ -4718,6 +4718,7 @@ static vm_fault_t do_numa_page(struct vm_fault 
>>> *vmf)
>>>       bool was_writable = pte_savedwrite(vmf->orig_pte);
>>>       int flags = 0;
>>> +    vma_set_active_pid_bit(vma);
>>>       /*
>>>        * The "pte" at this point cannot be used safely without
>>>        * validation through pte_unmap_same(). It's of NUMA type but
>>
>> Urghh... do_*numa_page() is two near identical functions.. is there
>> really no sane way to de-duplicate at least some of that?
>>
> 
> Agree. I will explore and will take that as a separate TODO.
> 

Did spend some time to look at if there is a better way of merging these
two.
code looks similar as you noted, with very subtle changes (pte vs pmd
and difference in unlock).
But I thought only some part of the code can be changed easily, but 
changing whole code did not look to be worth as of now.
(unless we come up with better idea)

This is the only comment perhaps not addressed rightly I feel :(

Thanks