Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B0CC7EE33 for ; Tue, 28 Feb 2023 06:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbjB1Ge2 (ORCPT ); Tue, 28 Feb 2023 01:34:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbjB1GeP (ORCPT ); Tue, 28 Feb 2023 01:34:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12F65BB; Mon, 27 Feb 2023 22:34:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A0CC3B80DED; Tue, 28 Feb 2023 06:34:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFEC7C433D2; Tue, 28 Feb 2023 06:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677566050; bh=Nc/tNHHbdZudxlnetoUB/Ahcg8UGlbT8CjlJknq5GZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SOQLaHlKIFhSg2REjjo7JokZ31rtl+qdIP25T9GE4WtL335pDCx+3dSn6aNcafSEM f6SBlJ8WU8PgpMRWnxgQhTUwOFy46puyoZvzH0HUTixO+WAEV+55itmCoKI2uxgTS4 qEgsXNZdEMFcZ37jIpMa/ARegBS8tpl9CBBnPUrK4uTR1TzMOmUSDgHwNnUGT+8eWv vegFlfxxDxEnUZuBgSwOgGE5eR/1CHe2fRMcpGATGptXYE+0eJjs0Tp4sxIUqBlOBX C+F4veJujCfKt3RXTOObOO33XWNh8Vdo5YD/IFEHHEd93UWwwjoIFqCWbXqwq1XHJQ OKARpaN8Sx0ww== Date: Tue, 28 Feb 2023 12:03:58 +0530 From: Manivannan Sadhasivam To: Devi Priya Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, kishon@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, svarbanov@mm-sol.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, quic_srichara@quicinc.com, quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com, quic_anusha@quicinc.com Subject: Re: [PATCH 1/7] dt-bindings: PCI: qcom: Add IPQ9574 specific compatible Message-ID: <20230228063358.GA4839@thinkpad> References: <20230214164135.17039-1-quic_devipriy@quicinc.com> <20230214164135.17039-2-quic_devipriy@quicinc.com> <20230224082332.GA5443@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2023 at 10:56:53AM +0530, Devi Priya wrote: > > > On 2/24/2023 1:53 PM, Manivannan Sadhasivam wrote: > > On Tue, Feb 14, 2023 at 10:11:29PM +0530, Devi Priya wrote: > > > Document the compatible for IPQ9574 > > > > Hi Mani, Thanks for taking time to review the patch. > > > > You didn't mention about the "msi-parent" property that is being added > > by this patch > Sure, will update the commit message in the next spin > > > > > Signed-off-by: Devi Priya > > > --- > > > .../devicetree/bindings/pci/qcom,pcie.yaml | 72 ++++++++++++++++++- > > > 1 file changed, 70 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > index 872817d6d2bd..dabdf2684e2d 100644 > > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > @@ -26,6 +26,7 @@ properties: > > > - qcom,pcie-ipq8064-v2 > > > - qcom,pcie-ipq8074 > > > - qcom,pcie-ipq8074-gen3 > > > + - qcom,pcie-ipq9574 > > > - qcom,pcie-msm8996 > > > - qcom,pcie-qcs404 > > > - qcom,pcie-sa8540p > > > @@ -44,11 +45,11 @@ properties: > > > reg: > > > minItems: 4 > > > - maxItems: 5 > > > + maxItems: 6 > > > reg-names: > > > minItems: 4 > > > - maxItems: 5 > > > + maxItems: 6 > > > interrupts: > > > minItems: 1 > > > @@ -105,6 +106,8 @@ properties: > > > items: > > > - const: pciephy > > > + msi-parent: true > > > + > > > power-domains: > > > maxItems: 1 > > > @@ -173,6 +176,27 @@ allOf: > > > - const: parf # Qualcomm specific registers > > > - const: config # PCIe configuration space > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - qcom,pcie-ipq9574 > > > + then: > > > + properties: > > > + reg: > > > + minItems: 5 > > > + maxItems: 6 > > > + reg-names: > > > + minItems: 5 > > > + items: > > > + - const: dbi # DesignWare PCIe registers > > > + - const: elbi # External local bus interface registers > > > + - const: atu # ATU address space > > > + - const: parf # Qualcomm specific registers > > > + - const: config # PCIe configuration space > > > + - const: aggr_noc #PCIe aggr_noc > > > > Why do you need this region unlike other SoCs? Is the driver making use of it? > We have the aggr_noc region in ipq9574 to achieve higher throughput & to > handle multiple PCIe instances. The driver uses it to rate adapt 1-lane PCIe > clocks. My bad, missed it. Will add the driver changes in V2. Hmm, this is something new. How can you achieve higher throughput with this region? Can you explain more on how it is used? Thanks, Mani > > > > Thanks, > > Mani > > > > > + > > > - if: > > > properties: > > > compatible: > > > @@ -365,6 +389,39 @@ allOf: > > > - const: ahb # AHB Reset > > > - const: axi_m_sticky # AXI Master Sticky reset > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - qcom,pcie-ipq9574 > > > + then: > > > + properties: > > > + clocks: > > > + minItems: 6 > > > + maxItems: 6 > > > + clock-names: > > > + items: > > > + - const: ahb # AHB clock > > > + - const: aux # Auxiliary clock > > > + - const: axi_m # AXI Master clock > > > + - const: axi_s # AXI Slave clock > > > + - const: axi_bridge # AXI bridge clock > > > + - const: rchng > > > + resets: > > > + minItems: 8 > > > + maxItems: 8 > > > + reset-names: > > > + items: > > > + - const: pipe # PIPE reset > > > + - const: sticky # Core Sticky reset > > > + - const: axi_s_sticky # AXI Slave Sticky reset > > > + - const: axi_s # AXI Slave reset > > > + - const: axi_m_sticky # AXI Master Sticky reset > > > + - const: axi_m # AXI Master reset > > > + - const: aux # AUX Reset > > > + - const: ahb # AHB Reset > > > + > > > - if: > > > properties: > > > compatible: > > > @@ -681,6 +738,16 @@ allOf: > > > - interconnects > > > - interconnect-names > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - qcom,pcie-ipq9574 > > > + then: > > > + required: > > > + - msi-parent > > > + > > > - if: > > > not: > > > properties: > > > @@ -693,6 +760,7 @@ allOf: > > > - qcom,pcie-ipq8064v2 > > > - qcom,pcie-ipq8074 > > > - qcom,pcie-ipq8074-gen3 > > > + - qcom,pcie-ipq9574 > > > - qcom,pcie-qcs404 > > > then: > > > required: > > > -- > > > 2.17.1 > > > > > > Thanks, > Devi Priya -- மணிவண்ணன் சதாசிவம்