MIME-Version: 1.0
References: <20230227105941.2749193-1-suagrfillet@gmail.com>
In-Reply-To: <20230227105941.2749193-1-suagrfillet@gmail.com>
From:   Alex Shi <seakeel@gmail.com>
Date:   Tue, 28 Feb 2023 15:11:44 +0800
Message-ID: <CAJy-AmnZmeTEwG9xTevhCzB2t9y0nb2yYsyWPMLn8R1V4XonQw@mail.gmail.com>
Subject: Re: [PATCH] sched/doc: supplement CPU capacity with RISC-V
To:     Song Shuai <suagrfillet@gmail.com>
Cc:     corbet@lwn.net, alexs@kernel.org, siyanteng@loongson.cn,
        robh@kernel.org, conor.dooley@microchip.com, palmer@rivosinc.com,
        leyfoon.tan@starfivetech.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Feb 27, 2023 at 6:59 PM Song Shuai <suagrfillet@gmail.com> wrote:
>
> This commit 7d2078310cbf ("dt-bindings: arm: move cpu-capacity to a
> shared loation") updates some references about capacity-dmips-mhz
> property in this document.
>
> The list of architectures using capacity-dmips-mhz omits RISC-V, so
> supplements it here.
>
> Signed-off-by: Song Shuai <suagrfillet@gmail.com>
> ---
>  Documentation/scheduler/sched-capacity.rst                    | 2 +-
>  Documentation/translations/zh_CN/scheduler/sched-capacity.rst | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-capacity.rst b/Documentation/s=
cheduler/sched-capacity.rst
> index 8e2b8538bc2b..e2c1cf743158 100644
> --- a/Documentation/scheduler/sched-capacity.rst
> +++ b/Documentation/scheduler/sched-capacity.rst
> @@ -258,7 +258,7 @@ Linux cannot currently figure out CPU capacity on its=
 own, this information thus
>  needs to be handed to it. Architectures must define arch_scale_cpu_capac=
ity()
>  for that purpose.
>
> -The arm and arm64 architectures directly map this to the arch_topology d=
river
> +The arm, arm64, and RISC-V architectures directly map this to the arch_t=
opology driver
>  CPU scaling data, which is derived from the capacity-dmips-mhz CPU bindi=
ng; see
>  Documentation/devicetree/bindings/cpu/cpu-capacity.txt.
>
> diff --git a/Documentation/translations/zh_CN/scheduler/sched-capacity.rs=
t b/Documentation/translations/zh_CN/scheduler/sched-capacity.rst
> index e07ffdd391d3..8cba135dcd1a 100644
> --- a/Documentation/translations/zh_CN/scheduler/sched-capacity.rst
> +++ b/Documentation/translations/zh_CN/scheduler/sched-capacity.rst
> @@ -231,7 +231,7 @@ CFS=E8=B0=83=E5=BA=A6=E7=B1=BB=E5=9F=BA=E4=BA=8E=E5=
=AE=9E=E4=BD=93=E8=B4=9F=E8=BD=BD=E8=B7=9F=E8=B8=AA=E6=9C=BA=E5=88=B6=EF=BC=
=88Per-Entity Load Tracking, PELT=EF=BC=89
>  =E5=BD=93=E5=89=8D=EF=BC=8CLinux=E6=97=A0=E6=B3=95=E5=87=AD=E8=87=AA=E8=
=BA=AB=E7=AE=97=E5=87=BACPU=E7=AE=97=E5=8A=9B=EF=BC=8C=E5=9B=A0=E6=AD=A4=E5=
=BF=85=E9=A1=BB=E8=A6=81=E6=9C=89=E6=8A=8A=E8=BF=99=E4=B8=AA=E4=BF=A1=E6=81=
=AF=E4=BC=A0=E9=80=92=E7=BB=99Linux=E7=9A=84=E6=96=B9=E5=BC=8F=E3=80=82=E6=
=AF=8F=E4=B8=AA=E6=9E=B6=E6=9E=84=E5=BF=85=E9=A1=BB=E4=B8=BA=E6=AD=A4
>  =E5=AE=9A=E4=B9=89arch_scale_cpu_capacity()=E5=87=BD=E6=95=B0=E3=80=82
>
> -arm=E5=92=8Carm64=E6=9E=B6=E6=9E=84=E7=9B=B4=E6=8E=A5=E6=8A=8A=E8=BF=99=
=E4=B8=AA=E4=BF=A1=E6=81=AF=E6=98=A0=E5=B0=84=E5=88=B0arch_topology=E9=A9=
=B1=E5=8A=A8=E7=9A=84CPU scaling=E6=95=B0=E6=8D=AE=E4=B8=AD=EF=BC=88=E8=AF=
=91=E6=B3=A8=EF=BC=9A=E5=8F=82=E8=80=83
> +arm=E3=80=81arm64=E5=92=8CRISC-V=E6=9E=B6=E6=9E=84=E7=9B=B4=E6=8E=A5=E6=
=8A=8A=E8=BF=99=E4=B8=AA=E4=BF=A1=E6=81=AF=E6=98=A0=E5=B0=84=E5=88=B0arch_t=
opology=E9=A9=B1=E5=8A=A8=E7=9A=84CPU scaling=E6=95=B0=E6=8D=AE=E4=B8=AD=EF=
=BC=88=E8=AF=91=E6=B3=A8=EF=BC=9A=E5=8F=82=E8=80=83
>  arch_topology.h=E7=9A=84percpu=E5=8F=98=E9=87=8Fcpu_scale=EF=BC=89=EF=BC=
=8C=E5=AE=83=E6=98=AF=E4=BB=8Ecapacity-dmips-mhz CPU binding=E4=B8=AD=E8=A1=
=8D=E7=94=9F=E8=AE=A1=E7=AE=97
>  =E5=87=BA=E6=9D=A5=E7=9A=84=E3=80=82=E5=8F=82=E8=A7=81Documentation/devi=
cetree/bindings/cpu/cpu-capacity.txt=E3=80=82

LGTM,
Reviewed-by: Alex Shi <alexs@kernel.org>

>
> --
> 2.20.1
>