From:   "Buvaneswaran, Sujai" <sujai.buvaneswaran@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
CC:     Lu Wei <luwei32@huawei.com>, Arnd Bergmann <arnd@arndb.de>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH] [v2] ethernet: ice: avoid gcc-9 integer
 overflow warning
Thread-Topic: [Intel-wired-lan] [PATCH] [v2] ethernet: ice: avoid gcc-9
 integer overflow warning
Thread-Index: AQHZQIi1laW7lWXNZE+8UlYydmfXPa7kEeRQ
Date:   Tue, 28 Feb 2023 07:53:05 +0000
Message-ID: <PH0PR11MB5013A61F5D22022026C09F0296AC9@PH0PR11MB5013.namprd11.prod.outlook.com>
References: <20230214152548.826703-1-arnd@kernel.org>
In-Reply-To: <20230214152548.826703-1-arnd@kernel.org>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Y7AlwuifURSmPq3Bm8wAcCFapbBn6cXQ3IroinuhYPhBSymHV0EzD5ZnYIEm?=
 =?us-ascii?Q?ghNX39ziNki55JByaimVQegjJCnHLmdrA3unt1JxiaC9yB7XyqIv+vYnw0Mz?=
 =?us-ascii?Q?O2GZD2D86okKFmbRqQyvixETxr7TbgZ2NOYJ/tYgL1dcNi3tq2oNd/DlQEE1?=
 =?us-ascii?Q?qgc5OlhUJpkr46y7Lm9oHedb5QosLf+orWYklL+Fi0XWvzfUNduwbDOy9QzB?=
 =?us-ascii?Q?3iz0ZGkrMGgFhYbQBYKgy9nPVA3R/Fdld+t4dV3X89jgllDu4IbKtAhP6Cn2?=
 =?us-ascii?Q?63dRma5WxTI8+Mxt/vi8BGg/t3ssh8FQArPZBVJ8Kw4Ef57PyAUH0HGdwZ0B?=
 =?us-ascii?Q?h/YA0Ra8SzhWDp7IXRz7xKt3GOEZTzr4tM7jDxV5/DxmfdqrSlQ2QZb5Nr8W?=
 =?us-ascii?Q?MGu7IsJjtZkwd5z+JOJIAgOomVprI+LtFnZqK2V5/ravmB0Ho3D+H4PHVDyl?=
 =?us-ascii?Q?rQfBBaoRv7x6HoUHdzn5rVpetoSPcV1V7hTv65bY/sJjPkVIryrw4dK8GGbT?=
 =?us-ascii?Q?sIPgIskVieUom/AQ9aXpfF6x0NcBIP25uff7/wnvdzso1yo5W4IjG+Q2+9Jw?=
 =?us-ascii?Q?+ETfj+N+eEB5/zaUHdSjhyvshN2iO0rsVplE+5n/Sl+GCV/6L45PvJ+LpMa+?=
 =?us-ascii?Q?2609PUFzzpM3Z9mFEvVfiY9t2L21dIh8cC6QF2TNdUIU+KZQ5ng0HtG5FstU?=
 =?us-ascii?Q?IZpXBSZbJBoBJe+fVgyIZXAMS8YRi6yGNWjjRX4KhHX6zuTOYyCH+ijphmp3?=
 =?us-ascii?Q?PK/tZ30H3xu7REgusjb5Md3Ds1wXHzTXJIMpe2xRsBFJosCQvlDymUS8vFrm?=
 =?us-ascii?Q?0cJtrlnQW0FaOvtwqkdwY1ecm22NooDqYKfzBFDvieocY2Eh0W849leO7Yld?=
 =?us-ascii?Q?7RPCxcvudY67F/9m8J8s5oHD3fxwrFOcpW8zUJE60YvgvS5d+5/39U3vRglr?=
 =?us-ascii?Q?npPIaHDze5cGfv3R3sFXgHUOa8pLr+Lrz5LQZorFF+2Lw6T8RPiu01pj3AEm?=
 =?us-ascii?Q?NZLJ1ZrhRLJRj5H2j4u+0D423OaP2Yu505iTWX1YOsHqutUO2zUEFJYSi1gy?=
 =?us-ascii?Q?lKmZHpvEnVatvcuYSKE99nJCmDmuAPNOoNpADmIOo8j1F80pLrn0ULz+Is4g?=
 =?us-ascii?Q?sRzOevjuT6q98gyH+Vkv/RuPPriEx1ZYWt4ovIA4PFLU3nDeVT46dVp0nVg3?=
 =?us-ascii?Q?8hWdKXUUPHN2xaGtbVgbwLaQR32AQyw5O9x0duwDHJKGxH8uSkrUXwQd3OKz?=
 =?us-ascii?Q?NlqMmFGnQ1EQL5+dlkyMq73lsm8Y1RzU1POJ1wkxjzharifNrh3FBHKbT+Ks?=
 =?us-ascii?Q?elUkkr8TZuAoIuwsY6ss1G7h6VnobpGy8hxWRQAlAht2MTB8E9GnpN7WXqM5?=
 =?us-ascii?Q?X07ytU8T7fUaWUm4nioFWTR1XMYsjPMRFPvqKUtw0j6pKeXRgngXWqCLpPpR?=
 =?us-ascii?Q?AjZf8XcYpvWsu3ZeuKiw1iKo6bgz8FO6qTH0f/g4h85eq3qjdsQT5dmdQWk6?=
 =?us-ascii?Q?CPpd20S/HUJRDcRp/Rconrtg5IxkdNp5qHiweI+bqk3GeHD11hGo3NsQ7U43?=
 =?us-ascii?Q?lWQEWGHLONKsXJYVXVaE209rUe8Fs26g/EGpzxRiVzPBbLWHrbMbIVHLqJeb?=
 =?us-ascii?Q?9g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6acac551-4c92-4f97-e310-08db1960d35c
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2023 07:53:05.6378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fAhymrR8Q1YTp21YaHSKhv185VURZI6oyVuB+I7CbPbuOz/rXZA0bDvJbwLKuQQ2F90pQvXn7lVnvmoh039hd4PRom9IfZcfWACPuU7/S7U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6076
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Arnd Bergmann
> Sent: Tuesday, February 14, 2023 8:56 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>;
> Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Martyna Szapar-Mudlaw
> <martyna.szapar-mudlaw@linux.intel.com>
> Cc: Lu Wei <luwei32@huawei.com>; Arnd Bergmann <arnd@arndb.de>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; intel-wired-
> lan@lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH] [v2] ethernet: ice: avoid gcc-9 intege=
r
> overflow warning
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> With older compilers like gcc-9, the calculation of the vlan priority fie=
ld
> causes a false-positive warning from the byteswap:
>=20
> In file included from drivers/net/ethernet/intel/ice/ice_tc_lib.c:4:
> drivers/net/ethernet/intel/ice/ice_tc_lib.c: In function 'ice_parse_cls_f=
lower':
> include/uapi/linux/swab.h:15:15: error: integer overflow in expression
> '(int)(short unsigned int)((int)match.key-><U67c8>.<U6698>.vlan_priority =
<<
> 13) & 57344 & 255' of type 'int' results in '0' [-Werror=3Doverflow]
>    15 |  (((__u16)(x) & (__u16)0x00ffU) << 8) |   \
>       |   ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
> include/uapi/linux/swab.h:106:2: note: in expansion of macro
> '___constant_swab16'
>   106 |  ___constant_swab16(x) :   \
>       |  ^~~~~~~~~~~~~~~~~~
> include/uapi/linux/byteorder/little_endian.h:42:43: note: in expansion of
> macro '__swab16'
>    42 | #define __cpu_to_be16(x) ((__force __be16)__swab16((x)))
>       |                                           ^~~~~~~~
> include/linux/byteorder/generic.h:96:21: note: in expansion of macro
> '__cpu_to_be16'
>    96 | #define cpu_to_be16 __cpu_to_be16
>       |                     ^~~~~~~~~~~~~
> drivers/net/ethernet/intel/ice/ice_tc_lib.c:1458:5: note: in expansion of
> macro 'cpu_to_be16'
>  1458 |     cpu_to_be16((match.key->vlan_priority <<
>       |     ^~~~~~~~~~~
>=20
> After a change to be16_encode_bits(), the code becomes more readable to
> both people and compilers, which avoids the warning.
>=20
> Fixes: 34800178b302 ("ice: Add support for VLAN priority filters in
> switchdev")
> Suggested-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: use be16_encode_bits() instead of a temporary variable.
> ---
>  drivers/net/ethernet/intel/ice/ice_tc_lib.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20

Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>