Date:   Tue, 28 Feb 2023 15:56:56 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     zhenggy <zhenggy@chinatelecom.cn>, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Fix rq nr_uninterruptible count
Message-ID: <Y/3B2CwI+RdoDt7T@debian.me>
References: <9b271641-ea59-daa5-333c-1dd1f02cdb52@chinatelecom.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="9UX63Gy/Zfo3mF4u"
Content-Disposition: inline
In-Reply-To: <9b271641-ea59-daa5-333c-1dd1f02cdb52@chinatelecom.cn>
Precedence: bulk


--9UX63Gy/Zfo3mF4u
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 28, 2023 at 03:08:58PM +0800, zhenggy wrote:
> When an uninterrptable task is queue to a differect cpu as where
> it is dequeued, the rq nr_uninterruptible will be incorrent, so
> fix it.

tl;dr (too much typos above). Would you like to "massage" the commit
mesage?

> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 25b582b..cd5ef6e 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -4068,6 +4068,7 @@ bool ttwu_state_match(struct task_struct *p, unsign=
ed int state, int *success)
>  {
>  	unsigned long flags;
>  	int cpu, success =3D 0;
> +	struct rq *src_rq, *dst_rq;
>=20
>  	preempt_disable();
>  	if (p =3D=3D current) {
> @@ -4205,6 +4206,16 @@ bool ttwu_state_match(struct task_struct *p, unsig=
ned int state, int *success)
>  			atomic_dec(&task_rq(p)->nr_iowait);
>  		}
>=20
> +		if (p->sched_contributes_to_load) {
> +			src_rq =3D cpu_rq(task_cpu(p));
> +			dst_rq =3D cpu_rq(cpu);
> +
> +			double_rq_lock(src_rq, dst_rq);
> +			src_rq->nr_uninterruptible--;
> +			dst_rq->nr_uninterruptible++;
> +			double_rq_unlock(src_rq, dst_rq);
> +		}
> +

Can you explain what the code above does to fix the problem you
mentioned above?

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--9UX63Gy/Zfo3mF4u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY/3B1AAKCRD2uYlJVVFO
o2/bAP9O5pBoA/zWyZz2ioyTzukHi0qSFgJ1vWZBauiezu4fCgEAyvQyh0QmAQZ1
Iy5tYopi0L1eMdT2BAg+QhmC1ccJEwo=
=tNCM
-----END PGP SIGNATURE-----

--9UX63Gy/Zfo3mF4u--