Feedback-ID: i58a146ae:Fastmail
Date:   Tue, 28 Feb 2023 20:47:43 +1100 (AEDT)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
cc:     Mike Rapoport <rppt@kernel.org>, Stephen Walsh <vk3heg@vk3heg.net>,
        John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: mm: Move initrd phys_to_virt handling after
 paging_init()
In-Reply-To: <CAMuHMdXMWaCm7OGq7O9F5SWBxhreTppUr4K6K9FmZf1GpaAtVA@mail.gmail.com>
Message-ID: <a0d5eec7-bb5c-b719-5aa0-ee1ecd11478f@linux-m68k.org>
References: <dff216da09ab7a60217c3fc2147e671ae07d636f.1677528627.git.geert@linux-m68k.org> <f0877485-16df-1bda-c935-5ef56afacc8d@linux-m68k.org> <CAMuHMdXMWaCm7OGq7O9F5SWBxhreTppUr4K6K9FmZf1GpaAtVA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 28 Feb 2023, Geert Uytterhoeven wrote:

> On Mon, Feb 27, 2023 at 11:46 PM Finn Thain <fthain@linux-m68k.org> wrote:
> > On Mon, 27 Feb 2023, Geert Uytterhoeven wrote:
> > > When booting with an initial ramdisk on platforms where physical memory
> > > does not start at address zero (e.g. on Amiga):
> > >
> > >     initrd: 0ef0602c - 0f800000
> > >     Zone ranges:
> > >       DMA      [mem 0x0000000008000000-0x000000f7ffffffff]
> > >       Normal   empty
> > >     Movable zone start for each node
> > >     Early memory node ranges
> > >       node   0: [mem 0x0000000008000000-0x000000000f7fffff]
> > >     Initmem setup node 0 [mem 0x0000000008000000-0x000000000f7fffff]
> > >     Unable to handle kernel access at virtual address (ptrval)
> > >     Oops: 00000000
> > >     Modules linked in:
> > >     PC: [<00201d3c>] memcmp+0x28/0x56
> > >
> > > As phys_to_virt() relies on m68k_memoffset and module_fixup(), it must
> > > not be called before paging_init().  Hence postpone the phys_to_virt
> > > handling for the initial ramdisk until after calling paging_init().
> >
> > Thanks for debugging this issue.
> 
> Np, you're welcome.
> 
> > > While at it, reduce #ifdef clutter by using IS_ENABLED() instead.
> > >
> > > Fixes: 376e3fdecb0dcae2 ("m68k: Enable memtest functionality")
> >
> > I apologise for the trouble caused by that patch.
> 
> Does that count as an Acked-by? ;-)
> 

Well, git log | grep suggested Mea-culpa-by and some others...

Acked-by: Finn Thain <fthain@linux-m68k.org>