MIME-Version: 1.0
References: <63fd57cb.620a0220.4e1b.8886@mx.google.com> <461f3a89-53d0-4a80-2d9b-0d3d648e1405@suse.de>
In-Reply-To: <461f3a89-53d0-4a80-2d9b-0d3d648e1405@suse.de>
From:   Luc Ma <onion0709@gmail.com>
Date:   Tue, 28 Feb 2023 17:48:27 +0800
Message-ID: <CAB3Z9RLCU1c1G_8Rus1f_37YvhHpuJgXQXainTxz+Q9qqTaOSw@mail.gmail.com>
Subject: Re: [PATCH v2] drm/vram-helper: fix function names in vram helper doc
To:     Thomas Zimmermann <tzimmermann@suse.de>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sam Ravnborg <sam@ravnborg.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 28 Feb 2023 at 16:11, Thomas Zimmermann <tzimmermann@suse.de> wrote=
:
>
> Hi
>
> Am 28.02.23 um 02:24 schrieb Luc Ma:
> > Refer to drmm_vram_helper_init() instead of the non-existent
> > drmm_vram_helper_alloc_mm().
> >
> > Fixes: a5f23a72355d ("drm/vram-helper: Managed vram helpers")
> > Signed-off-by: Luc Ma <luc@sietium.com>
>
> I didn't notice before: your sender email address has to match the
> signed-off-by address. I can fix that when I commit the patch. Which
> email address shall I use?

Hi, Thomas
please use Luc Ma <luc@sietium.com>, thank you

>
> Apart from that
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> Best regards
> Thomas
>
> > ---
> > v1 -> v2: improved commit message and add changelog
> >
> >   drivers/gpu/drm/drm_gem_vram_helper.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/dr=
m_gem_vram_helper.c
> > index d40b3edb52d0..f1539d4448c6 100644
> > --- a/drivers/gpu/drm/drm_gem_vram_helper.c
> > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c
> > @@ -45,7 +45,7 @@ static const struct drm_gem_object_funcs drm_gem_vram=
_object_funcs;
> >    * the frame's scanout buffer or the cursor image. If there's no more=
 space
> >    * left in VRAM, inactive GEM objects can be moved to system memory.
> >    *
> > - * To initialize the VRAM helper library call drmm_vram_helper_alloc_m=
m().
> > + * To initialize the VRAM helper library call drmm_vram_helper_init().
> >    * The function allocates and initializes an instance of &struct drm_=
vram_mm
> >    * in &struct drm_device.vram_mm . Use &DRM_GEM_VRAM_DRIVER to initia=
lize
> >    * &struct drm_driver and  &DRM_VRAM_MM_FILE_OPERATIONS to initialize
> > @@ -73,7 +73,7 @@ static const struct drm_gem_object_funcs drm_gem_vram=
_object_funcs;
> >    *          // setup device, vram base and size
> >    *          // ...
> >    *
> > - *           ret =3D drmm_vram_helper_alloc_mm(dev, vram_base, vram_si=
ze);
> > + *           ret =3D drmm_vram_helper_init(dev, vram_base, vram_size);
> >    *          if (ret)
> >    *                  return ret;
> >    *          return 0;
> > @@ -86,7 +86,7 @@ static const struct drm_gem_object_funcs drm_gem_vram=
_object_funcs;
> >    * to userspace.
> >    *
> >    * You don't have to clean up the instance of VRAM MM.
> > - * drmm_vram_helper_alloc_mm() is a managed interface that installs a
> > + * drmm_vram_helper_init() is a managed interface that installs a
> >    * clean-up handler to run during the DRM device's release.
> >    *
> >    * For drawing or scanout operations, rsp. buffer objects have to be =
pinned
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
> (HRB 36809, AG N=C3=BCrnberg)
> Gesch=C3=A4ftsf=C3=BChrer: Ivo Totev