Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F13C64EC7 for ; Tue, 28 Feb 2023 10:23:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230525AbjB1KXm (ORCPT ); Tue, 28 Feb 2023 05:23:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230483AbjB1KXl (ORCPT ); Tue, 28 Feb 2023 05:23:41 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C7131D925 for ; Tue, 28 Feb 2023 02:23:39 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id r18so9166287wrx.1 for ; Tue, 28 Feb 2023 02:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677579818; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2TyGBvzl5hbWKjdgHBG4sNlcppPeDqqtNrSWML8B16Q=; b=XCo5PJ71NbfmDFBsx0JLDSBKBp7e48VtxEpGakCuA5x4+M/TY4p0eLuwBID8zk1uXW Jn5yMvFPGV9IulBEt2/RtOZnu1U7eTER4nAdLGhAPyql/ZvNO1EtpufccA1z0unVpIN1 F4OPlvSpD9KwDzYuPZmfKb4QeRHygxOqzSqBBEdK+bfU1HTv7h5Kj/teYszLmVjTL8oH xejdo5/viVRdpoYnaqiKPUJeaZHSSm1QgUvRR78M/LV44NkmK21d60xtuPD4NhT+k+hM nKHfPuu81D+8zdFmChX0XdstkkORG2oEs5mL+8Kn8qFN3b8MtbGjxHD8jEax+5H4Z9K/ oexg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677579818; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2TyGBvzl5hbWKjdgHBG4sNlcppPeDqqtNrSWML8B16Q=; b=GL0YC1lPf55oTHlbv2XQ4ncl0ASrbXRDn2v77uZlkCxRAlDcEXsxCM5MkOg/fqsdC8 OQINvhVsJtQii9XhmQJeEx7h39auTyjcky1GArITbfs2nkBr4i/yXxsVrR+cmuA5ZpAc 2NAC5NdanczuLfBWTVb8sWUactwJX3kAenLGDmzTDq8TgcCcv38Jln3k8MhXcdcaXUCG v72jNfn/To/tX188xKOVIZ1oPS52U/3wgWtfl++R/15/nOACYKmWbV5kCO+IITgd+4uo bZmW7XhO0VSap52bM/dWjyzDd/YXJ4VvacUceTCO1KjwmKcvqg/X+KnjGCrBUWb4dZAY 5uvg== X-Gm-Message-State: AO0yUKVtmGCmbHAtFeQJo0KJffRbd6qDUG+qP9nA8akAM4DNNsDL0t8P 2YeHSdxb/0Vic6Wse51HnEBuEg== X-Google-Smtp-Source: AK7set/QvfEyPlbRIsm7TDv/QmKHj1bOOoAWeOijXNBKlPoL5ay0CfXWVkYOQGnTj6D5cKgty+pvVg== X-Received: by 2002:a5d:6802:0:b0:2c7:194a:15cf with SMTP id w2-20020a5d6802000000b002c7194a15cfmr1722945wru.22.1677579818025; Tue, 28 Feb 2023 02:23:38 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id s2-20020adff802000000b002c706c754fesm9463560wrp.32.2023.02.28.02.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 02:23:37 -0800 (PST) Message-ID: <2c8c3e57-16b4-43cc-941a-61f251bfe1f9@linaro.org> Date: Tue, 28 Feb 2023 11:23:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [Patch v5] dt-bindings: media: s5p-mfc: convert bindings to json-schema Content-Language: en-US To: Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com References: <20230227084736.89361-1-aakarsh.jain@samsung.com> <021c01d94aa0$03714d00$0a53e700$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <021c01d94aa0$03714d00$0a53e700$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/02/2023 12:38, Aakarsh Jain wrote: >>> + - samsung,mfc-v5 # Exynos4 >>> + - samsung,mfc-v6 # Exynos5 >>> + - items: >>> + - enum: >>> + - samsung,exynos3250-mfc # Exynos3250 >>> + - const: samsung,mfc-v7 # Fall back for Exynos3250 >>> + - enum: >>> + - samsung,mfc-v7 # Exynos5420 >>> + - samsung,mfc-v8 # Exynos5800 >>> + - samsung,exynos5433-mfc # Exynos5433 >>> + - samsung,mfc-v10 # Exynos7880 >> >> Why this and first enum are separate? I didn't notice it before... >> Usually we have only one enum for one-compatible variants. Also, sort them >> by compatible. >> > okay. > I will keep it in this way > properties: > compatible: > oneOf: > - const: samsung,mfc-v5 # Exynos4 > - const: samsung,mfc-v6 # Exynos5 > - const: samsung,mfc-v7 # Exynos5420 > - const: samsung,mfc-v8 # Exynos5800 > - const: samsung,exynos5433-mfc # Exynos5433 > - const: samsung,mfc-v10 # Exynos7880 These should still be an enum (and sorted by compatible). > - items: > - const: samsung,exynos3250-mfc # Exynos3250 > - const: samsung,mfc-v7 # Fall back for Exynos3250 > > Will this be fine? Best regards, Krzysztof