MIME-Version: 1.0
References: <20230228080619.412820-1-jindong.yue@nxp.com>
In-Reply-To: <20230228080619.412820-1-jindong.yue@nxp.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Tue, 28 Feb 2023 11:28:11 +0100
Message-ID: <CAPDyKFqR=Agf77bpgUvVKRw0V4p2-1c0bKYjjDCgr3VP3ij64w@mail.gmail.com>
Subject: Re: [PATCH 4/6] PM: domains: Export genpd_dev_pm_attach_by_name()
To:     Jindong Yue <jindong.yue@nxp.com>
Cc:     rafael@kernel.org, khilman@kernel.org, pavel@ucw.cz,
        len.brown@intel.com, gregkh@linuxfoundation.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, peng.fan@nxp.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 28 Feb 2023 at 08:59, Jindong Yue <jindong.yue@nxp.com> wrote:
>
> The genpd_dev_pm_attach_by_name() allows a device to be associated with
> its PM domain by name.
>
> Export it for use by kernel modules, such as the i.MX8M blk-ctrl drivers:
> imx8m-blk-ctrl and imx8mp-blk-ctrl.

The genpd_dev_pm_attach_by_*() are not intended to be used by any
consumer drivers at all. Instead, please use
dev_pm_domain_attach_by_*() instead.

>
> Signed-off-by: Jindong Yue <jindong.yue@nxp.com>
> ---
>  drivers/base/power/domain.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 32084e38b73d..6d66b6b14863 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2908,6 +2908,7 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev, const char *name)
>
>         return genpd_dev_pm_attach_by_id(dev, index);
>  }
> +EXPORT_SYMBOL_GPL(genpd_dev_pm_attach_by_name);
>
>  static const struct of_device_id idle_state_match[] = {
>         { .compatible = "domain-idle-state", },
> --
> 2.36.0
>

Kind regards
Uffe