Message-ID: <411ad4f0-2551-d0e7-77b6-04e71d35f6e4@intel.com>
Date:   Tue, 28 Feb 2023 11:53:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac grouping
 for ethtool statistics
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Vladimir Oltean <olteanv@gmail.com>,
        Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <woojung.huh@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <f.fainelli@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
References: <20230217110211.433505-1-rakesh.sankaranarayanan@microchip.com>
 <20230217110211.433505-4-rakesh.sankaranarayanan@microchip.com>
 <84835bee-a074-eb46-f1e4-03e53cd7f9ec@intel.com>
 <20230217164227.mw2cyp22bsnvuh6t@skbuf>
 <47a67799-27d9-094e-11c3-a18efcf281e2@intel.com>
 <20230224215349.umzw46xvzccjdndd@skbuf>
 <ca1f4970-206d-64f2-d210-e4e54b59d301@intel.com> <Y/zDmZDPnwvBqAST@lunn.ch>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <Y/zDmZDPnwvBqAST@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEtET3E1Z0xKdU1pRStvUU1qUzVLZlIyUVdpTGRVRFM2UWQyVjV3RWszTUIz?=
 =?utf-8?B?aHZVb3lUU0pvazIwVFI0dDgyd1EvU2JZd09yUk16QVRKRk03eEI5dk1UQUtt?=
 =?utf-8?B?M2xVdzJXd0tpc3QweW1LWGRuYjI2UXJYdWxCcDVMRWllL1NwYno4dTUzQklG?=
 =?utf-8?B?UVQ2cm12ZkhOTDFTK2dwUGd5Q0lCNkpyT0lKbFpKMzdVb0kxakt3aEV3bU1S?=
 =?utf-8?B?cW9RY3k4Y3BlakxXOVMyRzhQMnd6eldyYmdzSE0zeEtYMWpoVHB1dWo4Qmg0?=
 =?utf-8?B?eWZnWElKb1ZrRFh6aDFpL091dHFlSFArdWRhOEVQWXlxOGJZWGs0L3JmQnJK?=
 =?utf-8?B?MzJtemJnUUQycVpKTjhSQVZZQ0RnUzdQNFhXZmRJNUxnU0RLR0FDVU9WS1lp?=
 =?utf-8?B?REFybnFiUzZBYTN4TVd0TjZ1SGplY0dzUkp1Z3F5NnhHMjVXZHlvb0VuNXlO?=
 =?utf-8?B?bS9qR1JEQkh5NnlYY3hmTE4ydVFlZmRKUjZmQ1puWGRQamJrT2xIZUNXdG1T?=
 =?utf-8?B?OURZRFRpT3hjR09RWlI0bGFmdU8wQll2S0lrZzl0eTgzQitLdEY1UUZyNEQ3?=
 =?utf-8?B?NjBjM3FMQVB6dzJ0SlpucjhuVDhCRW40TXRYVFR6b0s3WFozdWxkcnhMdUJn?=
 =?utf-8?B?MG9lN1lWd0c4SzNQYmlBa2hCMUtaK29rZVlyK0NjR2Y3NFMwNzhGZzNrMlRz?=
 =?utf-8?B?VHE0TUQ5bGZiS2dZWkZxVHc2UGdPekJTb2FMcWdCbUVPYWxKb09KRTVCS3Jy?=
 =?utf-8?B?NHRZcHZqSG01aXBJRWhKeG9VK29XRXptNERIdzZGbXhuWVRyVEt6YXFsRmMz?=
 =?utf-8?B?dTM3K2E5ODZ0MkI1dmQ5MmRJZG0zTEJkamZMZUZzTjNqYlRjU1RXc1VxUTdx?=
 =?utf-8?B?TS9GNGFnSUpBaERyeHpuWU5ncDNwbG1vM3NhdU8ycm8rT254N1pROE1sdTIy?=
 =?utf-8?B?MmpXSmVveU1DZndMb3owb2NyRGhWRVgzVHlQZDRjOXZlQWplUTV3djM5Ym9C?=
 =?utf-8?B?WUo0eTRTdS9JOGpHRU5UK2E1VW42d2JuTGxPOVN3TnFDMWtGSHlYRDlBUlZ4?=
 =?utf-8?B?bEhqQXNXdDNTdHRIZWxqSUhEajBSUGtNSDgyZXQ5ejBYcGwzZGtRQWg3bzZB?=
 =?utf-8?B?TFEwdGxQcS9LL1V3ZStQdXFMOUpEMUFSdXhDN0prZ01WZ0twZXFrL1AySXVO?=
 =?utf-8?B?MjVMdjdlalZqcStLWUdkaW9mTU8zK3oybnVaV0RMdWQ4YlYyaWpwYWFac05j?=
 =?utf-8?B?VVJDcytkV3JWNFdmb3MzQTQzUTFGdmJqMVVRSWNwRWJMNE1tL0M5U084ekRt?=
 =?utf-8?B?OUJ2QlRWU290UW5iREZxUGZVb3JtQ3Y1RG5YbHF5ZmkySUk1MkZwSVhjUjRH?=
 =?utf-8?B?QjMrRWJVQ0lRdTl1SWxudnRjUDlSOVJObHVyOFNkS093MWJKVE9DNXY1bkd3?=
 =?utf-8?B?K2tUYWVRMGlvb1JDVU00SDZkYVk1aHJRWkFZT01scVVPcXhZZWZXZ016N0tS?=
 =?utf-8?B?a0RPYlJreUQ5ZG96ZHFmYzlHK0tMMmFqc1ltN3Y5cTkwSWhETUU3OFFCUWdQ?=
 =?utf-8?B?WU41VytpcytQa0VjTWdMUXBXYklLTWx0N1NzaGdidVc2QUg2eGpUWWxheHJC?=
 =?utf-8?B?WFgzME5NdEJMSjcrWERUSEVQQmZJb1d6aXJBUUhlSnNVcnN5N296UTdJTkdX?=
 =?utf-8?B?OGdudkdEWG1aQ0NaeGZ1QmZmZ3dFLzdXWUlZZ3Jlcm9XRGlOSWE1bGQ5RUoy?=
 =?utf-8?B?dWQ3SkNhQ29iZkc3b21DZjdwUGd2cWUvWmxRWnF1ZHNPQ0Zxbm45R3FBS1d0?=
 =?utf-8?B?V0FEWDJaeXJRRDRRUFE2WnhjWjJKTjJkV2NoZ01NVFV6dmsvOE1YNFpZZytm?=
 =?utf-8?B?aVRvL2luaXg0U0ZQamxoVkZ3NGZjYkFoclNlcG9UNnVWM1V1S0dFaElzSUZ2?=
 =?utf-8?B?TmFCS0RoRS9mS0ljM3lWMWJNZ1A0a25Ha1ZGZDAya3hjb25lZmtxTktFT0U3?=
 =?utf-8?B?NDMzbWZmM0N4c0Ixd0htZTRRb1k2anBoRm9wdXlDRDhBMGgyb3BwUnBqMUdG?=
 =?utf-8?B?TXRGeVUrQkVLb3JoZVdMb1c3R25seW1ZYmZaU2pVOFg2b1BxU01IdTFJRUlG?=
 =?utf-8?B?WEhOd3RzbHBOaFFsOWZISjFGOWRCa3gycmdMYmpnRDJ5UVdFK1RxWkJZMW13?=
 =?utf-8?Q?obOYzgQ+pdsL/LUEmH0YOOA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca184325-0702-4254-9ce9-08db197a358f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 10:54:48.1490
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k9U2D2JrahiZitBPDOzuO/9Fg8aPfZtlS2Wav3gobuqMubtDSPH3zugY55LOiUm/IYzqxZEKdHIZepq8rjOc/LYLFaRCGWWWmYYLDH8n0TU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5203
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 27 Feb 2023 15:52:09 +0100

>>> Easiest way to see a disassembly (also has C code interleaved) would be
>>> this:
>>>
>>> make drivers/net/dsa/microchip/ksz_ethtool.lst
>>
>> Oh, nice! I didn't know Kbuild has capability of listing the assembly
>> code built-in. I was adding it manually to Makefiles when needed >_<
>> Thanks! :D
> 
> You can also do
> 
> make drivers/net/dsa/microchip/ksz_ethtool.o
> make drivers/net/dsa/microchip/ksz_ethtool.S
> 
> etc to get any of the intermediary files from the build process.
> 
> Also
> 
> make drivers/net/dsa/microchip/

I was aware of this and .o, but didn't know about .lst and .S, hehe.
Yeah, this helps a lot. Sometimes I do

make W=1 <folder/file to recheck>

so that if a driver builds cleanly before my changes, it should do so
after them as well. `make W=1` for the whole kernel is still noisy
currently.

> 
> will build everything in that subdirectory and below. That can be much
> faster, especially when you have an allmodconf configuration and it
> needs to check 1000s of modules before getting around to building the
> one module you just changed. FYI: the trailing / is important.
> 
>        Andrew

Thanks,
Olek