Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F30C64EC7 for ; Tue, 28 Feb 2023 10:57:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231330AbjB1K5c (ORCPT ); Tue, 28 Feb 2023 05:57:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbjB1K5Q (ORCPT ); Tue, 28 Feb 2023 05:57:16 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECE9D305D8 for ; Tue, 28 Feb 2023 02:56:25 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id r18so9271244wrx.1 for ; Tue, 28 Feb 2023 02:56:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677581784; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1g1zgoQ8e1rCmD+8V4lGEZR3Cqpnsy/4iKzn5XmTAqQ=; b=qPtYuCnjYFvgN/MWdlB6HfRBPLMrs5RBj9IQwO3XK1T3AjSHxK+spWk7T5Px0cFxMN ZWO8cO2ychz4ST51hBTs+hR1sXLdKySOB+ONK29wSvgfpooZXSlAkpNnJDDtL3gaYVvX SEoD8eudJR0mIaRTchppYPlspfXGoifvkrLlCtozjhCZZPlBU9ETwhuysK5zoc3C0EkV BjkGTELeEoP4OFN56BsSiR01v7cKCXrDgl8wvMd3C6CJk+8xJjby+nNBjL8PX4PaxEgl rjkXAUYZoXy6FUBUnNtOhPg45jeAqyExnXZrRHAXSQHGU6I0CHgwu6VnzZlqEk1kVHq/ fVyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677581784; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1g1zgoQ8e1rCmD+8V4lGEZR3Cqpnsy/4iKzn5XmTAqQ=; b=nu/y9mJyrgR28diDFgcvnn2pqF8Lo2WQ8KAXAYOHtIDASw+yeWkfnxvuguWb/xYrIz 31OMBFr/WmmFQIB4pfG/KkweI6iMgvzReIB0zcV8CP1RfuouFkv7ermU5wkINJKw4u3u TJyOr/GpQqNeL9CkZKOp6XZ/uNT/sjhyfoDQIhidgCb9eESnHiyEFbhi8nHQy91p9Shg CY+eTyY5L/tNmzq94dWx6NdDLCiuOw4QZ/x9Hya4Ktf34rEOm6e27QrwCjPYq/EywDYc HPNjH3So2vSVv9hBv/EKeI/z51cJDyC2twTdyrR7YwnltJTzXQ8vMD8KoR1akI29jK5h TAZw== X-Gm-Message-State: AO0yUKWV7tuHpj8jTH3CdRnzSNUw5uzETHIckJBKcuLcESQauh8LgLEk ig8Koq5nXzZEB0aTGbZ6DelXow== X-Google-Smtp-Source: AK7set/gFPVojB1YHQtiFQzFwtOTIxwh5zVr8canwK3mSUBFXw89fvTyUYLRoiWrIidbpCXW6nM0Ow== X-Received: by 2002:a5d:598b:0:b0:2c5:67e3:808d with SMTP id n11-20020a5d598b000000b002c567e3808dmr8344224wri.35.1677581784294; Tue, 28 Feb 2023 02:56:24 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id s9-20020a5d4249000000b002c5598c14acsm9443185wrr.6.2023.02.28.02.56.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 02:56:23 -0800 (PST) Message-ID: <91879230-7f2d-c168-3808-d567b9e19e82@linaro.org> Date: Tue, 28 Feb 2023 11:56:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/2] dt-bindings:pinctrl:at91:Adding macros for sama7g5 Content-Language: en-US To: Ryan.Wanner@microchip.com, ludovic.desroches@microchip.com, linus.walleij@linaro.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <936fd3060662becd5485e32d5947286fcf0a3502.1677520830.git.Ryan.Wanner@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <936fd3060662becd5485e32d5947286fcf0a3502.1677520830.git.Ryan.Wanner@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/02/2023 19:07, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner > > Adding macros for sama7g drive strength. Look at output of the command I gave you. Now look at your subject... Missing spaces. BTW, it is "Add", not "Adding". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Signed-off-by: Ryan Wanner > --- > changes since v1: > - Fix ABI break. > - Add explanation for drive strength macros. > > changes since v2: > -Fix subject prefix to match subsystem. > -Add more in-depth discription of sama7g5 define values. > -Fix formatting issues. > > include/dt-bindings/pinctrl/at91.h | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h > index e8e117306b1b..a02bee76b1fb 100644 > --- a/include/dt-bindings/pinctrl/at91.h > +++ b/include/dt-bindings/pinctrl/at91.h > @@ -42,8 +42,21 @@ > #define AT91_PERIPH_C 3 > #define AT91_PERIPH_D 4 > > -#define ATMEL_PIO_DRVSTR_LO 1 > +/*These macros are for all other at91 pinctrl drivers*/ > +#define ATMEL_PIO_DRVSTR_LO 0 That's still ABI break, isn't it? Best regards, Krzysztof