Date:   Tue, 28 Feb 2023 19:35:57 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     James Clark <james.clark@arm.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/14] perf kvm: Add TUI mode for stat report
Message-ID: <Y/3nHZdMQEoadoLG@leoy-yangtze.lan>
References: <20230228084147.106167-1-leo.yan@linaro.org>
 <20230228084147.106167-14-leo.yan@linaro.org>
 <678c5939-f512-d4f8-e290-9c0f2bf05023@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <678c5939-f512-d4f8-e290-9c0f2bf05023@arm.com>
Precedence: bulk

Hi James,

On Tue, Feb 28, 2023 at 11:12:17AM +0000, James Clark wrote:

[...]

> > +static void print_result(struct perf_kvm_stat *kvm);
> > +
> > +#ifdef HAVE_SLANG_SUPPORT
> 
> Hi Leo,
> 
> I get an error because of this addition when building on x86. I think
> it's because I don't have HAVE_SLANG_SUPPORT. It might be the same error
> that you mentioned on v1?
> 
>    builtin-kvm.c:535:13: error: ‘print_result’ used but never defined
> [-Werror]
>    535 | static void print_result(struct perf_kvm_stat *kvm);

It's a bit weird for reporting this issue, since you could see I have
moved the function definition for print_result() ahead the macro
condition '#ifdef HAVE_SLANG_SUPPORT'.

But I found building failure with below command:

  $ make VF=1 DEBUG=1 NO_SLANG=1

Let me repin this patch for the building failures; sorry I have been
negligent.

> Other than that, for the whole set:
> 
> Reviewed-by: James Clark <james.clark@arm.com>

Thanks a lot for reviewing!  I will apply your tag in next spin
except patch 13.

Leo