Message-ID: <192d72313269845fe19d6d8baecbecfb9d184f77.camel@redhat.com>
Subject: Re: [PATCH v2] net: lan743x: LAN743X selects FIXED_PHY to resolve a
 link error
From:   Paolo Abeni <pabeni@redhat.com>
To:     Tom Rix <trix@redhat.com>, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, steen.hegelund@microchip.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 28 Feb 2023 12:50:17 +0100
In-Reply-To: <20230227130535.2828181-1-trix@redhat.com>
References: <20230227130535.2828181-1-trix@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Hello,

On Mon, 2023-02-27 at 08:05 -0500, Tom Rix wrote:
> A rand config causes this link error
> drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netde=
v_open':
> drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference t=
o `fixed_phy_register'
>=20
> lan743x_netdev_open is controlled by LAN743X
> fixed_phy_register is controlled by FIXED_PHY
>=20
> and the error happens when
> CONFIG_LAN743X=3Dy
> CONFIG_FIXED_PHY=3Dm
>=20
> So LAN743X should also select FIXED_PHY
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>

You are targeting the -net tree, but this lacks a 'Fixes' tag, please
post a new version with such info.

If instead the intended target was net-next (as I think it was agreed
on previous revision) please repost after that net-next re-opens (in
~1w from now).

Thanks,

Paolo