Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965867AbXIKWT1 (ORCPT ); Tue, 11 Sep 2007 18:19:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751534AbXIKWTT (ORCPT ); Tue, 11 Sep 2007 18:19:19 -0400 Received: from smtpq1.groni1.gr.home.nl ([213.51.130.200]:46075 "EHLO smtpq1.groni1.gr.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbXIKWTS (ORCPT ); Tue, 11 Sep 2007 18:19:18 -0400 Message-ID: <46E7145D.10907@gmail.com> Date: Wed, 12 Sep 2007 00:19:09 +0200 From: Rene Herman User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Adrian McMenamin CC: linux-kernel@vger.kernel.org, linuxsh-dev@lists.sourceforge.net, Paul Mundt Subject: Re: time_after - what on earth??? References: <8b67d60709111505u61771a1do74c82a55430ec214@mail.gmail.com> <46E7128D.1080006@gmail.com> <8b67d60709111515m5b45c57emef5cc2f74795ed7a@mail.gmail.com> In-Reply-To: <8b67d60709111515m5b45c57emef5cc2f74795ed7a@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-AtHome-MailScanner-Information: Please contact support@home.nl for more information X-AtHome-MailScanner: Found to be clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 30 On 09/12/2007 12:15 AM, Adrian McMenamin wrote: > On 11/09/2007, Rene Herman wrote: >> On 09/12/2007 12:05 AM, Adrian McMenamin wrote: >> >>> OK, why does this line occasionally return true: >>> >>> if ((maple_dev->interval > 0) && (jiffies >maple_dev->when)) >>> >>> while this one never does (no other changes made): >>> >>> if ((maple_dev->interval > 0) && (time_after(jiffies, maple_dev->when))) >> Is maple_dev->when an unsigned long? >> > Yes. Does that make a difference? If it had been a signed type, it could've wrapped to something you didn't expect, explaining the difference at least... With an unsigned long, the only diference should be that time_after() deals with jiffie wrapping which I assume is not an actual problem here. I'll retreat into the shades again... ;-( Rene. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/