Message-ID: <82013563-f652-2dc3-c90e-89b19fea6b1d@amd.com>
Date:   Tue, 28 Feb 2023 08:27:26 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 3/7] x86/resctrl: Add a new node-scoped resource to
 rdt_resources_all[]
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "x86@kernel.org" <x86@kernel.org>
Cc:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20230126184157.27626-1-tony.luck@intel.com>
 <20230126184157.27626-4-tony.luck@intel.com>
Content-Language: en-US
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <20230126184157.27626-4-tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VG9uc3YyYXZSRXJua2Z4b1paMHRPeDdVMmhkRCt4aEhHMnlQV0NFYm0vNHRM?=
 =?utf-8?B?VVJDbEg1TU80Y0JMM2YxUXNzWGxQSEo2ZmZtTnU2Snl0NnNsWXQ4T2VhcTAr?=
 =?utf-8?B?R0FPdUhxR3JneGw5UXVxZHV5dmRrV0w4aThES3A0bEZKQllPL0Z2OGcwY012?=
 =?utf-8?B?SEdEWjJvUTRBUmRQRERPcklUL2NZcHpJbzR4cmgvUzhUTFRYd1dubVo4OGg2?=
 =?utf-8?B?R1kveGRxS0JrTGZ6Z3NPVFZtTGFQYXhVc3NLR3k3Q2xqaFFhM2JqanZoYlJL?=
 =?utf-8?B?ZFo2cEZFRlBMdjhhMVJndjY3TC84ODZkK2JCQ2I1dHRENmRGSXd2MnJCUzNy?=
 =?utf-8?B?aWJKa2wvaXNLZ2liekJDVWN2M1NveDdzWEs2alNRVHkyT0tlSWZPY1Rudnc5?=
 =?utf-8?B?c0xuZThha2E3U0ludkpiSU5hSHZKbnA5TUdQZldGUGh4akVBOXdhZGRQdldJ?=
 =?utf-8?B?K1NhUlkxcEtHNThNV1RyYURqb25DbnFsaFdZMW1CRzM5QzZ0RmtDaG8wSXVn?=
 =?utf-8?B?NVorMUlxcmRWdHZVU3BldnAyQUpHUE93S2RCVENtQ0w1WWdvQ2NGR0grYXRD?=
 =?utf-8?B?Z0U0MGRWeDh0aTNNZllESjNHcDF4dExmVW9uV1FpWU9sYnNHQ2ZLSnZMVXB5?=
 =?utf-8?B?aWppVzV1WHFtdTlUUEpBTTZrMDRGRnJGMGhJR2o2QWt1VEV5UE1ranh0Mzcz?=
 =?utf-8?B?ZlZFY3VWSXIzdkN0MnpnQnFCQVlaS1VyeTFtdDlXYWJjTlJ6NmJOQVhkT2h3?=
 =?utf-8?B?eVA2SXlTVmU0Sy96NjdKMC9xZ0F1dEY1RE5WTENJV3AyZXFXR0VrYXdJTUVK?=
 =?utf-8?B?QTFpUHk4WklJNHdqWFVpS1RWa1hFQysrUUpMOW40b2lqVlNyMzA4blRlZ2xq?=
 =?utf-8?B?a0JWVWZ1QlBHU0k0MFd2STZ0VFpvcTF3WlVsVjQ1M01EZk9LYnRDVjhJVXlt?=
 =?utf-8?B?ZjVFeENmUmM5cjNveGpTR0NMazJ1TXJyclFoTThWbU1VaWh4b0paREI4N3hM?=
 =?utf-8?B?bHg2VW9uRTl2RmxueGtWOU5zQUd3MFNiTXBhOGk5SjZuL1cvVFFLSURsRFEx?=
 =?utf-8?B?M0FqYW9NdXE3d3U0SVBIcFBySWc0WUZ2SXcyV1pSbENPUnNRSFZ3cWNSR0Fx?=
 =?utf-8?B?emNmcVpvU2xvVU5wTFplUHpOZXVVeXl5VVN5QjdzNmszMjBhRlNvOWtvT2po?=
 =?utf-8?B?aktXa1FxUjhIN3RUWm44RTFNaHJCRlVTd0xnTHV3QVVuemQ5SnlheDBFN1B0?=
 =?utf-8?B?d3ppd0UyQUdQWDV5YjRsemdQZkhOSEpMYk5ySk96QkJ3K1RlakI1N093VFQ1?=
 =?utf-8?B?R3lLaXRDZHR5Y2NGRFVCeEZSYklKRGZsSU9teEIrNzF0WjIrV1dYTUp4WnJj?=
 =?utf-8?B?WTZreGlYTFErQXhjcWFCM2J5UGhuSjR3OFU1QkJwYXFPOFY3bmdBdFh4MjRm?=
 =?utf-8?B?MURkQytaWVBzVkUrb1pEbFdoQ1doRHROUnVIOFV1dWd3WDhkNXg5ZW10bzJp?=
 =?utf-8?B?L2xUTkxwVXIveVUyTFgxY3YyM1NQaERKdlg5SjF2Wk9wU0pHSEluMlB1cy9h?=
 =?utf-8?B?dnZ2WkFmcHlEUkJlUWREVURheHJBcEdUNWd5Y3NYVVRzZXpDUm9OZ0Y3TEMr?=
 =?utf-8?B?a3E2RkVIeEN1TVNJcVBPbStoWW1ud2ZvOHBpTHplajcvZVRGdFlzWnBVMWtJ?=
 =?utf-8?B?NUNCaUN6NmsvOHRjVS8xQm93cFFYOXZsNkgxSzU5SVAxMnlYelprK0t2bG1C?=
 =?utf-8?B?VGlVbDQrY2QwVkRudnV3WWZzTG40QXQwQ0YzQU1PbWZJWENocGVrSzQ4Lyt0?=
 =?utf-8?B?WklzV0dJUER3OHd0K2lNY2ZjUXl5THA2U3pxM3M2Z1A4MHVxdHViSUg2VWYy?=
 =?utf-8?B?WFFHcmVwUVg3N3NzUFl2NEFSYnlTMW1JOVlkcGp4WmNVOUNpSEh5RDZaTnNs?=
 =?utf-8?B?Z2FpWm15a0toamNJK25BeldLempaam9rbDVpTjBqMVdyZEpMM255OGlaa3RS?=
 =?utf-8?B?RFhTbzc0QTNseFo3OUQ0WDRNN1NKci9VTEpVcGFEanhoQWlrKzVCb3QvUHgz?=
 =?utf-8?B?alllTm50WnovdkZHQkkvTWRMKzVOSEJiK1FOcFRHc2twUkMrOUo5Y0QxTUNl?=
 =?utf-8?Q?4OCR2c9v/UQWSQnnMHwYFLsDb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b096dc56-8241-4875-ead5-08db1997ecc8
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 14:27:30.8278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vBlYFEh0VXjJQ7W7NFAmiZlNa/QasDOI79/otj+xEPNxpt81cDfJ4rLguM+xCAtn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4256
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tony,
Sorry for the late response. I was looking at your patches.

Do you really need a new resource [RDT_RESOURCE_NODE] to handle this 
feature?

As far as I can see, all that matters is writing/reading the MSRs 
IA32_PQR_ASSOC and IA32_QM_EVTSEL based on cpu index. I think that can 
be done without having the new resource. Let me know if I have 
misunderstood something.

Thanks
Babu


> -----Original Message-----
> From: Tony Luck <tony.luck@intel.com>
> Sent: Thursday, January 26, 2023 12:42 PM
> To: Fenghua Yu <fenghua.yu@intel.com>; Reinette Chatre
> <reinette.chatre@intel.com>; Peter Newman <peternewman@google.com>;
> Jonathan Corbet <corbet@lwn.net>; x86@kernel.org
> Cc: Shaopeng Tan <tan.shaopeng@fujitsu.com>; James Morse
> <james.morse@arm.com>; Jamie Iles <quic_jiles@quicinc.com>; Moger, Babu
> <Babu.Moger@amd.com>; linux-kernel@vger.kernel.org; linux-
> doc@vger.kernel.org; patches@lists.linux.dev; Tony Luck
> <tony.luck@intel.com>
> Subject: [PATCH 3/7] x86/resctrl: Add a new node-scoped resource to
> rdt_resources_all[]
> 
> Add a placeholder in the array of struct rdt_hw_resource to be used for event
> monitoring of systems with Sub-NUMA Cluster enabled.
> 
> Update get_domain_id() to handle SCOPE_NODE.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  arch/x86/kernel/cpu/resctrl/internal.h |  2 ++
>  arch/x86/kernel/cpu/resctrl/core.c     | 12 ++++++++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h
> b/arch/x86/kernel/cpu/resctrl/internal.h
> index 15cea517efaa..39a62babd60b 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -409,12 +409,14 @@ enum resctrl_res_level {
>  	RDT_RESOURCE_L3,
>  	RDT_RESOURCE_L2,
>  	RDT_RESOURCE_MBA,
> +	RDT_RESOURCE_NODE,
> 
>  	/* Must be the last */
>  	RDT_NUM_RESOURCES,
>  };
> 
>  enum resctrl_scope {
> +	SCOPE_NODE,
>  	SCOPE_L2_CACHE = 2,
>  	SCOPE_L3_CACHE = 3
>  };
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c
> b/arch/x86/kernel/cpu/resctrl/core.c
> index 6914232acf84..19be6fe42ef3 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -100,6 +100,16 @@ struct rdt_hw_resource rdt_resources_all[] = {
>  			.fflags			= RFTYPE_RES_MB,
>  		},
>  	},
> +	[RDT_RESOURCE_NODE] =
> +	{
> +		.r_resctrl = {
> +			.rid			= RDT_RESOURCE_NODE,
> +			.name			= "L3",
> +			.scope			= SCOPE_NODE,
> +			.domains		=
> domain_init(RDT_RESOURCE_NODE),
> +			.fflags			= RFTYPE_RES_MB,
> +		},
> +	},
>  };
> 
>  /*
> @@ -464,6 +474,8 @@ static int arch_domain_mbm_alloc(u32 num_rmid,
> struct rdt_hw_domain *hw_dom)
> 
>  static int get_domain_id(int cpu, enum resctrl_scope scope)  {
> +	if (scope == SCOPE_NODE)
> +		return cpu_to_node(cpu);
>  	return get_cpu_cacheinfo_id(cpu, scope);  }
> 
> --
> 2.39.1