From:   Ken Sloat <ken.s@variscite.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Michael Hennerich <michael.hennerich@analog.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ken Sloat <ken.s@variscite.com>
Subject: RE: [PATCH v1] net: phy: adin: Add flags to disable enhanced link
 detection
Thread-Topic: [PATCH v1] net: phy: adin: Add flags to disable enhanced link
 detection
Thread-Index: AQHZS4L7Pv2IgKC+70qPmaRcnFBcv67kcbqAgAAD6KCAAANXgIAAAYeA
Date:   Tue, 28 Feb 2023 15:28:43 +0000
Message-ID: <DU0PR08MB9003DF34A62F764A90F70FE5ECAC9@DU0PR08MB9003.eurprd08.prod.outlook.com>
References: <20230228144056.2246114-1-ken.s@variscite.com>
 <Y/4VV6MwM9xA/3KD@lunn.ch>
 <DU0PR08MB900305C9B7DD4460ED29F5FBECAC9@DU0PR08MB9003.eurprd08.prod.outlook.com>
 <Y/4ba4s37NayCIwW@lunn.ch>
In-Reply-To: <Y/4ba4s37NayCIwW@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VLfFdDZnOLg9zZkeVWZ7k+PS+nuI/5ZrMn69H9lrdoAQqja2ZWxOuc2wF6ab?=
 =?us-ascii?Q?k+PosvgJcI9S/ju6SWzfMz4wsrtTiPU0dKsopwRB90VOaASnEtZv8NcHAe9j?=
 =?us-ascii?Q?UWkVQWIAg/XepfQ2i2Lhm+m8hkxC3C4mcVuXvN/33WR0GGWe0+r8bWge9d0E?=
 =?us-ascii?Q?XsCu2dFUs8Uf5A2RyR8+ANQOxefYZe/EklNvz7i4eleOW1ou8FtqYsvbBfjN?=
 =?us-ascii?Q?+0NkmyZvVCqoB+p/UYqS8x2cJ2KTBuHBDapeS6gCU47vlV2OjmfMAptV9LGQ?=
 =?us-ascii?Q?OxQLCQladYm92caLGE5CFuuJ8fuE7u+4E4Zc6VyPxkJdoJuUvqe71ujupiO6?=
 =?us-ascii?Q?KS+X+aP7U1VvIHXRadbuzcUaylJoeVzrgSojhPckakDP0WwrA8w4rYxpUP97?=
 =?us-ascii?Q?MTnRm5PeNJQvW+lqMQCLznAAhM91AcmHaiPLY02WexHkC7GS0/9vx3ah/QZ3?=
 =?us-ascii?Q?rZTo6fc6FeJyYxApvcfVu6PVdNq77yAr8YDLvW1s69wTJ4/fSeWEH25J3lon?=
 =?us-ascii?Q?BenCAfs3R11/8yxxtzYKy6+Do5NnJkaICUhFx22L5i9gvIW63CqxM9xZZtg7?=
 =?us-ascii?Q?6PsEbQQ3tSSOht1LosB+0WfMfT2wgVmvXLDxP6DOMuf9RT+fL76njN+Z/4KF?=
 =?us-ascii?Q?92cFuy/PT4qtSc+L861Ts0f7U/lX18TVymDCKd8LYipIE4yXDgzSgIO/VUmD?=
 =?us-ascii?Q?dtqQFTpGb8H66mCKz0KOfT0ygZsuZDpAdyJ/sSGV/DlPS717t+gYAfecrdr8?=
 =?us-ascii?Q?wWCS+y0O5gB0wtE/s66w8qYufJdR6mUsJfBeEy4UcMjPX9tvjwNttD+JIv01?=
 =?us-ascii?Q?84UprVr5mI1TQM6S3chYxRYDrBLhiv0jJLP8aCrMe3SuVpgNqORffIrlIGi6?=
 =?us-ascii?Q?a85xt8n3bdoltv2mTgo5JaPgB2MiTWkyF2st8PC+KylXMtezToOmAPhYJLhX?=
 =?us-ascii?Q?NNaBjk60jSPCJ03AUpJvSfZzOFDhfN28uq2YR4+hSQr+TNlNp8N8nLBfDr0A?=
 =?us-ascii?Q?B4saWT+JGHlWDi6EMZufzH8crp40X7c1lt25FHmWNOiXWYMbgODMZbG4l65b?=
 =?us-ascii?Q?YI+Rp9NrIkfPuEvMVLKjHfZtCSMPbJHeqMx0ZP8iN4OUDEy7nAZ+mZDbSHCu?=
 =?us-ascii?Q?7RFUr20kaBeH3Pi5BCtSnvu2tFOK/a5jWJ0oDxL1iEQt6Q8v2ro2qoR9aNyW?=
 =?us-ascii?Q?XE45jTGfi0N5FXIY3hT5ZgNaZ4+vZBUQ5FFJmzz5AQJTkIDffSdtz8XMXcna?=
 =?us-ascii?Q?OobAxE9blBSErL9UF/kqakbIixHv8xbtTI0D2wDE5OmoQ719lI2wjEg/FTuD?=
 =?us-ascii?Q?Eaps2JR1OjZdOoLz+DhP85wSqg05OMr8bdEeagQN2ZFM9Q/+M+eTe1A0u0h8?=
 =?us-ascii?Q?bc69dKzRF408ObOIBUoxA68eDjefTpSRNdz6W4Ls8Ef+w19nH7VSvX/5RqW1?=
 =?us-ascii?Q?8qexVLvsDwG0V7zWalDCoa+xoCWPmguYodTXpDZzjTscmELcbeUjW2Jgk/tW?=
 =?us-ascii?Q?gWejeMAAYC8l8lfxL7aIcIWUgehSB6DusTX7DZJ8wUtO/ap7YnyLFve81MdB?=
 =?us-ascii?Q?tCBWMuZM6PenzvNVyi3pDLGtCIXQlWNfEibpnqEP?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: variscite.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9003.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48a07229-e271-4dd9-98b0-08db19a079d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2023 15:28:43.2353
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 399ae6ac-38f4-4ef0-94a8-440b0ad581de
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cOWoBep7EMF4VeuvEHTPrmI2krI6govk4kijdlQea1A0AsRh9tVdiIgyN97KqJd+31PXuEXnzDObsewos4faTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5838
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks Andrew!

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, February 28, 2023 10:19 AM
> To: Ken Sloat <ken.s@variscite.com>
> Cc: Michael Hennerich <michael.hennerich@analog.com>; Heiner Kallweit
> <hkallweit1@gmail.com>; Russell King <linux@armlinux.org.uk>; David S.
> Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1] net: phy: adin: Add flags to disable enhanced lin=
k
> detection
>=20
> On Tue, Feb 28, 2023 at 03:13:59PM +0000, Ken Sloat wrote:
> > Hi Andrew,
> >
> > Thanks for your quick reply!
> >
> > > -----Original Message-----
> > > From: Andrew Lunn <andrew@lunn.ch>
> > > Sent: Tuesday, February 28, 2023 9:53 AM
> > > To: Ken Sloat <ken.s@variscite.com>
> > > Cc: Michael Hennerich <michael.hennerich@analog.com>; Heiner
> > > Kallweit <hkallweit1@gmail.com>; Russell King <linux@armlinux.org.uk>=
;
> David S.
> > > Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
> > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> > > Subject: Re: [PATCH v1] net: phy: adin: Add flags to disable
> > > enhanced link detection
> > >
> > > On Tue, Feb 28, 2023 at 09:40:56AM -0500, Ken Sloat wrote:
> > > > Enhanced link detection is an ADI PHY feature that allows for
> > > > earlier detection of link down if certain signal conditions are
> > > > met. This feature is for the most part enabled by default on the
> > > > PHY. This is not suitable for all applications and breaks the IEEE
> > > > standard as explained in the ADI datasheet.
> > > >
> > > > To fix this, add override flags to disable enhanced link detection
> > > > for 1000BASE-T and 100BASE-TX respectively by clearing any related
> > > > feature enable bits.
> > > >
> > > > This new feature was tested on an ADIN1300 but according to the
> > > > datasheet applies equally for 100BASE-TX on the ADIN1200.
> > > >
> > > > Signed-off-by: Ken Sloat <ken.s@variscite.com>
> > > Hi Ken
> > >
> > > > +static int adin_config_fld_en(struct phy_device *phydev)
> > >
> > > Could we have a better name please. I guess it means Fast Link Down,
> > > but the commit messages talks about Enhanced link detection. This
> > > function is also not enabling fast link down, but disabling it, so _e=
n seems
> wrong.
> > >
> > "Enhanced Link Detection" is the ADI term, but the associated register =
for
> controlling this feature is called "FLD_EN." I considered "ELD" as that m=
akes
> more sense language wise but it did not match the datasheet and did not
> want to invent a new term. I was not sure what the F was but perhaps you
> are right, as the link is brought down as part of this feature when condi=
tions
> are met. I am guessing then that this FLD is a carryover from some initia=
l
> name of the feature that was later re-branded.
> >
> > I am happy to change fld -> eld or something else that might make more
> sense for users and am open to any suggestions.
>=20
> The Marvell PHYs also support a fast link down mode, so i think using fas=
t link
> down everywhere, in the code and the commit message would be good.
> How about adin_fast_down_disable().
>=20
I am good with that. I'll probably also make mention in the comment along w=
ith that ADI's term for thoroughness.

What about for the bindings, how is something like "adi,disable-fast-down-1=
000base-t?"

> > > You need to document these two properties in the device tree binding.
> > >
> >
> > I already have a separate patch for this. I will send both patches
> > when I re-submit and CC additional parties.
>=20
> It is normal to submit them together as a patch set. What generally happe=
ns
> is that the DT maintainers ACK the documentation patch, and then it gets
> merged via the netdev tree.
>=20
Good to know thanks!

>    Andrew

Sincerely,
Ken Sloat