Date:   Tue, 28 Feb 2023 21:25:14 +0530
From:   Wyes Karny <wyes.karny@amd.com>
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc:     Stephane Eranian <eranian@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, hpa@zytor.com,
        x86@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, gautham.shenoy@amd.com,
        ananth.narayan@amd.com,
        "kernel@collabora.com" <kernel@collabora.com>
Subject: Re: [PATCH] perf/x86/rapl: Enable Core RAPL for AMD
Message-ID: <Y/4j4q97NAKM6YfX@bhagirati.amd.com>
References: <20230217161354.129442-1-wyes.karny@amd.com>
 <Y/NdUjLiQu+D0q7b@hirez.programming.kicks-ass.net>
 <CABPqkBTU_gnTr9ayvg220T4pO5NAguvu_UJAkZO2RUATWuMJ3A@mail.gmail.com>
 <Y/ROTsCSCFtrwwTK@beas>
 <CABPqkBQ_bSTC-OEe_LrgUrpj2VsseX1ThvO-yLcEtF8vb4+AAw@mail.gmail.com>
 <803f7ef2-f217-65fe-d0b9-98ae469556fa@collabora.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <803f7ef2-f217-65fe-d0b9-98ae469556fa@collabora.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2VRRm5XTmUvRWNabFRzanJyQzM0dmVxVlpXdFRraVJNL0w3VVEveEhRcFpU?=
 =?utf-8?B?cWhYZlMyTy9WMW9XUGp3SkxFcmtzZGdlcXhOaEozSTdRa3hPOGFRY0NoM3Nu?=
 =?utf-8?B?ME1SbUtpL09uTEVPcTg1VW04c1dFZllVdUZMTHFxRlp0SUk1Ym5oZVYyRXlJ?=
 =?utf-8?B?TnBLd2lqWW1DbzV1b2xvWUlNR3hDTjJ4Q2YyTENsSC80OHdkeGNzci92REFL?=
 =?utf-8?B?WGdaUlJrT2JaUklpallEWjhPRDBiVy8yb1FGdXYya3ZZV2pyaEE4QkZWcWZK?=
 =?utf-8?B?QkE3bEhiS05oeEdnOVJHNjJSMVNwQzNoRzhKVThuSGErUytRYkhhMS8zTXIz?=
 =?utf-8?B?STEzbWU2MnFteWdLOTNNbHhCV2dsbWVHVnY4WUl0WTBJcmMrQlhvM1RjazNa?=
 =?utf-8?B?NFBZR1N2bXg3SUVHdlhiRG93cDQwOW5WVzBxbVJkcTdvWnJCZzZhMHB6SWF6?=
 =?utf-8?B?ZmVuTElhYnU1T29RNjFxU0NKV0dJbXVUR2VrVHJrQTE1a3JTRVMrUk1oaE9h?=
 =?utf-8?B?TS90a0pXMTdacTUySlMwMUt5TTQzU3VvZjAzNFp0YytidXJyc2V2SGh4NUJX?=
 =?utf-8?B?QnU0S29Cc0RNdzZWUzlBZ2JGazdldFVKZkNvZ3ZPTDVoSjFQbE1BN2JDTGZR?=
 =?utf-8?B?eXEwN3RGbXF1VTg2YVFZWjd3SndWdHpYeE1Na21JcjhWaG1oMHcvUHd5NC8x?=
 =?utf-8?B?aTV4MlJEaGsyYzNkQmJ6TWJpaE1SUmUwbHl4VnNRV21odnFmb1N0ZUdGVnY0?=
 =?utf-8?B?a3crTXo5UWMyck9VQ0o0dFNNSVpQQ3RKdG1UYjlCOGtPNlJYTFNCUDZuZ2s4?=
 =?utf-8?B?ejh3YzN1VVg5WExMb2lmd0QzUlVGTzNNYXJQT21Jb2I0NGo0cmJpQnN5UHhi?=
 =?utf-8?B?ejE2eEJiS0xuMkhNQ0ZzTTFLMDRvMTI5MGQ3eE16RHNzVHUveStXWlN6b0di?=
 =?utf-8?B?by9PQ3pBb25zOHoyTWcwdzZXanAxbWVWOG9RdWlZd2R0UVpONlMzYXBHcUEz?=
 =?utf-8?B?K0U5elhZS3RyOXR3a1BTRmMzSnRmeWJpbmxMdmxXZkQvN3pLdGxGbE8vTHkz?=
 =?utf-8?B?aUdELzZHN0haeitKNmh0c2V6TUVUeURQQWZ0bm15NVdrWk9DbE1Kd0lpT3My?=
 =?utf-8?B?RDkrUXJjN05vcmI5bklqdzc3Q0N6dWRZMTI0eTRiL0pLTnBmQjNsTHhhY2dx?=
 =?utf-8?B?YWxqdnVWMlI5bFV6YmNpL2dJbFVVTDEvSTh6SCtROVEwQWlWSTVhaDROZkxF?=
 =?utf-8?B?aEFCR1VxaTd5aFpvTGVyQ1YyUDdOeHlPUkN2YWI3R3VjdUZwd3FVQ1FRdENS?=
 =?utf-8?B?d20vdnlTcDNLMkswK1ZKZkhweTBzWEt4dFdpRWRPT3owNisydktsTDVhOTl5?=
 =?utf-8?B?UWZXNUo0c0g1NVZ4MC9nTWhvbnErVStPOFhxRllOZzdkSno1YW9UY2ozTFhr?=
 =?utf-8?B?YmxvUENQNURnNy9hQ2V6MTFTeldUUWF3aXBmenUzQlNMbG5MMXlkOGtQeERP?=
 =?utf-8?B?enNmMmgvR2dzTUN6dWZEdkxubnQrVUhrY0l1UkxOZVBSeUxoUTJJbjVVb2Yv?=
 =?utf-8?B?R1YvcGJmUU5LcmFlMzEvbndkUGs1eHk0Z2NaTnlTLzh1eklTanB0VWlmZVp1?=
 =?utf-8?B?SkxNallrV2p5UXZXNGhRNHpuN1hoZGJOR1l5WmhEcjd5eVpmQTRKR0g0N0dw?=
 =?utf-8?B?NlFYZm5rSFRtNDZvTnZxRXhiMkpObEhSblR4SUI0ZGQzN1VmcVQ0L0IwaUZj?=
 =?utf-8?B?RUdSY0g2eTJ3U3NUTUhxM2ExUFlQbjJrai94YzZEenlaMFFpdTlqSDNZWUl6?=
 =?utf-8?B?aGFYb0FGTkRDT3FkWm04c3E4Wm10RlRmSDVNSXhPSjZRcW5JcmJOV29YOHk3?=
 =?utf-8?B?L1lLeWYxRkRqR1hveEZteDZxRit0blRYYityMzN0eTlPcVdSVHlkTnJIaFY0?=
 =?utf-8?B?SU1ycWovVmJPeDRMbDJ1QUZ5UUR5UWtKMjloYlcrL0dETkpGZXpOdVp4dFhm?=
 =?utf-8?B?YnQ0UVU1SWNNSTZqZFVjTXNTTlgwZWRsbmRsTkpjdEFNd05wbnBlVTRycnhU?=
 =?utf-8?B?dVJGS29TY0ptMUQ4R1kxNzJHWUlaK09jTmh3WGZVdXd5MTdKZVdmNzBxQ2cx?=
 =?utf-8?Q?6fHqwefd3QFvqTvZJcmRKy67r?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4b1466b-6914-499d-eb1b-08db19a43537
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 15:55:26.3432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f63eScFMIePyrvQmK7AX1ooTnOuW+RtT1r8cKaNEIQ3+9/vlugwLOuKmhitXWPctZYyvldgM1Z837VJW8vqNWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6353
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Muhammad,

On 28 Feb 19:20, Muhammad Usama Anjum wrote:
> On 2/21/23 1:50 PM, Stephane Eranian wrote:
> > Hi,
> > 
> > Testing Wyes' patch for energy-cores on Zen3 server loaded with triad
> > bench on socket0:
> > 
> > $ perf stat --per-core -a -C0-63 -I 1000 -e
> > power/energy-cores/,power/energy-pkg/
> > #           time core               cpus             counts   unit events
> >      1.001019203 S0-D0-C0              1               1.28 Joules
> > power/energy-cores/
> >      1.001019203 S0-D0-C0              1             231.38 Joules
> > power/energy-pkg/
> >      1.001019203 S0-D0-C1              1   4,294,967,130.96 Joules
> > power/energy-cores/
> >      1.001019203 S0-D0-C1              1             231.38 Joules
> > power/energy-pkg/
> >      1.001019203 S0-D0-C2              1   4,294,967,126.23 Joules
> > power/energy-cores/
> >      1.001019203 S0-D0-C2              1             231.38 Joules
> > power/energy-pkg/
> >      1.001019203 S0-D0-C3              1   4,294,967,122.50 Joules
> > power/energy-cores/
> >      1.001019203 S0-D0-C3              1             231.38 Joules
> > power/energy-pkg/
> >      1.001019203 S0-D0-C4              1   4,294,967,129.92 Joules
> > power/energy-cores/
> >      1.001019203 S0-D0-C4              1             231.38 Joules
> > power/energy-pkg/
> >      1.001019203 S0-D0-C5              1   4,294,967,121.49 Joules
> > power/energy-cores/
> >      1.001019203 S0-D0-C5              1             231.39 Joules
> > power/energy-pkg/
> > 
> > I think the result of energy-cores is not reliable and I think that is
> > why I did not
> > include it in the patch.
> > 
> > Could also be a problem with the kernel code, but I don't know why it would only
> > impact energy-cores given energy-pkg looks reasonable here.
> > 
> 
> I'm getting consistent per core energy measurements on AMD Custom APU 405.
> Probably consistency depends on the chip.
> 
> sudo perf stat -a --per-core -C 0-7 -e power/energy-cores/
> 
>  Performance counter stats for 'system wide':
> 
>  S0-D0-C0           2               0.51 Joules power/energy-cores/
>  S0-D0-C1           2               0.51 Joules power/energy-cores/
>  S0-D0-C2           2               0.51 Joules power/energy-cores/
>  S0-D0-C3           2               0.51 Joules power/energy-cores/
> 
> What is the fate of this patch now?

I'm working on the issue reported by Stephane. Will send v2 very soon.

Thanks,
Wyes
> 
> [..]
> 
> >>>> Stephane, this was an oversight?
> >>>>
> >>> I think it may depend on the CPU model. I remember it returning either
> >>> 0 or bogus values on my systems. They may have improved that.
> >>> The commit msg does not show which CPU model this is run on.
> >>
> >> I've tested this on Zen 2, 3 and 4 server systems.
> >>
> >> Thanks,
> >> Wyes
> 
> -- 
> BR,
> Muhammad Usama Anjum