Message-ID: <f8cba1b5-f82e-c74c-2eb3-25cc41110e45@meta.com>
Date:   Tue, 28 Feb 2023 08:09:27 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH bpf-next] bpf: Fix bpf_cgroup_from_id() doxygen header
Content-Language: en-US
To:     David Vernet <void@manifault.com>, bpf@vger.kernel.org
Cc:     ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        martin.lau@linux.dev, song@kernel.org, john.fastabend@gmail.com,
        kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
        jolsa@kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@meta.com, tj@kernel.org
References: <20230228152845.294695-1-void@manifault.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20230228152845.294695-1-void@manifault.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU9LZTd2bUk3Zm0wR1FVNEVCMGU1d0dac1Rjbm5LYllpMFc2eTBJZlhGUTg5?=
 =?utf-8?B?TWNtclFWWlRUbjZOaWs1Rk5BUmdwWFl3ZWlLNWJpVkl3SGdiNHF0ZlpTbms1?=
 =?utf-8?B?Y2drd29xUWdrMUFEUFQ3UHlNR0VWeFIzejE1Y1plR01kQXpIT012OFlKd1l6?=
 =?utf-8?B?Q0pHYlV0dnIzdTBGZGduTmdLaXNoNzZqT0ZXdlZ0dnFjdFFjbmdtWUhSLzk5?=
 =?utf-8?B?VVJLUHlyVWs5Z1UyYThodU16MnRiZEhWaXUwbVFrL040R0lCSzVtMmdNTWlz?=
 =?utf-8?B?MjFsaXM2N0ZTbUk1c3RkeGJKbDIrS2NCemRoZE1LM0RNaU00WHA1MmpNUmxH?=
 =?utf-8?B?c0luS2w0RVNQT1V4MmErVjZKYmdWMmd2cW5CL0pKY0VMYm92REZ3UlBuekpH?=
 =?utf-8?B?dll1N2FFbXNYZFdkc1VKTEUzWFBiSEdFdUR0SW10QVcwSWNkVkYxVUIwenNB?=
 =?utf-8?B?cTl0cEJJWmszTXg4akl0S2d3ZHJXTitHNTdDRUQ2K2luVkg2c0FtK2hZOEpI?=
 =?utf-8?B?dUgvZkpyc3lsMlYzQTZmT2NwMFExRHkyajNCSnA1azdiNzBWNWdPUUNLdTF3?=
 =?utf-8?B?eTc4WHhiRDlDelBRcDRMRFFjcWtXMTcwdGNYNWRLVlhQMlh4YWRCRERMV0RI?=
 =?utf-8?B?TU5pa1JNcHg0S1BPbXMzKzhNUmNFK2s1MG1LeGVvd0dqbDFDL0V6OU80ZWt2?=
 =?utf-8?B?cFZEOWwyOW93YnQySkJ5RkpKWXJ3NmpEV3N2VUtET1JhbzVoMnlSYXBuQ0FJ?=
 =?utf-8?B?bEJEbGlQUHV0U1V3WEQzL05oajVqOWdITHBETU8yaDRTcDBiS0VSSTFCZloz?=
 =?utf-8?B?L2hEN0xla0h3eGlSbG9BSWxoL01reUFyc1A3eUg0amQxdXFlVEdKYlZuMG8w?=
 =?utf-8?B?K3p1TjhnenkrQUlLOUtFa09lVWVFSXUyUEtFU1NMczlRbWN5MnExSlhBOUt5?=
 =?utf-8?B?VnRqOEx0azlNTWoxbEpZL0NKMVR1WGplQnpEQ2dxYlQrWjZkQXBTVVdZRTNX?=
 =?utf-8?B?aFFxbTEyNEs0OFlyOEN5NnhCbTJ5RVU1WUV5SW9hYkRTbDNOQWNZQzFhNm04?=
 =?utf-8?B?ajZ4T20zRytiWmMxQVEyUFpTckdzcUZZM1lqMjVsa3VZai9ic3JtQ3NwVFR5?=
 =?utf-8?B?Q0VRZ3V1amFYNVAwOTNmUjBIaGdZWHljNXZGRENieDhHcGtsYllUckpRZG5T?=
 =?utf-8?B?ZmdBM1luZGdaY015dGhxUXpUSFZwYkZPcGpKYmlJNGxBWkIrd3ptREpab0xK?=
 =?utf-8?B?czVzeG5zVlZBTVF0am9JVWxtUGxBcWNtcWViZTJ1UEoyZFhkTTgwVFFhWEMw?=
 =?utf-8?B?N084NVZYOUxrVFdKN2VZdVNGWG0rbnE5RXBOYlF6c21CK3plLzNheFZPSEp6?=
 =?utf-8?B?cFJTSytjaTM3ZnpPcjdPT09DKzUyNWtlSWZIMG9BakJuMFUrMTlEZ29LVGgx?=
 =?utf-8?B?bXpONGIxa3d3cGdLM0x0ZG9McEV3Z2VIS1AxZElKMENJT1dmMGcwNjYyd0ZR?=
 =?utf-8?B?MmxvQkRsWTlLb0Q4V1VXQmFxdVNQeXYza2dkaWJBYmhiSXFaNjVaL2tmaC9U?=
 =?utf-8?B?K2o4UVYyRjhLNjRxbHkydUZmOS9xbUdPdjhNQ2h0cW1XSEZYeG91TUtxeUNN?=
 =?utf-8?B?YmxxakhTVlN2NUhqRFgzWmRGUW9kVDY3NGV4MDVXRUdBUjFlMFlaWkJJc0VJ?=
 =?utf-8?B?RVpFTmZ2QlJ2UjcxdjVBRHlOVVRVZjJGYnhwY1VlRnRBYlFmV1J6Rm9pQ0xi?=
 =?utf-8?B?eVdFb2JhWTJKYlNRUnpCcmUvL0tDNmQySmtYNnhka3ozMlZMYUJtZHM4WEp6?=
 =?utf-8?B?N0Y4a1N6dGxUandvbUdWL0RPcExFai85bURBUG9ybFlCVmhaU2FQb0xSMFN0?=
 =?utf-8?B?MnBEbzM1dEJianNPV21EVVVWdnBrSlRKZ2FjM1g5blFEc2JzOFh4eTJxMVh0?=
 =?utf-8?B?RXc1YmxleEVUUUJhZWRRamxnNDc0ZEJlUjZQQzF6UnFsK3FPck5MbFIzKytu?=
 =?utf-8?B?Rkc0RjYwdEVQeW4zN3pxM0J0dHhTM29lQURseWtINXhpbS95NWgreWMveHV2?=
 =?utf-8?B?d3NEUzNOMXRYYU9sdXhoVWE2NGpXYUdNcDhYK0ZpVGtMMzhubXdJRFpsYkZG?=
 =?utf-8?B?QlVPSFg1ekFkOFp5VkpvaVcra0Yrc0l1NGgwVVIwVi9WMTFGZm8rSFdta3V4?=
 =?utf-8?B?ZlE9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d3621cd-fd2c-4d8d-3a38-08db19a62d38
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:09:31.8388
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EvltHHC9AVE89bo3gRZ9k2b274CdFqYzErWpaQMSp4QYDS8d5moJkRdGfHq5+L0z
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR15MB5301
X-Proofpoint-GUID: KVf4CPz3awo9MANrqrm2v3CuRznGkE7V
X-Proofpoint-ORIG-GUID: KVf4CPz3awo9MANrqrm2v3CuRznGkE7V
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-02-28_13,2023-02-28_03,2023-02-09_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/28/23 7:28 AM, David Vernet wrote:
> In commit 332ea1f697be ("bpf: Add bpf_cgroup_from_id() kfunc"), a new
> bpf_cgroup_from_id() kfunc was added which allows a BPF program to
> lookup and acquire a reference to a cgroup from a cgroup id. The
> commit's doxygen comment seems to have copy-pasted fields, which causes
> BPF kfunc helper documentation to fail to render:
> 
> <snip>/helpers.c:2114: warning: Excess function parameter 'cgrp'...
> <snip>/helpers.c:2114: warning: Excess function parameter 'level'...
> 
> <snip>
> 
> <snip>/helpers.c:2114: warning: Excess function parameter 'level'...
> 
> This patch fixes the doxygen header.
> 
> Fixes: 332ea1f697be ("bpf: Add bpf_cgroup_from_id() kfunc")
> Signed-off-by: David Vernet <void@manifault.com>

Acked-by: Yonghong Song <yhs@fb.com>