From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Nick Alcock <nick.alcock@oracle.com>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>
CC:     "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Hitomi Hasegawa" <hasegawa-hitomi@fujitsu.com>
Subject: RE: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
Thread-Topic: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
Thread-Index: AQHZS3T+krC1hSoIl0yf6T1wa1Trsa7kjkKg
Date:   Tue, 28 Feb 2023 16:35:27 +0000
Message-ID: <CO1PR11MB50892FA526AADBCA960D05B9D6AC9@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20230228130215.289081-1-nick.alcock@oracle.com>
 <20230228130215.289081-6-nick.alcock@oracle.com>
In-Reply-To: <20230228130215.289081-6-nick.alcock@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+W3jJ39AS8bRSR5tS3YLBiBSs2plNqDHa4lVQccb/pdOJ2ApYaMex42RimYr?=
 =?us-ascii?Q?BG/Rzn4YOygcbvILeynu4gp6yIFuWhFIaAGBi0D8qDUcKVlEzFiVYaAgDANd?=
 =?us-ascii?Q?PC48EKiFvmc0F3AgAz2iviKvIqL7MU/g1q4Hig1V7F7kLLqe8vLP/ypykZhY?=
 =?us-ascii?Q?jkGMEqYxPGYmjNpH3spKbNI2SnfGALqMd9NpFiW++jsajxL0S33963AN5sDb?=
 =?us-ascii?Q?+zISNTagqi33tyDwO0xnc/4TsHl9eXdfygjyebKwE7t86T32F35Amyw/Z4tX?=
 =?us-ascii?Q?/YNwj2yS85H68K4ceIHUYdbPd0ac4aDyOSaO5bLPqaTYwFhYrEPmQgrqnbNh?=
 =?us-ascii?Q?5FVTglwLKQRLaXNh9zsdyyMne48umI4ot+p733lNjqYp5XsUz0Zxj7ZSCUwo?=
 =?us-ascii?Q?l1ep242+3LFvPu1bws5cF6708O6uiU4d7/5FBlOdXdtGOEBIZgCTFKoomEPV?=
 =?us-ascii?Q?XqBwH1sf+EeAc3hRmU7Yso6mHKQTnMjWF0dzPdE8jLuO3WHDZed34yY7UuCt?=
 =?us-ascii?Q?BvEAtHJ0EP+8kquAT+IQyTxSUfIfAE02HMMUQID0WMR3MSCgBf4nvWL/ryYb?=
 =?us-ascii?Q?ea5L/yB45de08I6p7JOdVehQqimFB8V+WjmaUFBs1vuPyUy2Usef8gkCOkiy?=
 =?us-ascii?Q?Yv3bvckUnxDSP2rAoScqMWU6wwLTKFynT3negjzqvT8neLRa67Nbl7n5NkeX?=
 =?us-ascii?Q?yiMEsRKpnKKYcv71K/G/m/e/GHyZu3lrIRijkL/EgF8geoMW1Xp6w4x/N3kK?=
 =?us-ascii?Q?c3EQEOqZpI5a/s8onBfRsdMLQduU60UGRt9utKs6ZHsaX8PqSSkZNWInlSho?=
 =?us-ascii?Q?pTQGqxp6NEn0bcvjRg5MlRYSwqZEYYbf/fw/s6M8GlnivWzjn0LBQTH7O3g9?=
 =?us-ascii?Q?kUUpBbKXRri0g5bVy85Dix4S5SNcQ+LshqaArf4SLJ6tfJ1v6cVCMo0OkzWd?=
 =?us-ascii?Q?01tib+dJT2K+uu0zM1LTkeEu8Ffdd3ayzqCO03x0KnLooXjH8HjqT0QL65Cr?=
 =?us-ascii?Q?HAcqJ36AV3uT+w7FhYFedD4lsqlGCaGGwDmClR6oKYN7iCJmSxL2Rvv5Tfr0?=
 =?us-ascii?Q?cMDO0udRJ0mX97z2QZWKDUJVnzAkGA5ecJ4om/Mnt+a7KG8r2/DeJl4w5Swh?=
 =?us-ascii?Q?AsMt2Mq71AgEdhOWmx5o164dBjJfSiwH4XsALb+nZJrEwxygJrHjNIdFetfX?=
 =?us-ascii?Q?hO1pAiWGFfQb1/lVAPjgzJXyzt5FQkUej225igz7IzcokeNsWWh0NBcLStly?=
 =?us-ascii?Q?1ZQAtdZIop+MUzBTBN+mTy7F2V02BL5y00OS86SGXM8JgUuuIdGu/kuqysve?=
 =?us-ascii?Q?jT6J9fqRdXBU9brHQg/r91EQOmHGaC/efeM7MxdJbBwjSnZxchYZ5DNPz7EO?=
 =?us-ascii?Q?42fZiT68JH9N/Um1zTFWBQFq5TM5JRYClUp9qh+r3DbWQKnYjEx7JA0x7kbX?=
 =?us-ascii?Q?5ip8zIrpWRz7qC/wDdT21aae7BxY7mbINWSq0O7XB7vKSA3Dw4iZtjnhG2zA?=
 =?us-ascii?Q?j48+jUNYMV24a8YM5I0nsrWw1kUY4Mjm8vMNJ6ypThQfVsSl2UCkcy7O6zg3?=
 =?us-ascii?Q?ZSfN0ZDHnWArwyYJYGp6kewsp7LUFkiNbZolWhte?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77314944-7137-4ac1-1e8a-08db19a9cc7a
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2023 16:35:27.3623
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BM3rCMcdsd3BsOpq7f634bm9Y27l1/6lGZyCgZxDbte7GzmBSwTwzpUJ9rOqmlcNKTVPy/rxkdyQl7i30cWNIoo8Nn21V23MJcQcesIAv74=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7375
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Nick Alcock <nick.alcock@oracle.com>
> Sent: Tuesday, February 28, 2023 5:02 AM
> To: mcgrof@kernel.org
> Cc: linux-modules@vger.kernel.org; linux-kernel@vger.kernel.org; Hitomi
> Hasegawa <hasegawa-hitomi@fujitsu.com>; Keller, Jacob E
> <jacob.e.keller@intel.com>
> Subject: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
>=20
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>=20
> So remove it in the files in this commit, none of which can be built as
> modules.
>=20
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Jacob Keller <jacob.e.keller@intel.com>

Acked-by: Jacob Keller <jacob.e.keller@intel.com>

> ---
>  lib/pldmfw/pldmfw.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c
> index 6e77eb6d8e72e..54e1809a38fd9 100644
> --- a/lib/pldmfw/pldmfw.c
> +++ b/lib/pldmfw/pldmfw.c
> @@ -875,5 +875,4 @@ int pldmfw_flash_image(struct pldmfw *context, const
> struct firmware *fw)
>  EXPORT_SYMBOL(pldmfw_flash_image);
>=20
>  MODULE_AUTHOR("Jacob Keller <jacob.e.keller@intel.com>");
> -MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("PLDM firmware flash update library");
> --
> 2.39.1.268.g9de2f9a303