Message-ID: <956d0ddc-21c6-1074-42fd-67e6d72fb166@theobroma-systems.com>
Date:   Tue, 28 Feb 2023 18:36:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: (subset) [PATCH v3 0/9] fix reset line polarity for Goodix
 touchscreen controllers
Content-Language: en-US
From:   Quentin Schulz <quentin.schulz@theobroma-systems.com>
To:     Bjorn Andersson <andersson@kernel.org>, samuel@sholland.org,
        agx@sigxcpu.org, megous@megous.com, heiko@sntech.de,
        hdegoede@redhat.com, robh+dt@kernel.org, wens@csie.org,
        michael.riesch@wolfvision.net, lukma@denx.de, icenowy@aosc.io,
        kernel@pengutronix.de, david@protonic.nl, shawnguo@kernel.org,
        foss+kernel@0leil.net, linux-imx@nxp.com, festevam@gmail.com,
        pgwipeout@gmail.com, jagan@amarulasolutions.com, agross@kernel.org,
        hadess@hadess.net, dmitry.torokhov@gmail.com,
        jernej.skrabec@gmail.com, angelogioacchino.delregno@somainline.org,
        mamlinav@gmail.com, frieder.schrempf@kontron.de, angus@akkea.ca,
        Sascha Hauer <s.hauer@pengutronix.de>,
        konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
        linux-rockchip@lists.infradead.org
References: <20221103-upstream-goodix-reset-v3-0-0975809eb183@theobroma-systems.com>
 <167336743963.2134489.16668389773212954467.b4-ty@kernel.org>
 <f6a8a8f1-0eec-2716-d4f1-9115c9d156b6@theobroma-systems.com>
In-Reply-To: <f6a8a8f1-0eec-2716-d4f1-9115c9d156b6@theobroma-systems.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHFDZnRkbFpMVDRFY1NITE5yRTRIQkVZcTFPMS94MlpKRzBxWVhxK09sSkY5?=
 =?utf-8?B?U0JRS0N5UXN2MUMvYVFocE5DZTBVcEkrZllDSnAwWkZzMjI0TkpLc2k0RlNh?=
 =?utf-8?B?czUrdlgzODJCaXhkcEg3Y2owMjgzUmpaSGw3QSsvUzdGc2s5M0dVTWE1V0pZ?=
 =?utf-8?B?ay84UVd6a25MUjRDeHRac3UvRUdmTEltbnZBd2xkUERLY3B0RHBwWkk5SlVU?=
 =?utf-8?B?WjN2RDl2ZDFXa3FQZ09PdTFOOFlpNTFtdzhQekkrUS9kTmU5Vjh3YnQzMStZ?=
 =?utf-8?B?ZURBZEQ5TkorTXVYYm9pemhlV1V6WXEzVkJSbmpHd2xhUEZJRlgwNDM5alNJ?=
 =?utf-8?B?UG05clFoM1plM09URGRzcUFwTW51ZG42YnRjYTliRlcxZ09sYVZ4ZGlFNEZo?=
 =?utf-8?B?T3ZrYXBnWGpSR085NG1xSVYwV1ByNXJGK0pueitXMzBUcXM5YzRCRWRFcS9Y?=
 =?utf-8?B?Tk5VeHpUUEhZaHB5alVNaTZxMjBIYWpISlZCWm40aTF6MFNTbWpHODFFT1VG?=
 =?utf-8?B?czFvblJ1QW9qU0kzRkpjTDdxTEt2NERLNy83TmlPOGFLOERkbzk2UXNFOGpG?=
 =?utf-8?B?YXg5NXlmeWp3dVR0NVgzZUF5NDhvaW5vVzE5UVpLb3FydlZOZjhKbzNzOFNl?=
 =?utf-8?B?dkFydGxHZFAxM1RRcEROSXU4R1NCN2ZJR2x2U2J2MTZLWXUzd29FdE52QzBJ?=
 =?utf-8?B?NE41eGdjM2Y4bnhGSURrazhtU1JlQmJSdU5BM2lBeEh5VUN2NHJwcnFKbTgz?=
 =?utf-8?B?U1pHMzg1Yjgzb1hsMGdWVnlwdTl6TlI1bFBNMVJCZG5EemppeisvSDBMVFZE?=
 =?utf-8?B?c1psd2ZaZjR5U2ZNOHVpbVcwQ2k5K0c0d1VSc01Qei9QUEhia0dLZit2RjZo?=
 =?utf-8?B?Mm9HS2FtVVpCM3dwbHhVZFEwUXdwTkhnRmJKaXhNN0VnbHAyM2huV2lJTytX?=
 =?utf-8?B?cTdmeGhCRUZzWW9vTThidVR1ZWdwOFlhZURzaE95QXBxbUZVRTA2VzhGREd6?=
 =?utf-8?B?YmIrTUlwUDYvdGJQL2JHZnNuWG8xWE4wRTBtcTI1aWNvcGJHWlBLbHZEUmRl?=
 =?utf-8?B?b205WFc2V0Y4TC9sNWdyRXF0WWxFdTVCdkpHTDJuMjFMdmlDOFVrbmFxZGVl?=
 =?utf-8?B?YzlHaFZpTkNRT2VUb3Q5eVU1dmpINEdYK0wwTXF3alJueGh0bm81NnhqRDdI?=
 =?utf-8?B?bU5CbW9CVzdJd250blJzVThxbUNYaVFrb1Z5RXNoQTJSL2o0bHU0d0hTSHVR?=
 =?utf-8?B?OHpCWjNUU1I0NktnbHV6S25WalhVTkZ6VlpUb2ZzQWtyOXFUQlgrbDlEODM1?=
 =?utf-8?B?QjNJZ0pGMVFZRjZ4VkQ3eWpBWW1iU3N2T0hENEFWdWpxaVU1NXVrRmxnZVEx?=
 =?utf-8?B?VTN6a0c4TkhOeG50VXUwQjJ0dGVqMVl4ZGxMdWNWRGJINWpkSDFtYzQ4Qytl?=
 =?utf-8?B?N3FldU4rV21pSTVsMFY4dEp1N3ltKzB3MUZydmVKdXVkazV6d01hWmZBQ3dX?=
 =?utf-8?B?MVh2YmdWRjJ6M243Qk5sOGRQK0pHdzJ5NGpyL0t2Smd6czR5UFNmQ2ZvVlJa?=
 =?utf-8?B?MjN4RFdNK2VsVTJTbGswOFhsMnFzdEs3SmxSSlNxL0R2WjFhQlhXeDcvYVNO?=
 =?utf-8?B?T0M3cXFJQ0VvMWs1YzcvTDFVRFZHNzZLd0RaeUxKQ3h0L3E4dEs1ZDM5ZFlU?=
 =?utf-8?B?WnZSbWxVTDFKZzJSY1Z6dXVkT0FZMEZYa3Y4ZHJxMm5aTVBqaGpDc1pHY2NO?=
 =?utf-8?B?dWFKV2J1NUFSWElXU0Z6cTg5cDhGNEQySC9mVXhJSjF3bGU3V0laNzBMV0du?=
 =?utf-8?B?eGV1NldkUnNvaUJpWFFWYlF3em40ZTVDS2kzRTh5M05WNzRUdWIzSUpDUTdZ?=
 =?utf-8?B?cG9RQmlTV2tSZDhaZUFhLzh0am1qc3pKeUhqbndUT3lndUlrWlYrc3p1ZmJI?=
 =?utf-8?B?WWR0dDFiNUJLVmMrVHdpVURCc095TUUrODNnUWw4aFJDZVRjUkU3RzBha0tW?=
 =?utf-8?B?L1BaSzhjTzYyTmRteEFydVBOUHQ2SjB1SHRLNnNRdnJHbHdydWl5MDFOdDFU?=
 =?utf-8?B?TjVxSkZER0xzbHphREgvWFVDRFlrMGlxckFsTzY5VW9TS3hybTJTQzg1U0or?=
 =?utf-8?B?WlVsRjNnajZJV2F5RDV3OTkwdXQ1OXArSFl0Y2p2Vkt6MCtxUFZFWHF4M3BT?=
 =?utf-8?Q?+ltSumavm5jZpK7vX2uU6jI=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ed7304c-584d-4129-b3c3-08db19b24679
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 17:36:08.3123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P4YBwvDFr3gXvAaHTtwM4Ap682PZXJ7V3Rhy0lYptcG/PgX3OQ3eDKhX/H3cBcZZnkQtV+aF4Nm9+ZEsOOINbLcKGU7DaQT0Iln3Fvu3vzYZcDJVqbno6Q1BvyEcYFGE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9779
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi all,

On 1/16/23 13:37, Quentin Schulz wrote:
> Hi Bjorn, all,
> 
> On 1/10/23 17:17, Bjorn Andersson wrote:
>> On Mon, 5 Dec 2022 14:40:29 +0100, Quentin Schulz wrote:
>>> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>>>
>>> The Goodix touchscreen controller has a reset line active low. It 
>>> happens to
>>> also be used to configure its i2c address at runtime. If the reset 
>>> line is
>>> incorrectly asserted, the address will be wrongly configured. This 
>>> cost me a few
>>> hours, trying to figure out why the touchscreen wouldn't work.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [8/9] arm64: dts: qcom: msm8998-fxtec: fix touchscreen reset GPIO 
>> polarity
>>        commit: 8a0721dae68fdb4534e220fc9faae7a0ef2f3785
>>
> 
> Thank you for the merge, however I think there could be some issue here.
> 
> This requires the patches 1, 2 and 3 all modifying the input driver in 
> order to not introduce a regression.
> 
> I mistakenly removed the RFC tag and seemingly didn't make it clear 
> enough that I had some question on how to properly merge this patch 
> series, c.f. "Do we also make this patch series only one patchset since 
> the DT patches depend
> on the driver patch and vice-versa? In which tree would this go?" in the 
> cover letter.
> 
> So please, how do we go on with the rest of the patch series? Should I 
> submit a v4 which would be only one patch with DT and input changes all 
> at once and Bjorn reverts the patch they had just merged?
> 
> @Dmitry, since you would have to merge at least patches 1 to 3 in your 
> tree (I assume), would you be willing to take the DT patches at the same 
> time through your tree too? Are the appropriate device DT maintainers OK 
> with this?
> 

Ping.

Cheers,
Quentin