Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762213AbXILAo4 (ORCPT ); Tue, 11 Sep 2007 20:44:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755039AbXILAot (ORCPT ); Tue, 11 Sep 2007 20:44:49 -0400 Received: from smtp.ocgnet.org ([64.20.243.3]:46322 "EHLO smtp.ocgnet.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754448AbXILAot (ORCPT ); Tue, 11 Sep 2007 20:44:49 -0400 Date: Wed, 12 Sep 2007 09:44:37 +0900 From: Paul Mundt To: Michal Januszewski Cc: Paulo Marques , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm] uvesafb: Don't access VGA registers directly when running on non-x86 Message-ID: <20070912004437.GA26720@linux-sh.org> Mail-Followup-To: Paul Mundt , Michal Januszewski , Paulo Marques , Andrew Morton , linux-kernel@vger.kernel.org References: <20070911081752.GA19495@linux-sh.org> <46E67EFD.2040902@grupopie.com> <20070911115346.GA23493@linux-sh.org> <46E687ED.9000802@grupopie.com> <20070911123159.GA23692@linux-sh.org> <20070911230959.GA16406@spock.one.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070911230959.GA16406@spock.one.pl> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 18 On Wed, Sep 12, 2007 at 01:09:59AM +0200, Michal Januszewski wrote: > The VGA registers are only available at their legacy IO locations on x86. > Don't try to access them when running on other arches. > > Note that the code accessing them directly is just an optimization (limits > slow BIOS function calls). We don't lose any functionality by using > BIOS calls instead of it on non-x86. > If you do that, then you also have to #ifdef CONFIG_X86 around video/vga.h, as that drags in asm/vga.h, which does not exist on all platforms. I have little interest in adding a stub vga.h on my architectures to support a driver that in practice works on nothing but x86. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/