Date:   Tue, 28 Feb 2023 19:19:32 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Nick Alcock <nick.alcock@oracle.com>
Cc:     mcgrof@kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Conor Dooley <conor.dooley@microchip.com>,
        Daire McNamara <daire.mcnamara@microchip.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in
 non-modules
Message-ID: <Y/5TxBLcTDIdv2eM@spud>
References: <20230228130215.289081-1-nick.alcock@oracle.com>
 <20230228130215.289081-13-nick.alcock@oracle.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="J9YrWK5U4Nxh9aHS"
Content-Disposition: inline
In-Reply-To: <20230228130215.289081-13-nick.alcock@oracle.com>
Precedence: bulk


--J9YrWK5U4Nxh9aHS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 28, 2023 at 01:02:07PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>=20
> So remove it in the files in this commit, none of which can be built as
> modules.
>=20
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Cc: Daire McNamara <daire.mcnamara@microchip.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-riscv@lists.infradead.org
> Cc: linux-clk@vger.kernel.org
> ---
>  drivers/clk/microchip/clk-mpfs.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk=
-mpfs.c
> index 4f0a19db7ed74..d85b345f4c08d 100644
> --- a/drivers/clk/microchip/clk-mpfs.c
> +++ b/drivers/clk/microchip/clk-mpfs.c
> @@ -513,4 +513,3 @@ MODULE_DESCRIPTION("Microchip PolarFire SoC Clock Dri=
ver");
>  MODULE_AUTHOR("Padmarao Begari <padmarao.begari@microchip.com>");
>  MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>");
>  MODULE_AUTHOR("Conor Dooley <conor.dooley@microchip.com>");
> -MODULE_LICENSE("GPL");

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

I'll take this via the microchip/at91 clock tree after v6.3-rc1 has been
released.

Thanks,
Conor.


--J9YrWK5U4Nxh9aHS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY/5TxAAKCRB4tDGHoIJi
0qRYAP4hAGmSiUtr+YIBtvnpss72NXfOb3W3G/mOzk1iYpD5WwEAqOGVxkikgTDE
dmyRBIRrLaGFnutuZJDaqnQBnAUB6QQ=
=p4yC
-----END PGP SIGNATURE-----

--J9YrWK5U4Nxh9aHS--