From:   Nick Alcock <nick.alcock@oracle.com>
To:     Conor Dooley <conor@kernel.org>
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org
Subject: Re: [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules
References: <20230228130215.289081-1-nick.alcock@oracle.com>
        <20230228130215.289081-14-nick.alcock@oracle.com>
        <Y/5TU/gxAxfVOedg@spud>
Emacs:  no job too big... no job.
Date:   Tue, 28 Feb 2023 19:26:55 +0000
In-Reply-To: <Y/5TU/gxAxfVOedg@spud> (Conor Dooley's message of "Tue, 28 Feb
        2023 19:17:39 +0000")
Message-ID: <87edq9h9q8.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5C+h3LJr/rWX3JSlscwCxKyBkooNBbOYO1tYScnedgrGd82tVSFu95n5ZNXh?=
 =?us-ascii?Q?w4LhOt3tvMNawn01lb46/mWuoqG5KzY45KOZnLwiPxQvFHchP0ydwXMbwJw0?=
 =?us-ascii?Q?KwzPz3QvVCc8aMfQDIb1wskUQey2eaP8n5sH6tywndvWoTE0JhgjTtxQapZ/?=
 =?us-ascii?Q?tmZi1OBaOKW/h1e2sL3R11BtEN0SuwIj/dQZBumBG/2rouPOhpOqU/O2PoaO?=
 =?us-ascii?Q?ITvVeEiHxsI0XwdZAVfOVii00TGFW/FoLwdD0wM+IwEnMGHtnQ+pRhR6zAY1?=
 =?us-ascii?Q?2y4rArEjmfmpAvZ46V69Q/enhYyl8Nwsd9aUWBC5ryfQXIxn/f5+ahos0gNX?=
 =?us-ascii?Q?j75A1dnqnKgTnuAP1S1mEiFNplJHfjuZNtFgb3GVYs1Yga1WTVh11hgImSqP?=
 =?us-ascii?Q?3qc5kRPQxGnCK6ygqPCB5nXnE1IiZCIZqdy/V0ThQJLJsLvYjLvBf/VNitJs?=
 =?us-ascii?Q?KRjqVSaVO3WtCQVYGKfMTu0nuYuLBFacsuelZu/yKMpHSfyoU32xEp+rKRjf?=
 =?us-ascii?Q?EEmvQGxhMbYiIO9RWBx80gl8WHqux+e/sUxN06x48xIOJ/CqusHejbozkiJI?=
 =?us-ascii?Q?Q9z1MAeXIyqbIR/Ct2e4JouRI9bQzeSsAOIFKXM/E/lHUqVSBiGEKcNLltVj?=
 =?us-ascii?Q?Z2pG8SDRHZLmGKUym3kQMt8FytckZPKjsrvbJOXBdG2S9zkTITQ4Ya1TmPVg?=
 =?us-ascii?Q?IQJdU0uLqWSAPWhKVIVBWVI3pf+jVDJvSjpLUmuw44bD/u5LxBSFTrLNQ65p?=
 =?us-ascii?Q?xlwKDwTZNmSn6ds38jMKTBvFvG+IQ/Mtl02Zd9dPicxbxMiz/E4O1BSUKTTK?=
 =?us-ascii?Q?B2aqyjFjGU24BdWExDzbu44crS7bbragvTLJ68LO6KKFiL9cVGzFFBafpG6n?=
 =?us-ascii?Q?1G3gkqJmNvCJvj0E0ZtdgQ3Ckav647x7wygnRm19nln6wXUtSsitYojuPGv8?=
 =?us-ascii?Q?qM9bnZTyQKW7ctSCa/0AB47QiT5EGBSCuOAMMtTwP/6OKDLr08mWy/6pZowz?=
 =?us-ascii?Q?L0l9q95j4MNX05vdf7+QgCpL5VXD/y0ehrBY5MVWCUo+MfAOYfTKaHqovrdL?=
 =?us-ascii?Q?XaeB9cZQfUwoxI3sSu3P8mA8nwVsRSTzySP/hMFiFa3wVYx9eLKH5iAnnyH1?=
 =?us-ascii?Q?hKEGp+doq7wp1FitfuxXpx2vMYPqdsH3mMim+vOMx2NeFA61dLpEwZEvvpcJ?=
 =?us-ascii?Q?fpKlWZCjPGwQxOABc/KI0tPd0UFeqh1LDZQEkIFCx0InCGFogmoprk+AtKiQ?=
 =?us-ascii?Q?htcrMl/FKpQLPHkMowY058rGXznuDiBaHlGfsRn9HYyXiasfUn5ipWdw+0OZ?=
 =?us-ascii?Q?bZfi2PNsrbyRr2I0P+8ynntctBD0g4mz1tV4GNQVREF8MKZnZiRELAd9Ne5R?=
 =?us-ascii?Q?duaYh5ffwAkAabpRNJSSxHFePxWezs0orD3QdiM1cuH7ij43cRW3VrsuA6+a?=
 =?us-ascii?Q?vUaBZ9QdMcUK1VQ6TVuOCij1+VyrkA0rx1TRLMR7r7u5+4YblPJPJCVEJk2/?=
 =?us-ascii?Q?hYfykI6GBZgoOvuEAepGR5OJxcG//I8v9plXX9ExkQ+PPBNRf2qXzMlbhRgZ?=
 =?us-ascii?Q?3zJduhYYGDKqXw5yimXYwamGR8HrcWLWiJCtR+fwgqBfdx+esCiqc5hHLL6I?=
 =?us-ascii?Q?V9aEIB37vZ3NnQZs+o8aA3Q=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qs+lqqXQuY8LadH85iDYtQUVcXPHWNfwCqfmB93xd8tEpWQbU2FoDQHY5WGnDIsxSn5SzByJ4IiHHmOJ8ghzYjVq1+UlXFgKL3HRIj81PVXlDMNaKfnqfhMd20z5uNfCr4oiTVtS7ycEQ4kI0lYY/9ykEvcOHCJoBidQmOski/Q3hpgY3c+fTQ5++1H+oTV0gUWNumkiuK2NqXGAnuOYsGGQjmWHGN/iY+Z1ZnMHf3k0VsljE5J8MnO446BTkzBEwE43leAXDunZiLpO0WvUy0lGLeZItkEO0QCbMZf5T58v/AWpfyJL4FTG5hs0TK/kFofFBZ7hDnBR2ntm138JXvebV1YjZqW1xPpzOemN+xpbXeraTDumd3mBz3vHsNcSF5+T6o2UJRBFyK0OD/YSGCLNJdmYSMGST/M4znhwGsxCEeW8zADPU9gPXLr4hyLrQiLJrH9lNeuoYRQTFPDDYRnwO5A9g4VyqQ4GdRZXhfVNbWZcet1cIdJFzzW22GYfNQzzgfmMJP4ra8U6oRKzy9LN3odC+AuDkaxM0pKrU3K1IuCKs1RMUmv20P6zdRylsB+KtmsoRWoCC5ky8U4RQLH0Nu1rz6VsWzxn/RRCyf8fAFMV2n5dWWYFPSFbiBUotX6AyEAQibM5RUHe634YeLyHfSeB1/p175Db2FUbCIUyERMM9BnjVoZk6VIcqPjeQ1eZYvD12eo5qmCS1B2/5g0H+99dlSxN/j6Ntqux3sWhNKPU4MxHLirjSD+b/nPcsvjRaaDRKbadn7eDMOe7K+ivGdWPJvEjX+xLr2x5ZPSsV4rpHCd6L/LLaL2G6Dm5Z/OAmocWW66aIQFWXQ7wAw==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5493df0-2b7d-4f8f-c043-08db19c1c3c5
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 19:27:00.7894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vexqPffTGAD7m14ILMZT72OsbLCWwbCE/s9wiegyO6v5CciR126CkCfvmlelMMCJNxloD6UzL3FVgWZacZZcpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4182
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-02-28_17,2023-02-28_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302280161
X-Proofpoint-ORIG-GUID: 6SILpwpYtmmF_ggeSTo4N-NuT7zvWLjZ
X-Proofpoint-GUID: 6SILpwpYtmmF_ggeSTo4N-NuT7zvWLjZ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[dropped non-lists to defend innocent ears from my flaming pedantry]

On 28 Feb 2023, Conor Dooley stated:

> On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>> 
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>> 
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: linux-modules@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
>> Cc: Conor Dooley <conor.dooley@microchip.com>
>> Cc: Daire McNamara <daire.mcnamara@microchip.com>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Cc: linux-riscv@lists.infradead.org
>> ---
>>  drivers/reset/reset-mpfs.c | 1 -
>
> I assume your script just got confused here w/ $subject, since there's
> only a change for this specific file.

This file has had no commits since you wrote it last year, and the
subject for that commit was

    reset: add polarfire soc reset support

so, er, yes, the script used 'reset:' as a prefix, mimicking the
existing commit. I'm not sure what else it could have done.

(Regarding the rest of the subject line, I suppose I could have arranged
to detect single-file commits and turned the subject into 'in this
non-module'? But there comes a time when even I think that maybe I might
be overdesigning something, and automated grammatical adjustments to the
subject line was that point!)

-- 
NULL && (void)