Date:   Tue, 28 Feb 2023 19:28:45 +0000
From:   Mark Brown <broonie@kernel.org>
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        michael@walle.cc, quarium@gmail.com, jhentges@accesio.com,
        jay.dolan@accesio.com
Subject: Re: [PATCH 0/3] Migrate PCIe-IDIO-24 GPIO driver to the regmap API
Message-ID: <Y/5V7a4M+LhZQhsM@sirena.org.uk>
References: <cover.1677547393.git.william.gray@linaro.org>
 <Y/5RfjJCDdrZbHgJ@sirena.org.uk>
 <Y/1ksJHUENCwg/jy@fedora>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="z224iF5tpl7ptq6H"
Content-Disposition: inline
In-Reply-To: <Y/1ksJHUENCwg/jy@fedora>
Precedence: bulk


--z224iF5tpl7ptq6H
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 27, 2023 at 09:19:28PM -0500, William Breathitt Gray wrote:
> On Tue, Feb 28, 2023 at 07:09:50PM +0000, Mark Brown wrote:

> > The values from the config buffer are supposed to be written out in
> > regmap_irq_sync_unlock() - why is something custom needed here?

> The PCIe-IDIO-24 "COS Enable" serves a dual purpose of interrupt
> enabling/disabling as well as configuring the interrupt types. Since
> this register is used for masking, config buffer would clobber the
> register if we use it in this particular case. Instead, we ignore the
> config buffer and configure the type directly for the device (handling
> the case where interrupts are masked and shouldn't be enabled).

Could you be more concrete about what's going on here please?  In what
way does this "COS Enable" serve these dual functions and why do they
clobber each other?

--z224iF5tpl7ptq6H
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP+Ve0ACgkQJNaLcl1U
h9CocQf/bQq7YkoCwVIr7g2hJACwZ7oQxNVAHU6c7kFyeA3MlDS4vD7efAFUOv45
ePto+mmKs6aRGW/B/0xKgXRHleY8BIm84vu/jgsB2L/6bOelnSLslWRek6ZGqQHa
PBqp3RWg9y1YP46C1AErJ6m/pYPbGhlBSMifDrKj01iiZ1G4vHXeutqDNFrCPIm5
8nxqLhJjAshZJGM1pjfkf53uoyRzG+PgU2hmUkURw5gqWCBTK679+LXOdHLUZDHM
gNcav/QvisiwS8JXDAhdQOwbTb/86Z6OrCcPbM2d+LKy65f51MWC7FIrdfHNH/7s
aMVEOwoiaJ2Bpf0HXu+gxTpKtZFfyQ==
=81Tq
-----END PGP SIGNATURE-----

--z224iF5tpl7ptq6H--