Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76418C6FA8E for ; Tue, 28 Feb 2023 19:28:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbjB1T24 (ORCPT ); Tue, 28 Feb 2023 14:28:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjB1T2y (ORCPT ); Tue, 28 Feb 2023 14:28:54 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC72812F11; Tue, 28 Feb 2023 11:28:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 724B2B80E9E; Tue, 28 Feb 2023 19:28:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18C21C433EF; Tue, 28 Feb 2023 19:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677612531; bh=kMA69NrL+76sUcWf1jULnTfFwY0MrYdOtzZl8EFoHfw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F0DAa2oba1EsKPi6cKSaGu872lQ4eDzeXihS0RbPtBerY4qUPyFTAROJYIF0tIm5y /eC1fsgqkQ26JBXUZdq6WmrYBDDAY4ugjxsQjmt3aFOKLaK0U70gQqblP+UpumkNlG hQhx0S3MPBmAz4HSOwA7dXg3DasmWVaK2I//9gRtEO5D9Ib/Q8pAjWwVzkpJR7HjRl Xk7f7h2jljtHcEpRBmelVKS+F+8HQcQeb0TftvPRSbtpmwuwaSNz+nGq0aL6+Ls9sO Y2nXLrIh44HGWdG6Gxw+gBzpfdc99kqTykeXctyjq1jiZ48Hs7E/UbCf4OfCJvuYcL KNAvR23ZHxLnQ== Date: Tue, 28 Feb 2023 19:28:45 +0000 From: Mark Brown To: William Breathitt Gray Cc: linus.walleij@linaro.org, brgl@bgdev.pl, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, michael@walle.cc, quarium@gmail.com, jhentges@accesio.com, jay.dolan@accesio.com Subject: Re: [PATCH 0/3] Migrate PCIe-IDIO-24 GPIO driver to the regmap API Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z224iF5tpl7ptq6H" Content-Disposition: inline In-Reply-To: X-Cookie: For external use only. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --z224iF5tpl7ptq6H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 27, 2023 at 09:19:28PM -0500, William Breathitt Gray wrote: > On Tue, Feb 28, 2023 at 07:09:50PM +0000, Mark Brown wrote: > > The values from the config buffer are supposed to be written out in > > regmap_irq_sync_unlock() - why is something custom needed here? > The PCIe-IDIO-24 "COS Enable" serves a dual purpose of interrupt > enabling/disabling as well as configuring the interrupt types. Since > this register is used for masking, config buffer would clobber the > register if we use it in this particular case. Instead, we ignore the > config buffer and configure the type directly for the device (handling > the case where interrupts are masked and shouldn't be enabled). Could you be more concrete about what's going on here please? In what way does this "COS Enable" serve these dual functions and why do they clobber each other? --z224iF5tpl7ptq6H Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP+Ve0ACgkQJNaLcl1U h9CocQf/bQq7YkoCwVIr7g2hJACwZ7oQxNVAHU6c7kFyeA3MlDS4vD7efAFUOv45 ePto+mmKs6aRGW/B/0xKgXRHleY8BIm84vu/jgsB2L/6bOelnSLslWRek6ZGqQHa PBqp3RWg9y1YP46C1AErJ6m/pYPbGhlBSMifDrKj01iiZ1G4vHXeutqDNFrCPIm5 8nxqLhJjAshZJGM1pjfkf53uoyRzG+PgU2hmUkURw5gqWCBTK679+LXOdHLUZDHM gNcav/QvisiwS8JXDAhdQOwbTb/86Z6OrCcPbM2d+LKy65f51MWC7FIrdfHNH/7s aMVEOwoiaJ2Bpf0HXu+gxTpKtZFfyQ== =81Tq -----END PGP SIGNATURE----- --z224iF5tpl7ptq6H--