Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C88CC64EC4 for ; Tue, 28 Feb 2023 20:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbjB1Uiu (ORCPT ); Tue, 28 Feb 2023 15:38:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbjB1Uis (ORCPT ); Tue, 28 Feb 2023 15:38:48 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2003D12F11; Tue, 28 Feb 2023 12:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rjmB08qSudLVy5Oxuak4SVT499NNZ/1U705pw44O6iE=; b=vg9fQ3uflWT52xvz1H2rIYukn/ DHBuAKB8FQO09JyJC1EiRllcuNa0girL/GvIKEl3yimfCpJryD/1RDUWUQqiENzwy+BtPp8QVKjdA BsRgN/idbzGFoIMoYUsJRrFZCuqQPfdJF/2pHbLhMXC9xxDjFi1gcooSvTU/paxhqU7rBC7kLGqvy sqPJ2xa36Z0Zk4xJ4j6H3/Iy3r9TC45RvJNiRIURa7vtMOJ52h+9ErUZTOlvDXUJGuQykzvCHVTYs gt20QMNscDJO46o4aDH7RYmHAxSycerTAY0x+Hxm5jdMX+YiNF9itFx8clmluCjo6jHc8irjIrVxe LuoBm7+w==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pX6kH-00EDro-Gy; Tue, 28 Feb 2023 20:38:45 +0000 Date: Tue, 28 Feb 2023 12:38:45 -0800 From: Luis Chamberlain To: Jason Baron Cc: jim.cromie@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH v2 1/2] dyndbg: remove unused 'base' arg from __ddebug_add_module() Message-ID: References: <855201dc0204a1428a79d415c97df2b6e11c95c3.1677612539.git.jbaron@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <855201dc0204a1428a79d415c97df2b6e11c95c3.1677612539.git.jbaron@akamai.com> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2023 at 02:34:21PM -0500, Jason Baron wrote: > __ddebug_add_module() doesn't use the 'base' arg. Remove it. It would be good if the commit log explains why the base became unused. What commit removed its use? As of what kernel? Luis