Date:   Mon, 27 Feb 2023 22:12:27 -0500
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Michael Walle <michael@walle.cc>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl, broonie@kernel.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        quarium@gmail.com, jhentges@accesio.com, jay.dolan@accesio.com
Subject: Re: [PATCH 2/3] gpio: gpio-regmap: Expose struct gpio_regmap in
 linux/gpio/regmap.h
Message-ID: <Y/1xG+K1yzcRZtZ4@fedora>
References: <cover.1677547393.git.william.gray@linaro.org>
 <5c0354c87d4d2a082cf0c331076d5aad18a93169.1677547393.git.william.gray@linaro.org>
 <0e0901de3668baec5ce7cd4836c045a5@walle.cc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4P2X6kH733MEoG5H"
Content-Disposition: inline
In-Reply-To: <0e0901de3668baec5ce7cd4836c045a5@walle.cc>
Precedence: bulk


--4P2X6kH733MEoG5H
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 28, 2023 at 09:44:02PM +0100, Michael Walle wrote:
> Hi,
>=20
> Am 2023-02-28 02:53, schrieb William Breathitt Gray:
> > A struct gpio_regmap is passed as a parameter for reg_mask_xlate(), but
> > for callbacks to access its members the declaration must be exposed.
>=20
> That parameter is only an opaque one to call any gpio_regmap_*().
>=20
> > Move the struct gpio_regmap declaration from drivers/gpio/gpio-regmap.c
> > to include/linux/gpio/regmap.h so callbacks can properly interact with
> > struct gpio_regmap members.
>=20
> That struct should be kept private. It seems you only need the
> regmap. Either introduce a gpio_regmap_get_regmap() or add the
> regmap to a private struct and use gpio_regmap_get_drvdata().
>=20
> -michael

Ah, I'll drop this patch then and use gpio_regmap_get_drvdata() in v2
instead to get access to the regmap.

William Breathitt Gray

--4P2X6kH733MEoG5H
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCY/1xGwAKCRC1SFbKvhIj
K6wQAQDYbtyg6tuPPY4lER4AZoJHKCG9Dw5uTQjYToENfO9mhAEAyhvpWcsNNt50
RwPbG2WFbcZbFB7Ihb9hV9MEZyE9Kg4=
=JR+8
-----END PGP SIGNATURE-----

--4P2X6kH733MEoG5H--