Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43AC7C64EC4 for ; Tue, 28 Feb 2023 21:30:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229832AbjB1VaA (ORCPT ); Tue, 28 Feb 2023 16:30:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbjB1V35 (ORCPT ); Tue, 28 Feb 2023 16:29:57 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E47F2E0CB for ; Tue, 28 Feb 2023 13:29:54 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id o15so43319183edr.13 for ; Tue, 28 Feb 2023 13:29:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1677619792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+8cphB32FCA+JDrayMTXIg9hnTVIdgiqn6d+31xf70g=; b=RnvoGAxGwdikhKT4SupAxcADFamYOt+/v6RSL1oTb/zDbv1TM2he0JfutFX0uxibsD aXfgAAPUlUpjgysAiDQd4529DHvHf+CRHuCzA3rdEZt3Lo9uF070u8Vc6hdwtGGCfB+P QOl8M4FHCDbGl0EnClfCc8ZznvdwK40yN+tsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677619792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+8cphB32FCA+JDrayMTXIg9hnTVIdgiqn6d+31xf70g=; b=amfr3UGwcsWgQVcX5C3e9Cuoz7PT5dAry5MkiFEzBTw/KJpVP4F0zytHumTicxQ/ct XLy6A9NJ9Ud5Z82SspPeiwkx1fOPhcgmacxvhItayFSlFm95pgC67GLuEXbxYfuoVB1A a0RYxvWptrJBHnaUFtDCgxYdxZ58q5GKkwkfiKaSQQZYyZST5Ov0qHQoSALo4zPOXdtF ry4p39pKHNQ6c4HHl/UudTlFPWMJIh+LUQLjlHNNanpMN9mRPzqKZ7ahJ60sxHGWu0Xz /uyT6oDAw2XgrHhlSVhe3i5qssUoITBaBnTzeW6irlvN275sn0N6jZzc56waGrju61OT jmww== X-Gm-Message-State: AO0yUKWWnwEWQf40Qy2cwOqxyls54eqwldSaR+tPRzFTGUqyiNMHA5Bj GRsIinSVY1Fkc6YkjxHruDbs6Rb2kxFy2Z0y6iw= X-Google-Smtp-Source: AK7set/v185P91w1L2hk0IAyCZvjzZLSk/hJrHa5tDHfkSSYV2hu17YarbOgKcAAtVpEPHlwtFOH8g== X-Received: by 2002:a17:906:a20a:b0:8af:514f:1078 with SMTP id r10-20020a170906a20a00b008af514f1078mr4346305ejy.31.1677619792622; Tue, 28 Feb 2023 13:29:52 -0800 (PST) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com. [209.85.208.53]) by smtp.gmail.com with ESMTPSA id gv28-20020a1709072bdc00b008b8ae79a72bsm4976459ejc.135.2023.02.28.13.29.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 13:29:51 -0800 (PST) Received: by mail-ed1-f53.google.com with SMTP id ee7so45935673edb.2 for ; Tue, 28 Feb 2023 13:29:51 -0800 (PST) X-Received: by 2002:a50:c34a:0:b0:4ae:f144:2c8e with SMTP id q10-20020a50c34a000000b004aef1442c8emr2699107edb.5.1677619791223; Tue, 28 Feb 2023 13:29:51 -0800 (PST) MIME-Version: 1.0 References: <20230125155557.37816-1-mjguzik@gmail.com> <97465c08-7b6e-7fd7-488d-0f677ac22f81@schaufler-ca.com> In-Reply-To: From: Linus Torvalds Date: Tue, 28 Feb 2023 13:29:34 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] capability: add cap_isidentical To: Mateusz Guzik Cc: Casey Schaufler , Serge Hallyn , viro@zeniv.linux.org.uk, paul@paul-moore.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2023 at 1:21=E2=80=AFPM Mateusz Guzik w= rote: > > This is part of the crap which made me unwilling to do the clean up. Yeah, it's not pretty. That said, the old code was worse. The only redeeming feature of the old code was that "nobody has touched it in ages", so it was at least stable. Linus