Message-ID: <11be067e-8d42-e10c-342c-4224ea546130@amd.com>
Date:   Tue, 28 Feb 2023 16:31:09 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH 7/7] x86/resctrl: Determine if Sub-NUMA Cluster is enabled
 and initialize.
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>,
        "babu.moger@amd.com" <babu.moger@amd.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Chatre, Reinette" <reinette.chatre@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "x86@kernel.org" <x86@kernel.org>
Cc:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20230126184157.27626-1-tony.luck@intel.com>
 <20230126184157.27626-8-tony.luck@intel.com>
 <85d7e70a-b9c8-6551-b1ac-229b51ee18d7@amd.com>
 <SJ1PR11MB60837729155ACDEB1C093DCFFCAC9@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <SJ1PR11MB60837729155ACDEB1C093DCFFCAC9@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTdrckt6ZkRuZldKNCtsMzF3UjZtMUlIcTZMNlhCYVlLcUkwR3gzYjZDTklH?=
 =?utf-8?B?TjlGWFlzVE5hcjduWDlFbkgyZmlSOXRrcEtMakUzcVViLzF2NUFXV3p2TmVk?=
 =?utf-8?B?ajBoMUtFZlM1WDdUaml3V0JzSUhsMFQxR1JIeHdtZnY2dWV4MXdndVluSmQ0?=
 =?utf-8?B?MEkvYzV4WXo5YzVWUVlzYzdIaXg2SWh3SzFGczJaQlkxQ3QxU0k2czR3K0xR?=
 =?utf-8?B?MTlKbXA3VEtSbWltUmhaZ2Rkajd3dWpwMmRNa1FDSE9IcnJnRk4yMENVK3Bl?=
 =?utf-8?B?VkNlVzBscWVMbTFMQ3FaM0xYTVhJWXUrNThJSW9rSWFldXN2V1pKSWtuR25n?=
 =?utf-8?B?TEl1VU5LRk5CM3ZnMkdYblFZYUF5dnRiZlR6QUZ4WGM3OTBaR3ViaXVoUlpY?=
 =?utf-8?B?SmVGRkszZC81YWQzb2JOY0lrRWNDYVlVUGVNMFAzT0U0NW5sWis2TzUyVUVq?=
 =?utf-8?B?cEc1ZGlJVjc3K1g5TEN1TUw2b3BDaVIyS3Y4Mk9DUERNcCtsQU1HUlB2U3k2?=
 =?utf-8?B?TmNHZUVUUkZoN3RpZW51RHQ2bGl6aENwNXM3R01UMm1ZRkNRTHYyUlVjLzdw?=
 =?utf-8?B?eXlLYmQzbzFyQ1F1ZDRtOHFaeVpjYUFIZ2trY3kxV3Y1dVQwakZucWg3cHFL?=
 =?utf-8?B?QnBPa0tFbW9WcWlSV0RNN3I3NDdzYkVhNkRmaUpxMnNkODN5QkUrU1MxM2Fs?=
 =?utf-8?B?U0pheFgzYlhhNWxaZWdac1BxbElZbXR3Y05MaTBoUUpaVi9zTHVRdlgvRHlZ?=
 =?utf-8?B?UXBRRkErTjJIRU1ET1o5MmtNVHp6SWZBaldkSlVOSk9BUHJ1Q2d1UUpBY2NC?=
 =?utf-8?B?QitVdnFpWUpzNlhKNFhXKytMbXZVWWZtSUcwMjlXb2pqdkhnNlVPTURzWVUx?=
 =?utf-8?B?WUErbUM2Tzc2Vnd2K1MzbE1TS0p6dnloNXNSOERvbVFUd1BxRm9XK0FNQ3E1?=
 =?utf-8?B?NzNRY1l0T3FTQlJLS1M1dFpxbEJNRnFSRExzaE9kL3dIaERNZ3BVcUlTbTFh?=
 =?utf-8?B?TzNoNzZaL1IvOFpvUDNScnNhazY0ZXBXelVxTlBmaVQ4TVJXU1ZBazdMQzdB?=
 =?utf-8?B?TkdOV1M2Y1FPSDkveHFjTmg4MHJOdWU3dlg4akt2Yjc4YkxWbHByVEN0NjJy?=
 =?utf-8?B?aVFzNDFtVXZOd0ZpbVZTMUpmTnc2TVduVHB2eUg5UHhJSG1yRXJPVEVSdW1S?=
 =?utf-8?B?bkNqZzNqc0V3Sk5BZGdxNmUwTVVValcwZFRhTGIyZ1dGdEdZQzhZc3FoM2dz?=
 =?utf-8?B?M1MxLzhDZHFZbDFPcnRKSUNSa0ZKUFA2Z2R4OUxDSU5HbEFwMFFQQ0ZPaTNP?=
 =?utf-8?B?SHU1YmJtbExWTS9KQm10TVBYaU52M093ZnJLUVVOdmYwWnJQRnRRaFlLeVdW?=
 =?utf-8?B?WDFEMGxpWHJ6NGdZOUwvOGl3VVJZQko5TXBYakJLUmcrSDA3UEhrT0VlRnFm?=
 =?utf-8?B?MUZQOFF1S0VRUnJRblh6U3RNcGowN3hOSUY4Unl1b1RZTGdwY21NK0E5SWpN?=
 =?utf-8?B?KzIwTUxNTjBYK05Kak5vQzBOMFl4UC8yMHl4bVFMWFFRQlVSRkhMQXp5bCt4?=
 =?utf-8?B?WDhUYUNJTFZJUzQyR3Vlc3ZlbWtpMURSdC9CcTl1dHlTbkdNY3dLbk82ellr?=
 =?utf-8?B?c2lPSDNkSVZuYzdmSHJ6d25KcVFaNHhQa3BMMWh1cHp5U0w4QVBPMUQrV29m?=
 =?utf-8?B?U0FuSTFQeU5ieEV4VVVNdjlWb09wM0xDcGFPUXRrRlJrWll2R09sY0wzWnB6?=
 =?utf-8?B?VFVJTERiQ0E0anFsc1VhZ2xYS3BVMzViZW82SlY2SzRKL00xVGVJZysydTRj?=
 =?utf-8?B?Nmlmc3hmNWhkK0NyVzFCcVVyTFJ3TWp1UVpNMVczQm00UmdnTU92Y2tjUXVx?=
 =?utf-8?B?UFlqeFg4WW5kcWpRaER1WmMrRHF4WEl6V3M4aDJRRklzeEQwL3RUMWYxcWhw?=
 =?utf-8?B?OVI4U3FDWVkrWTZCTW80c3FncStrRDZZT2dUenkyUDNBc3hjZnY1bE9ITTRR?=
 =?utf-8?B?N1NKOXAwMXJsV1FrWGxTWlpzL1dqR05kY2xsdTdPY25PNEl0WGFrUDFZZnJK?=
 =?utf-8?B?SFJOQnREUWVSK2ZydlNuOVhQc29IaVlJQjNwTDhNVVZHYStXWTBRT0NlZFJH?=
 =?utf-8?Q?0Re6tpsLDG00o9reUKqetLcwR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d98ed65-18b4-430b-c5d2-08db19db7f99
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 22:31:13.4407
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K1qp9BO1+MyfBNoTFY/r+Z9aqTnJgg04hhFTYRpLKP6rSsa5+bEi0qdmo50Pyt7E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7670
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/28/2023 2:39 PM, Luck, Tony wrote:
> Babu wrote:
>> I am thinking loud here. Have you thought of addressing this problem?
>> When a new monitor group is created, new RMID is assigned. This is done by alloc_rmid. It does not know about the rmid_offset details. This will allocate the one of the free RMIDs.
>> When CPUs are assigned to the group, then per cpu  pqr_state is updated. At that point, this RMID becomes default_rmid for that cpu.
> Good point. This is a gap. I haven't handled assigning CPUs to resctrl groups when SNC is enabled.

You may need to document it.

Thanks

Babu