Subject: Re: [PATCH v2 00/20] Some bugfix and cleanup to mballoc
To:     Theodore Ts'o <tytso@mit.edu>,
        Ritesh Harjani <ritesh.list@gmail.com>
Cc:     adilger.kernel@dilger.ca, jack@suse.cz, ojaswin@linux.ibm.com,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230228114306.3328235-1-shikemeng@huaweicloud.com>
 <87356pwxyc.fsf@doe.com> <Y/6AgYotmMdjei3w@mit.edu>
From:   Kemeng Shi <shikemeng@huaweicloud.com>
Message-ID: <81568343-36fb-aa90-2952-d1f26547541c@huaweicloud.com>
Date:   Wed, 1 Mar 2023 09:28:40 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <Y/6AgYotmMdjei3w@mit.edu>
Content-Type: text/plain; charset=gbk
Content-Transfer-Encoding: 7bit
Precedence: bulk

on 3/1/2023 6:30 AM, Theodore Ts'o wrote:
> On Tue, Feb 28, 2023 at 10:04:35PM +0530, Ritesh Harjani wrote:
>> Kemeng Shi <shikemeng@huaweicloud.com> writes:
>>
>>> Hi, this series contain some random cleanup patches and some bugfix
>>> patches to make EXT4_MB_HINT_GOAL_ONLY work properly, protect pa->pa_free
>>> from race and so on. More details can be found in git log.
>>> Thanks!
>>
>> Hi Kemeng,
>>
>> Did you run any testing on these patches? Because I was very easily able
>> to hit ext/009 causing kernel BUG_ON with default mkfs/mount options.
>> It's always a good and recommended practice to ensure some level of
>> testing on any of the patches we submit to community for review
>> and call out in the cover letter on what has been tested and what is not.
> 
> Hi Kemeng,
> 
> If you need help running xfstests, I maintain a test appliance which
> makes it very easy to run xfstests on development kernels.  Please see:
> 
> https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-xfstests.md
> https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md
> 
> This test appliance can also be run on Android devices and using
> Google Compute Engine; for more information see:
> 
> 	https://thunk.org/android-xfstests
> 	https://thunk.org/gce-xfstests
> 
> If you're just getting started, I recommend that you start with
> kvm-xfstests, and this is the simplest way to get started.
Hi, Theodore and Ritesh. Thanks for feedback. I will run xfstests before submitting
next version. Thanks!

-- 
Best wishes
Kemeng Shi