Date:   Tue, 28 Feb 2023 18:17:33 -0800
From:   "H. Peter Anvin" <hpa@zytor.com>
To:     "Li, Xin3" <xin3.li@intel.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: =?US-ASCII?Q?RE=3A_=5BRFC_PATCH_v3_15/32=5D_x86/fred=3A_make_unio?= =?US-ASCII?Q?ns_for_the_cs_and_ss_fields_in_struct_pt=5Fregs?=
User-Agent: K-9 Mail for Android
In-Reply-To: <SA1PR11MB673406B8B43E18F0BD11C8DBA8A89@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20230224070145.3572-1-xin3.li@intel.com> <20230224070145.3572-16-xin3.li@intel.com> <bf1ad4c3-73eb-0f8f-e627-a7e0785fe903@citrix.com> <SA1PR11MB673406B8B43E18F0BD11C8DBA8A89@SA1PR11MB6734.namprd11.prod.outlook.com>
Message-ID: <89026D19-3E98-4D88-820B-36A29488D46D@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On February 24, 2023 8:34:36 AM PST, "Li, Xin3" <xin3=2Eli@intel=2Ecom> wro=
te:
>> > +	union {
>> > +		unsigned long  csl; /* CS + any fields above it */
>>=20
>> I guess that CSL here is supposed to mean cs long, but CSL (Current Sta=
ck Level) is a
>> new term in the FRED spec which isn't this=2E
>
>Good catch!
>
>>=20
>> This causes changes such as the final hunk in patch 27 to read incorrec=
tly, despite
>> being technically correct=2E
>>=20
>> cs_slot would be much clearer in code, but tbh, even cs_l would be bett=
er than the
>> version without an underscore=2E
>
>cs_slot sounds a good term unless someone comes up with a better one=2E
>
>>=20
>> And obviously, whatever is done here should be mirrored for ss=2E
>
>Probably ss_slot then=2E
>  Xin
>

I called it csx, for "cs extended"=2E "csq" would work, too=2E